Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware): expose CryptoKey and globalThis.CryptoKey #31193

Merged
merged 5 commits into from Nov 9, 2021
Merged

Conversation

Kikobeats
Copy link
Member

closes #30475

@ijjk

This comment has been minimized.

@panva
Copy link
Contributor

panva commented Nov 9, 2021

@Kikobeats can you explain how fixes made in this repo, fixes to the sandbox powered by node's vm, propagate to the Edge Functions runtime?

@Kikobeats
Copy link
Member Author

@panva The sandbox for running Edge Functions locally and the real environment are different things.

This PR allows using the browser APIs in the local sandbox.

In the case of the production environment, there is a Vercel Runtime for Next.js ready, so both environments are 1:1 aligned.

@panva
Copy link
Contributor

panva commented Nov 9, 2021

This PR allows using the browser APIs in the local sandbox.

So this does not (at least completely) close #30475 then, check my last comment there. It's clear the environments are not aligned.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 9, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js cryptokey Change
buildDuration 17.9s 17.9s -81ms
buildDurationCached 3.6s 3.7s ⚠️ +58ms
nodeModulesSize 333 MB 333 MB ⚠️ +284 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js cryptokey Change
/ failed reqs 0 0
/ total time (seconds) 2.944 3.023 ⚠️ +0.08
/ avg req/sec 849.09 827 ⚠️ -22.09
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.369 1.355 -0.01
/error-in-render avg req/sec 1825.63 1844.91 +19.28
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js cryptokey Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.1 kB 28.1 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js cryptokey Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js cryptokey Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js cryptokey Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js cryptokey Change
index.html gzip 524 B 524 B
link.html gzip 536 B 536 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary vercel/next.js cryptokey Change
buildDuration 19.4s 19.2s -204ms
buildDurationCached 3.6s 3.6s -17ms
nodeModulesSize 333 MB 333 MB ⚠️ +284 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary vercel/next.js cryptokey Change
/ failed reqs 0 0
/ total time (seconds) 3.003 2.96 -0.04
/ avg req/sec 832.54 844.62 +12.08
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.372 1.396 ⚠️ +0.02
/error-in-render avg req/sec 1821.5 1791.46 ⚠️ -30.04
Client Bundles (main, webpack, commons)
vercel/next.js canary vercel/next.js cryptokey Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js cryptokey Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js cryptokey Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary vercel/next.js cryptokey Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js cryptokey Change
index.html gzip 524 B 524 B
link.html gzip 536 B 536 B
withRouter.html gzip 517 B 517 B
Overall change 1.58 kB 1.58 kB
Commit: 5910686

@kodiakhq kodiakhq bot merged commit 0bcb714 into canary Nov 9, 2021
@kodiakhq kodiakhq bot deleted the cryptokey branch November 9, 2021 17:39
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[middlewares] globalThis and globalThis.CryptoKey is missing
5 participants