Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close stream when fatal error occurs #31164

Merged
merged 3 commits into from Nov 15, 2021
Merged

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Nov 8, 2021

Resolves: #30989
x-ref: #30424 (comment)

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Nov 8, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@huozhi huozhi marked this pull request as ready for review November 12, 2021 01:21
@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 12, 2021

Failing test suites

Commit: f02ddc5

test/integration/react-streaming-and-server-components/test/index.test.js

  • document dev > should error when custom _document has getInitialProps method
  • document prod > should error when custom _document has getInitialProps method
Expand output

● document dev › should error when custom _document has getInitialProps method

thrown: "Exceeded timeout of 90000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  175 | })
  176 |
> 177 | const cssSuite = {
      |         ^
  178 |   runTests: css,
  179 |   before: () => appPage.write(appWithGlobalCss),
  180 |   after: () => appPage.delete(),

  at runTests (integration/react-streaming-and-server-components/test/index.test.js:177:9)
  at integration/react-streaming-and-server-components/test/index.test.js:281:9
  at runSuite (integration/react-streaming-and-server-components/test/index.test.js:262:5)
  at Object.<anonymous> (integration/react-streaming-and-server-components/test/index.test.js:188:1)

● document prod › should error when custom _document has getInitialProps method

thrown: "Exceeded timeout of 90000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."

  175 | })
  176 |
> 177 | const cssSuite = {
      |         ^
  178 |   runTests: css,
  179 |   before: () => appPage.write(appWithGlobalCss),
  180 |   after: () => appPage.delete(),

  at runTests (integration/react-streaming-and-server-components/test/index.test.js:177:9)
  at integration/react-streaming-and-server-components/test/index.test.js:281:9
  at runSuite (integration/react-streaming-and-server-components/test/index.test.js:262:5)
  at Object.<anonymous> (integration/react-streaming-and-server-components/test/index.test.js:189:1)

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 15, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
buildDuration 24.4s 24.4s -15ms
buildDurationCached 4.7s 4.7s -30ms
nodeModulesSize 335 MB 335 MB ⚠️ +1.21 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
/ failed reqs 0 0
/ total time (seconds) 4.165 4.266 ⚠️ +0.1
/ avg req/sec 600.21 586.04 ⚠️ -14.17
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.103 2.13 ⚠️ +0.03
/error-in-render avg req/sec 1188.87 1173.52 ⚠️ -15.35
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28.3 kB 28.3 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 72.2 kB 72.2 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
_app-HASH.js gzip 1.37 kB 1.37 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.3 kB 13.3 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
index.html gzip 521 B 521 B
link.html gzip 534 B 534 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
buildDuration 25.9s 26.1s ⚠️ +252ms
buildDurationCached 4.7s 4.8s ⚠️ +93ms
nodeModulesSize 335 MB 335 MB ⚠️ +1.21 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
/ failed reqs 0 0
/ total time (seconds) 4.092 4.201 ⚠️ +0.11
/ avg req/sec 610.96 595.04 ⚠️ -15.92
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.145 2.189 ⚠️ +0.04
/error-in-render avg req/sec 1165.68 1141.94 ⚠️ -23.74
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.5 kB 28.5 kB
webpack-HASH.js gzip 1.44 kB 1.44 kB
Overall change 72.5 kB 72.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
_app-HASH.js gzip 1.35 kB 1.35 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 13.2 kB 13.2 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/streaming-500 Change
index.html gzip 523 B 523 B
link.html gzip 535 B 535 B
withRouter.html gzip 516 B 516 B
Overall change 1.57 kB 1.57 kB
Commit: daf66ea

@huozhi huozhi requested a review from devknoll November 15, 2021 16:12
@ijjk ijjk merged commit ef57953 into vercel:canary Nov 15, 2021
@huozhi huozhi deleted the fix/streaming-500 branch November 15, 2021 18:21
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error routes (404, 500) in React Server Components
4 participants