Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False Requirement: isolatedModules is set to true for babel when not using babel #31149

Closed
vossmalte opened this issue Nov 8, 2021 · 2 comments · Fixed by #31150
Closed

False Requirement: isolatedModules is set to true for babel when not using babel #31149

vossmalte opened this issue Nov 8, 2021 · 2 comments · Fixed by #31150
Labels
bug Issue was opened via the bug report template.

Comments

@vossmalte
Copy link

vossmalte commented Nov 8, 2021

What version of Next.js are you using?

12.0.3

What version of Node.js are you using?

16.9.4

What browser are you using?

Chrome

What operating system are you using?

Ubuntu

How are you deploying your application?

vercel

Describe the Bug

A dependency does not have isolatedModules and thus breaks next build. We are not using babel anymore in favor of swc.
The following mandatory changes were made to your tsconfig.json:
- isolatedModules was set to true (requirement for babel)

Then the build fails because of no isolated modules

Expected Behavior

Allow isolatedModules or enhance error message

To Reproduce

Set isolatedModules in tsconfig.json to true and run next build.

@vossmalte vossmalte added the bug Issue was opened via the bug report template. label Nov 8, 2021
timneutkens added a commit to timneutkens/next.js that referenced this issue Nov 8, 2021
This is still required with SWC. The message just wasn't updated.

Fixes vercel#31149
@timneutkens
Copy link
Member

This requirement is still the same, we just didn't update the reason message, opened #31150 to update that.

@kodiakhq kodiakhq bot closed this as completed in #31150 Nov 8, 2021
kodiakhq bot pushed a commit to timneutkens/next.js that referenced this issue Nov 8, 2021
…#31150)

This is still required with SWC. The message just wasn't updated.

Fixes vercel#31149



## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
natew pushed a commit to natew/next.js that referenced this issue Feb 16, 2022
…#31150)

This is still required with SWC. The message just wasn't updated.

Fixes vercel#31149



## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `yarn lint`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants