Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change .web extension of document page to part of path #31116

Merged
merged 1 commit into from Nov 7, 2021

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Nov 7, 2021

Fixes: #31104

This effecting users who are using expo with next @expo/next-adapter since react-native use .web, .ios and .android to identify platform. Reference.

Since the page extension can be any from user configuration, change document.web.js to document-web.js as fallback page in web runtime.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Nov 7, 2021
@ijjk
Copy link
Member

ijjk commented Nov 7, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
buildDuration 19.5s 19.9s ⚠️ +398ms
buildDurationCached 4.1s 4s -64ms
nodeModulesSize 332 MB 332 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
/ failed reqs 0 0
/ total time (seconds) 3.202 3.272 ⚠️ +0.07
/ avg req/sec 780.82 764.07 ⚠️ -16.75
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.552 1.578 ⚠️ +0.03
/error-in-render avg req/sec 1611.06 1584.76 ⚠️ -26.3
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
index.html gzip 522 B 522 B
link.html gzip 535 B 535 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
buildDuration 21.5s 21.5s ⚠️ +10ms
buildDurationCached 4s 3.9s -62ms
nodeModulesSize 332 MB 332 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
/ failed reqs 0 0
/ total time (seconds) 3.346 3.441 ⚠️ +0.09
/ avg req/sec 747.26 726.47 ⚠️ -20.79
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.465 1.616 ⚠️ +0.15
/error-in-render avg req/sec 1706.13 1546.86 ⚠️ -159.27
Client Bundles (main, webpack, commons)
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary huozhi/next.js fix/doc-web-ext Change
index.html gzip 521 B 521 B
link.html gzip 534 B 534 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB
Commit: c61a963

@huozhi huozhi marked this pull request as ready for review November 7, 2021 21:59
Copy link
Member

@shuding shuding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sgtm. .web-runtime.js is another choice too.

@kodiakhq kodiakhq bot merged commit cfb8cc8 into vercel:canary Nov 7, 2021
@huozhi huozhi deleted the fix/doc-web-ext branch November 7, 2021 22:18
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Expo] [WebDocument] TypeError: Cannot call a class as a function
3 participants