Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change disabled SWC message to Log.info #31091

Merged
merged 1 commit into from Nov 6, 2021

Conversation

timneutkens
Copy link
Member

Based on feedback from @flybayer, this changes the warn - to info - for the "Disabled SWC" message.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

Based on feedback from @flybayer, this changes the `warn - ` to `info -` for the "Disabled SWC" message.
@ijjk
Copy link
Member

ijjk commented Nov 6, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
buildDuration 26.4s 26.8s ⚠️ +398ms
buildDurationCached 5.7s 5.3s -351ms
nodeModulesSize 332 MB 332 MB ⚠️ +8 B
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
/ failed reqs 0 0
/ total time (seconds) 4.011 4.051 ⚠️ +0.04
/ avg req/sec 623.22 617.18 ⚠️ -6.04
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.193 2.124 -0.07
/error-in-render avg req/sec 1139.79 1177.06 +37.27
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
index.html gzip 522 B 522 B
link.html gzip 535 B 535 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
buildDuration 28.2s 28.3s ⚠️ +74ms
buildDurationCached 5.2s 4.9s -302ms
nodeModulesSize 332 MB 332 MB ⚠️ +8 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
/ failed reqs 0 0
/ total time (seconds) 4.282 4.504 ⚠️ +0.22
/ avg req/sec 583.78 555.1 ⚠️ -28.68
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.954 2.083 ⚠️ +0.13
/error-in-render avg req/sec 1279.18 1200 ⚠️ -79.18
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary timneutkens/next.js add/warn-to-info-swc Change
index.html gzip 521 B 521 B
link.html gzip 534 B 534 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB
Commit: d7bc3da

@kodiakhq kodiakhq bot merged commit f8e6661 into vercel:canary Nov 6, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants