share collections in middleware vm context

[panva]

When libraries are required outside of the middleware function context and they do checks such as a instanceof Uint8Array since the constructors are different between the two contexts they'll always yield false.

This is a problem for libraries validating user input as well as the WebCryptoAPI polyfill used outside of Edge Functions.

• Fixes [middlewares via next dev]: WebCrypto issue with Uint8Array and key generation #30477
• Fixes [Middleware] Support browser Uint8Array instead of Node's version #30911

This is only a problem for the sandbox runtime, not when ran inside an Edge Function.

[javivelasco]

Could you add a test?

[ijjk]

Failing test suites

Commit: b52bd3c

test/integration/react-streaming-and-server-components/test/index.test.js

• concurrentFeatures - dev > should support React.lazy and dynamic imports

Expand output

● concurrentFeatures - dev › should support React.lazy and dynamic imports

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `concurrentFeatures - dev should support React.lazy and dynamic imports 1`

Snapshot: "foo.client"
Received: "loading..."

  161 |   afterAll(async () => {
  162 |     await killApp(context.server)
> 163 |   })
      |     ^
  164 |
  165 |   it('should support React.lazy and dynamic imports', async () => {
  166 |     const html = await renderViaHTTP(context.appPort, '/dynamic-imports')

  at Object.<anonymous> (integration/react-streaming-and-server-components/test/index.test.js:163:25)

[ijjk]

Change and added test look good, thanks for the PR!

[styfle]

Thanks!

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	panva/next.js add-collections	Change
buildDuration	22.6s	20.4s	-2.2s
buildDurationCached	4.1s	4.2s	⚠️ +86ms
nodeModulesSize	333 MB	333 MB	⚠️ +1.02 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	panva/next.js add-collections	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.36	3.336	-0.02
/ avg req/sec	744.08	749.34	+5.26
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.502	1.517	⚠️ +0.01
/error-in-render avg req/sec	1663.95	1647.88	⚠️ -16.07

Client Bundles (main, webpack, commons)

	vercel/next.js canary	panva/next.js add-collections	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28.1 kB	28.1 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	71.9 kB	71.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	panva/next.js add-collections	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	panva/next.js add-collections	Change
_app-HASH.js gzip	1.23 kB	1.23 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.44 kB	4.44 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	panva/next.js add-collections	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	panva/next.js add-collections	Change
index.html gzip	524 B	524 B	✓
link.html gzip	535 B	535 B	✓
withRouter.html gzip	518 B	518 B	✓
Overall change	1.58 kB	1.58 kB	✓

---

Default Build with SWC (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	panva/next.js add-collections	Change
buildDuration	22.4s	21.7s	-772ms
buildDurationCached	4.1s	4.1s	⚠️ +51ms
nodeModulesSize	333 MB	333 MB	⚠️ +1.02 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	panva/next.js add-collections	Change
/ failed reqs	0	0	✓
/ total time (seconds)	3.314	3.351	⚠️ +0.04
/ avg req/sec	754.48	745.99	⚠️ -8.49
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.565	1.631	⚠️ +0.07
/error-in-render avg req/sec	1597.7	1532.67	⚠️ -65.03

Client Bundles (main, webpack, commons)

	vercel/next.js canary	panva/next.js add-collections	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.2 kB	28.2 kB	✓
webpack-HASH.js gzip	1.43 kB	1.43 kB	✓
Overall change	72.1 kB	72.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	panva/next.js add-collections	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	panva/next.js add-collections	Change
_app-HASH.js gzip	1.22 kB	1.22 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.46 kB	4.46 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.91 kB	1.91 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
85e02e95b279..7e3.css gzip	107 B	107 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	panva/next.js add-collections	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	panva/next.js add-collections	Change
index.html gzip	523 B	523 B	✓
link.html gzip	536 B	536 B	✓
withRouter.html gzip	516 B	516 B	✓
Overall change	1.57 kB	1.57 kB	✓

Commit: 242e9c1