Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure decode error in minimal mode responds with 400 not 500 #31037

Merged
merged 2 commits into from Nov 5, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 5, 2021

This ensures we handle decode failures in minimal mode as a 400 response (bad request) instead of a 500 (server error).

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Nov 5, 2021
@ijjk

This comment has been minimized.

@ijjk ijjk marked this pull request as ready for review November 5, 2021 16:26
@ijjk
Copy link
Member Author

ijjk commented Nov 5, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
buildDuration 21.4s 21.4s ⚠️ +60ms
buildDurationCached 4.3s 4.3s ⚠️ +23ms
nodeModulesSize 332 MB 332 MB ⚠️ +703 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
/ failed reqs 0 0
/ total time (seconds) 3.455 3.572 ⚠️ +0.12
/ avg req/sec 723.6 699.83 ⚠️ -23.77
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.646 1.721 ⚠️ +0.08
/error-in-render avg req/sec 1518.5 1452.41 ⚠️ -66.09
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
index.html gzip 522 B 522 B
link.html gzip 535 B 535 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
buildDuration 23.1s 23.9s ⚠️ +767ms
buildDurationCached 4.5s 4.7s ⚠️ +159ms
nodeModulesSize 332 MB 332 MB ⚠️ +703 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
/ failed reqs 0 0
/ total time (seconds) 3.631 3.641 ⚠️ +0.01
/ avg req/sec 688.54 686.6 ⚠️ -1.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.665 1.786 ⚠️ +0.12
/error-in-render avg req/sec 1501.46 1399.93 ⚠️ -101.53
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/minimal-400-handling Change
index.html gzip 521 B 521 B
link.html gzip 534 B 534 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB
Commit: 659f3b0

@kodiakhq kodiakhq bot merged commit fab345d into vercel:canary Nov 5, 2021
@ijjk ijjk deleted the fix/minimal-400-handling branch November 8, 2021 16:39
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants