Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias react-dom/server based on environment #31035

Closed
devknoll opened this issue Nov 5, 2021 · 2 comments
Closed

Alias react-dom/server based on environment #31035

devknoll opened this issue Nov 5, 2021 · 2 comments
Assignees
@shuding
Labels
area: Server Components React Server Components

Comments

@devknoll
Copy link
Contributor

devknoll commented Nov 5, 2021 •
edited

For now, react-dom/server should be aliased to react-dom/server.(browser|node).(production|development) via webpack (i.e. code should import react-dom/server directly). This more closely matches the longer term strategy for React's bundling using conditional exports.
@devknoll devknoll mentioned this issue Nov 5, 2021
Merged
10 tasks
@devknoll devknoll changed the title Alias react-dom/server to react-dom/server.(browser|node) based on environment Alias react-dom/server based on environment Nov 5, 2021
@shuding
Copy link
Member

shuding commented Nov 7, 2021

Closing as resolved in #30906.

@shuding shuding closed this as completed Nov 7, 2021
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shuding shuding

Labels
area: Server Components React Server Components
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@devknoll @shuding @timneutkens @balazsorban44