Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental next-swc jest transform #30993

Merged
merged 6 commits into from Nov 8, 2021

Conversation

padmaia
Copy link
Member

@padmaia padmaia commented Nov 4, 2021

Closes #30811

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Nov 4, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@padmaia padmaia marked this pull request as ready for review November 5, 2021 01:01
jest.config.js Outdated Show resolved Hide resolved
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@ijjk

This comment has been minimized.

Co-authored-by: JJ Kasper <jj@jjsweb.site>
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 5, 2021

Failing test suites

Commit: e27495f

test/integration/react-streaming-and-server-components/test/index.test.js

  • concurrentFeatures - dev > should support React.lazy and dynamic imports
Expand output

● concurrentFeatures - dev › should support React.lazy and dynamic imports

expect(received).toMatchInlineSnapshot(snapshot)

Snapshot name: `concurrentFeatures - dev should support React.lazy and dynamic imports 1`

Snapshot: "foo.client"
Received: "loading..."

  155 |
  156 |   beforeAll(async () => {
> 157 |     context.appPort = await findPort()
      |                         ^
  158 |     context.server = await nextDev(context.appDir, context.appPort)
  159 |   })
  160 |   afterAll(async () => {

  at Object.<anonymous> (integration/react-streaming-and-server-components/test/index.test.js:157:25)

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Nov 8, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js add/swc-jest Change
buildDuration 21.3s 20.9s -370ms
buildDurationCached 4.2s 4.2s -74ms
nodeModulesSize 332 MB 332 MB ⚠️ +6.21 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js add/swc-jest Change
/ failed reqs 0 0
/ total time (seconds) 3.446 3.448 0
/ avg req/sec 725.56 724.98 ⚠️ -0.58
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.607 1.671 ⚠️ +0.06
/error-in-render avg req/sec 1555.92 1495.93 ⚠️ -59.99
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js add/swc-jest Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js add/swc-jest Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js add/swc-jest Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js add/swc-jest Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js add/swc-jest Change
index.html gzip 521 B 521 B
link.html gzip 533 B 533 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary padmaia/next.js add/swc-jest Change
buildDuration 22.6s 22.6s ⚠️ +9ms
buildDurationCached 4.1s 4.3s ⚠️ +162ms
nodeModulesSize 332 MB 332 MB ⚠️ +6.21 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary padmaia/next.js add/swc-jest Change
/ failed reqs 0 0
/ total time (seconds) 3.42 3.423 0
/ avg req/sec 730.92 730.33 ⚠️ -0.59
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.569 1.62 ⚠️ +0.05
/error-in-render avg req/sec 1593.22 1543.43 ⚠️ -49.79
Client Bundles (main, webpack, commons)
vercel/next.js canary padmaia/next.js add/swc-jest Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary padmaia/next.js add/swc-jest Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary padmaia/next.js add/swc-jest Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary padmaia/next.js add/swc-jest Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary padmaia/next.js add/swc-jest Change
index.html gzip 522 B 522 B
link.html gzip 535 B 535 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB
Commit: 1bcdcca

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@timneutkens timneutkens merged commit bc88831 into vercel:canary Nov 8, 2021
@timneutkens timneutkens deleted the add/swc-jest branch November 8, 2021 16:35
@timneutkens timneutkens changed the title Add next-swc jest transform Add experimental next-swc jest transform Nov 8, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Jest transformer using next-swc
3 participants