Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the SSR middleware runtime size #30906

Merged
merged 8 commits into from Nov 5, 2021
Merged

Conversation

shuding
Copy link
Member

@shuding shuding commented Nov 3, 2021

By conditionally importing react-dom/server under the web runtime and reusing renderToReadableStream instead of renderToStaticMarkup, we can get rid of the legacy browser React DOM server from the runtime. Furthermore we can make the build target es6 for the SSR middleware, and make some code paths tree-shakable (done in another PR).

Together this makes the runtime ~32kb smaller.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running yarn lint

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Nov 3, 2021
@ijjk

This comment has been minimized.

@shuding shuding marked this pull request as ready for review November 5, 2021 15:22
@shuding shuding requested a review from devknoll November 5, 2021 15:22
@ijjk

This comment has been minimized.

@shuding shuding requested a review from devknoll November 5, 2021 17:34
devknoll
devknoll previously approved these changes Nov 5, 2021
@ijjk

This comment has been minimized.

huozhi
huozhi previously approved these changes Nov 5, 2021
@ijjk

This comment has been minimized.

@shuding shuding dismissed stale reviews from huozhi and devknoll via 92f00ab November 5, 2021 20:47
@shuding shuding requested a review from huozhi November 5, 2021 20:48
@ijjk
Copy link
Member

ijjk commented Nov 5, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/55d4 Change
buildDuration 20.9s 20.7s -282ms
buildDurationCached 4.2s 4.2s -26ms
nodeModulesSize 332 MB 332 MB ⚠️ +1.38 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/55d4 Change
/ failed reqs 0 0
/ total time (seconds) 3.352 3.403 ⚠️ +0.05
/ avg req/sec 745.9 734.69 ⚠️ -11.21
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.65 1.541 -0.11
/error-in-render avg req/sec 1515.5 1622.15 +106.65
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/55d4 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/55d4 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/55d4 Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/55d4 Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/55d4 Change
index.html gzip 522 B 522 B
link.html gzip 535 B 535 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB

Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/55d4 Change
buildDuration 22.3s 22.2s -116ms
buildDurationCached 4.2s 4.1s -161ms
nodeModulesSize 332 MB 332 MB ⚠️ +1.38 kB
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/55d4 Change
/ failed reqs 0 0
/ total time (seconds) 3.415 3.356 -0.06
/ avg req/sec 732.13 744.96 +12.83
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.674 1.589 -0.08
/error-in-render avg req/sec 1493.85 1573.44 +79.59
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/55d4 Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/55d4 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary shuding/next.js shu/55d4 Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary shuding/next.js shu/55d4 Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/55d4 Change
index.html gzip 521 B 521 B
link.html gzip 534 B 534 B
withRouter.html gzip 515 B 515 B
Overall change 1.57 kB 1.57 kB
Commit: de4de9b

@kodiakhq kodiakhq bot merged commit 0307ba0 into vercel:canary Nov 5, 2021
@shuding shuding deleted the shu/55d4 branch November 5, 2021 21:51
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants