Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check compiled step #30645

Merged
merged 3 commits into from
Oct 30, 2021
Merged

Fix check compiled step #30645

merged 3 commits into from
Oct 30, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 30, 2021

This ensures the check compiled step runs without build-native since we only run build-native during publish now.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 30, 2021
@ijjk
Copy link
Member Author

ijjk commented Oct 30, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
buildDuration 18.7s 18.4s -309ms
buildDurationCached 5.3s 3.9s -1.4s
nodeModulesSize 294 MB 294 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
/ failed reqs 0 0
/ total time (seconds) 2.968 2.976 ⚠️ +0.01
/ avg req/sec 842.45 840 ⚠️ -2.45
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.412 1.399 -0.01
/error-in-render avg req/sec 1770.32 1786.83 +16.51
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
index.html gzip 534 B 534 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Increase detected ⚠️)
General
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
buildDuration 24.6s 19.9s -4.7s
buildDurationCached 4s 4s ⚠️ +59ms
nodeModulesSize 294 MB 294 MB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
/ failed reqs 0 0
/ total time (seconds) 2.921 2.992 ⚠️ +0.07
/ avg req/sec 855.91 835.46 ⚠️ -20.45
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.418 1.385 -0.03
/error-in-render avg req/sec 1763.21 1805.42 +42.21
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/check-precompiled Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: cc6fabb

@ijjk ijjk marked this pull request as ready for review October 30, 2021 04:29
@ijjk ijjk merged commit 18a3991 into vercel:canary Oct 30, 2021
@ijjk ijjk deleted the fix/check-precompiled branch October 30, 2021 04:29
This was referenced Nov 1, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants