Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert incremental config to fix missing types #30644

Merged
merged 2 commits into from
Oct 30, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 30, 2021

This reverts the incremental config change from #30371 since it seems to cause missing types in our dist folder. This also adds an initial isolated TypeScript test to ensure we don't regress on this. We should also work to migrate the other TypeScript tests to isolated so they are being tested properly.

@ijjk
Copy link
Member Author

ijjk commented Oct 30, 2021

Stats from current PR

Default Build (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/missing-types Change
buildDuration 24s 24s ⚠️ +28ms
buildDurationCached 5s 4.9s -82ms
nodeModulesSize 294 MB 294 MB -12 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/missing-types Change
/ failed reqs 0 0
/ total time (seconds) 4.106 3.959 -0.15
/ avg req/sec 608.87 631.4 +22.53
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.181 2.171 -0.01
/error-in-render avg req/sec 1146.36 1151.32 +4.96
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/missing-types Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.2 kB 42.2 kB
main-HASH.js gzip 28 kB 28 kB
webpack-HASH.js gzip 1.45 kB 1.45 kB
Overall change 71.9 kB 71.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/missing-types Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/missing-types Change
_app-HASH.js gzip 1.23 kB 1.23 kB
_error-HASH.js gzip 194 B 194 B
amp-HASH.js gzip 312 B 312 B
css-HASH.js gzip 327 B 327 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 350 B 350 B
hooks-HASH.js gzip 635 B 635 B
image-HASH.js gzip 4.44 kB 4.44 kB
index-HASH.js gzip 263 B 263 B
link-HASH.js gzip 1.87 kB 1.87 kB
routerDirect..HASH.js gzip 321 B 321 B
script-HASH.js gzip 383 B 383 B
withRouter-HASH.js gzip 318 B 318 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/missing-types Change
_buildManifest.js gzip 459 B 459 B
Overall change 459 B 459 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/missing-types Change
index.html gzip 534 B 534 B
link.html gzip 546 B 546 B
withRouter.html gzip 527 B 527 B
Overall change 1.61 kB 1.61 kB

Default Build with SWC (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/missing-types Change
buildDuration 25.9s 25.7s -116ms
buildDurationCached 5.1s 5.1s -13ms
nodeModulesSize 294 MB 294 MB -12 B
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js fix/missing-types Change
/ failed reqs 0 0
/ total time (seconds) 3.935 3.957 ⚠️ +0.02
/ avg req/sec 635.35 631.72 ⚠️ -3.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 2.109 2.102 -0.01
/error-in-render avg req/sec 1185.12 1189.46 +4.34
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js fix/missing-types Change
450.HASH.js gzip 179 B 179 B
framework-HASH.js gzip 42.3 kB 42.3 kB
main-HASH.js gzip 28.2 kB 28.2 kB
webpack-HASH.js gzip 1.43 kB 1.43 kB
Overall change 72.1 kB 72.1 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/missing-types Change
polyfills-a4..dd70.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js fix/missing-types Change
_app-HASH.js gzip 1.22 kB 1.22 kB
_error-HASH.js gzip 180 B 180 B
amp-HASH.js gzip 305 B 305 B
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.38 kB 2.38 kB
head-HASH.js gzip 342 B 342 B
hooks-HASH.js gzip 622 B 622 B
image-HASH.js gzip 4.46 kB 4.46 kB
index-HASH.js gzip 256 B 256 B
link-HASH.js gzip 1.91 kB 1.91 kB
routerDirect..HASH.js gzip 314 B 314 B
script-HASH.js gzip 375 B 375 B
withRouter-HASH.js gzip 309 B 309 B
334f979574ae..6f4.css gzip 106 B 106 B
Overall change 13.1 kB 13.1 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/missing-types Change
_buildManifest.js gzip 460 B 460 B
Overall change 460 B 460 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js fix/missing-types Change
index.html gzip 534 B 534 B
link.html gzip 547 B 547 B
withRouter.html gzip 528 B 528 B
Overall change 1.61 kB 1.61 kB
Commit: e97a44e

@ijjk ijjk merged commit 097fb3c into vercel:canary Oct 30, 2021
@ijjk ijjk deleted the fix/missing-types branch October 30, 2021 04:16
This was referenced Nov 1, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants