Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add buffering for streaming until the shell is completed #30585

Merged
merged 3 commits into from
Oct 29, 2021
Merged

Add buffering for streaming until the shell is completed #30585

merged 3 commits into from
Oct 29, 2021

Conversation

shuding
Copy link
Member

@shuding shuding commented Oct 28, 2021

This PR adds buffering to renderToReadableStream with onCompleteShell, to ensure that we don't flush too early and <head> is completed when the client receives the first chunk of data.

X-ref: #30547.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 28, 2021
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Oct 29, 2021

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/7b6d Change
buildDuration 23.2s 23.5s ⚠️ +239ms
buildDurationCached 4.7s 4.7s ✓
nodeModulesSize 199 MB 199 MB ⚠️ +818 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary shuding/next.js shu/7b6d Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.016 4.205 ⚠️ +0.19
/ avg req/sec 622.46 594.51 ⚠️ -27.95
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.05 2.16 ⚠️ +0.11
/error-in-render avg req/sec 1219.72 1157.45 ⚠️ -62.27
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/7b6d Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.2 kB 42.2 kB ✓
main-HASH.js gzip 28 kB 28 kB ✓
webpack-HASH.js gzip 1.45 kB 1.45 kB ✓
Overall change 71.9 kB 71.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/7b6d Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/7b6d Change
_app-HASH.js gzip 1.23 kB 1.23 kB ✓
_error-HASH.js gzip 194 B 194 B ✓
amp-HASH.js gzip 312 B 312 B ✓
css-HASH.js gzip 327 B 327 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 350 B 350 B ✓
hooks-HASH.js gzip 635 B 635 B ✓
image-HASH.js gzip 4.44 kB 4.44 kB ✓
index-HASH.js gzip 263 B 263 B ✓
link-HASH.js gzip 1.87 kB 1.87 kB ✓
routerDirect..HASH.js gzip 321 B 321 B ✓
script-HASH.js gzip 383 B 383 B ✓
withRouter-HASH.js gzip 318 B 318 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/7b6d Change
_buildManifest.js gzip 459 B 459 B ✓
Overall change 459 B 459 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/7b6d Change
index.html gzip 533 B 533 B ✓
link.html gzip 546 B 546 B ✓
withRouter.html gzip 527 B 527 B ✓
Overall change 1.61 kB 1.61 kB ✓
Default Build with SWC (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary shuding/next.js shu/7b6d Change
buildDuration 20s 19.7s -337ms
buildDurationCached 4.7s 4.7s -5ms
nodeModulesSize 199 MB 199 MB ⚠️ +818 B
Page Load Tests Overall increase ✓
vercel/next.js canary shuding/next.js shu/7b6d Change
/ failed reqs 0 0 ✓
/ total time (seconds) 4.047 4.011 -0.04
/ avg req/sec 617.68 623.23 +5.55
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 2.189 2.044 -0.15
/error-in-render avg req/sec 1141.94 1223.03 +81.09
Client Bundles (main, webpack, commons)
vercel/next.js canary shuding/next.js shu/7b6d Change
450.HASH.js gzip 179 B 179 B ✓
framework-HASH.js gzip 42.3 kB 42.3 kB ✓
main-HASH.js gzip 28.2 kB 28.2 kB ✓
webpack-HASH.js gzip 1.43 kB 1.43 kB ✓
Overall change 72.1 kB 72.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary shuding/next.js shu/7b6d Change
polyfills-a4..dd70.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary shuding/next.js shu/7b6d Change
_app-HASH.js gzip 1.22 kB 1.22 kB ✓
_error-HASH.js gzip 180 B 180 B ✓
amp-HASH.js gzip 305 B 305 B ✓
css-HASH.js gzip 321 B 321 B ✓
dynamic-HASH.js gzip 2.38 kB 2.38 kB ✓
head-HASH.js gzip 342 B 342 B ✓
hooks-HASH.js gzip 622 B 622 B ✓
image-HASH.js gzip 4.46 kB 4.46 kB ✓
index-HASH.js gzip 256 B 256 B ✓
link-HASH.js gzip 1.91 kB 1.91 kB ✓
routerDirect..HASH.js gzip 314 B 314 B ✓
script-HASH.js gzip 375 B 375 B ✓
withRouter-HASH.js gzip 309 B 309 B ✓
334f979574ae..6f4.css gzip 106 B 106 B ✓
Overall change 13.1 kB 13.1 kB ✓
Client Build Manifests
vercel/next.js canary shuding/next.js shu/7b6d Change
_buildManifest.js gzip 460 B 460 B ✓
Overall change 460 B 460 B ✓
Rendered Page Sizes
vercel/next.js canary shuding/next.js shu/7b6d Change
index.html gzip 534 B 534 B ✓
link.html gzip 548 B 548 B ✓
withRouter.html gzip 528 B 528 B ✓
Overall change 1.61 kB 1.61 kB ✓
Commit: b2786f1

@kodiakhq kodiakhq bot merged commit f6b15b5 into vercel:canary Oct 29, 2021
@shuding shuding deleted the shu/7b6d branch October 29, 2021 10:55
@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@padmaia padmaia Awaiting requested review from padmaia

@styfle styfle Awaiting requested review from styfle

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
No open projects
React Server Components in Next.js (A...
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@shuding @ijjk @timneutkens @styfle