fix: support --cache-strategy ESLint argument (fixes #29926)

[OKinane]

Fixes #29926

Bug

• Related issues linked using fixes #number
• Integration tests added
• Errors have helpful link attached, see contributing.md

[OKinane]

fixes #29926

[housseindjirdeh]

Thanks for this! Would it be possible to add an integration test for this flag similar to how we added one for --cache-location?

[OKinane]

Thanks for this! Would it be possible to add an integration test for this flag similar to how we added one for --cache-location?

It's stated in the tests's readme that no new test should be add in the integration folder. Should I still add one ?

[styfle]

Take a look at this test for an example

next.js/test/integration/eslint/test/index.test.js

Lines 530 to 537 in c8f25ba

	test('the --cache-location flag allows the user to define a separate cache location', async () => {
	const cacheFile = join(dirEslintCache, '.eslintcache')
	await fs.remove(cacheFile)
	await nextLint(dirEslintCache, ['--cache-location', cacheFile])
	expect(fs.existsSync(cacheFile)).toBe(true)
	})

[OKinane]

@housseindjirdeh @styfle I've add two integration tests, which btw helped me find a bug in my first implementation 😃

[ijjk]

Failing test suites

Commit: c951513

test/integration/preload-viewport/test/index.test.js

• Prefetching Links in viewport > should not prefetch already loaded scripts

Expand output

● Prefetching Links in viewport › should not prefetch already loaded scripts

expect(received).toBe(expected) // Object.is equality

Expected: false
Received: true

  397 |     expect(hrefs).toEqual([...new Set(hrefs)])
  398 |
> 399 |     // Verify encoding
      |     ^
  400 |     expect(hrefs.some((e) => e.includes(`%5Bhello%5D-`))).toBe(true)
  401 |   })
  402 |

  at Object.<anonymous> (integration/preload-viewport/test/index.test.js:399:5)

[OKinane]

All failed tests seem unrelated to my changes. Do you confirm @styfle @housseindjirdeh ?

[ijjk]

Stats from current PR

Default Build (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
buildDuration	17.6s	17.7s	⚠️ +86ms
buildDurationCached	3.5s	3.6s	⚠️ +35ms
nodeModulesSize	332 MB	332 MB	⚠️ +340 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.888	2.857	-0.03
/ avg req/sec	865.58	875.17	+9.59
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.352	1.391	⚠️ +0.04
/error-in-render avg req/sec	1849.11	1796.95	⚠️ -52.16

Client Bundles (main, webpack, commons)

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.2 kB	42.2 kB	✓
main-HASH.js gzip	28 kB	28 kB	✓
webpack-HASH.js gzip	1.45 kB	1.45 kB	✓
Overall change	71.9 kB	71.9 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
_app-HASH.js gzip	1.23 kB	1.23 kB	✓
_error-HASH.js gzip	194 B	194 B	✓
amp-HASH.js gzip	312 B	312 B	✓
css-HASH.js gzip	327 B	327 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	350 B	350 B	✓
hooks-HASH.js gzip	635 B	635 B	✓
image-HASH.js gzip	4.44 kB	4.44 kB	✓
index-HASH.js gzip	263 B	263 B	✓
link-HASH.js gzip	1.87 kB	1.87 kB	✓
routerDirect..HASH.js gzip	321 B	321 B	✓
script-HASH.js gzip	383 B	383 B	✓
withRouter-HASH.js gzip	318 B	318 B	✓
334f979574ae..6f4.css gzip	106 B	106 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
_buildManifest.js gzip	459 B	459 B	✓
Overall change	459 B	459 B	✓

Rendered Page Sizes

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
index.html gzip	522 B	522 B	✓
link.html gzip	535 B	535 B	✓
withRouter.html gzip	515 B	515 B	✓
Overall change	1.57 kB	1.57 kB	✓

---

Default Build with SWC (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
buildDuration	19s	20.7s	⚠️ +1.7s
buildDurationCached	3.6s	3.6s	⚠️ +36ms
nodeModulesSize	332 MB	332 MB	⚠️ +340 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.893	2.855	-0.04
/ avg req/sec	864.22	875.77	+11.55
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.406	1.352	-0.05
/error-in-render avg req/sec	1777.69	1849.56	+71.87

Client Bundles (main, webpack, commons)

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
450.HASH.js gzip	179 B	179 B	✓
framework-HASH.js gzip	42.3 kB	42.3 kB	✓
main-HASH.js gzip	28.2 kB	28.2 kB	✓
webpack-HASH.js gzip	1.43 kB	1.43 kB	✓
Overall change	72.1 kB	72.1 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
_app-HASH.js gzip	1.22 kB	1.22 kB	✓
_error-HASH.js gzip	180 B	180 B	✓
amp-HASH.js gzip	305 B	305 B	✓
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.38 kB	2.38 kB	✓
head-HASH.js gzip	342 B	342 B	✓
hooks-HASH.js gzip	622 B	622 B	✓
image-HASH.js gzip	4.46 kB	4.46 kB	✓
index-HASH.js gzip	256 B	256 B	✓
link-HASH.js gzip	1.91 kB	1.91 kB	✓
routerDirect..HASH.js gzip	314 B	314 B	✓
script-HASH.js gzip	375 B	375 B	✓
withRouter-HASH.js gzip	309 B	309 B	✓
334f979574ae..6f4.css gzip	106 B	106 B	✓
Overall change	13.1 kB	13.1 kB	✓

Client Build Manifests

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
_buildManifest.js gzip	460 B	460 B	✓
Overall change	460 B	460 B	✓

Rendered Page Sizes

	vercel/next.js canary	OKinane/next.js support_cacheStrategy_eslint_arg	Change
index.html gzip	521 B	521 B	✓
link.html gzip	534 B	534 B	✓
withRouter.html gzip	515 B	515 B	✓
Overall change	1.57 kB	1.57 kB	✓

Commit: 12baf74