New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix development mode bug with pages with "+" and other special characters #28122
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an integration test for this change 🙏
this is my first time writing an integration test, but this seems to work. im not sure of any other way to write it without the long |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change and added test look good, thanks!
Stats from current PRDefault Build (Increase detected
|
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
buildDuration | 12.9s | 12.3s | -596ms |
buildDurationCached | 3.3s | 3.3s | |
nodeModulesSize | 61.5 MB | 61.5 MB |
Page Load Tests Overall increase ✓
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.298 | 2.126 | -0.17 |
/ avg req/sec | 1087.75 | 1175.68 | +87.93 |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.273 | 1.257 | -0.02 |
/error-in-render avg req/sec | 1963.68 | 1988.08 | +24.4 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
745.HASH.js gzip | 179 B | 179 B | ✓ |
framework-HASH.js gzip | 42.2 kB | 42.2 kB | ✓ |
main-HASH.js gzip | 23.2 kB | 23.2 kB | ✓ |
webpack-HASH.js gzip | 1.44 kB | 1.44 kB | ✓ |
Overall change | 67.1 kB | 67.1 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
_app-HASH.js gzip | 979 B | 979 B | ✓ |
_error-HASH.js gzip | 194 B | 194 B | ✓ |
amp-HASH.js gzip | 312 B | 312 B | ✓ |
css-HASH.js gzip | 329 B | 329 B | ✓ |
dynamic-HASH.js gzip | 2.65 kB | 2.65 kB | ✓ |
head-HASH.js gzip | 351 B | 351 B | ✓ |
hooks-HASH.js gzip | 918 B | 918 B | ✓ |
image-HASH.js gzip | 4.13 kB | 4.13 kB | ✓ |
index-HASH.js gzip | 261 B | 261 B | ✓ |
link-HASH.js gzip | 1.66 kB | 1.66 kB | ✓ |
routerDirect..HASH.js gzip | 318 B | 318 B | ✓ |
script-HASH.js gzip | 387 B | 387 B | ✓ |
withRouter-HASH.js gzip | 320 B | 320 B | ✓ |
bb14e60e810b..30f.css gzip | 125 B | 125 B | ✓ |
Overall change | 12.9 kB | 12.9 kB | ✓ |
Client Build Manifests
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
_buildManifest.js gzip | 492 B | 492 B | ✓ |
Overall change | 492 B | 492 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
index.html gzip | 539 B | 539 B | ✓ |
link.html gzip | 551 B | 551 B | ✓ |
withRouter.html gzip | 532 B | 532 B | ✓ |
Overall change | 1.62 kB | 1.62 kB | ✓ |
Webpack 4 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
buildDuration | 10.4s | 10.4s | |
buildDurationCached | 4.1s | 4.3s | |
nodeModulesSize | 61.5 MB | 61.5 MB |
Page Load Tests Overall decrease ⚠️
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
/ failed reqs | 0 | 0 | ✓ |
/ total time (seconds) | 2.243 | 2.372 | |
/ avg req/sec | 1114.42 | 1054.06 | |
/error-in-render failed reqs | 0 | 0 | ✓ |
/error-in-render total time (seconds) | 1.215 | 1.31 | |
/error-in-render avg req/sec | 2058.06 | 1908.92 |
Client Bundles (main, webpack, commons)
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
16.HASH.js gzip | 186 B | 186 B | ✓ |
677f882d2ed8..HASH.js gzip | 14.1 kB | 14.1 kB | ✓ |
framework.HASH.js gzip | 41.9 kB | 41.9 kB | ✓ |
main-HASH.js gzip | 10.6 kB | 10.6 kB | ✓ |
webpack-HASH.js gzip | 1.19 kB | 1.19 kB | ✓ |
Overall change | 68 kB | 68 kB | ✓ |
Legacy Client Bundles (polyfills)
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
polyfills-a4..dd70.js gzip | 31 kB | 31 kB | ✓ |
Overall change | 31 kB | 31 kB | ✓ |
Client Pages
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
_app-HASH.js gzip | 964 B | 964 B | ✓ |
_error-HASH.js gzip | 3.8 kB | 3.8 kB | ✓ |
amp-HASH.js gzip | 552 B | 552 B | ✓ |
css-HASH.js gzip | 333 B | 333 B | ✓ |
dynamic-HASH.js gzip | 2.85 kB | 2.85 kB | ✓ |
head-HASH.js gzip | 3.06 kB | 3.06 kB | ✓ |
hooks-HASH.js gzip | 924 B | 924 B | ✓ |
index-HASH.js gzip | 231 B | 231 B | ✓ |
link-HASH.js gzip | 1.64 kB | 1.64 kB | ✓ |
routerDirect..HASH.js gzip | 298 B | 298 B | ✓ |
script-HASH.js gzip | 2.98 kB | 2.98 kB | ✓ |
withRouter-HASH.js gzip | 295 B | 295 B | ✓ |
e025d2764813..52f.css gzip | 125 B | 125 B | ✓ |
Overall change | 18.1 kB | 18.1 kB | ✓ |
Client Build Manifests
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
_buildManifest.js gzip | 499 B | 499 B | ✓ |
Overall change | 499 B | 499 B | ✓ |
Rendered Page Sizes
vercel/next.js canary | davecaruso/next.js dev-url-special-chars | Change | |
---|---|---|---|
index.html gzip | 585 B | 585 B | ✓ |
link.html gzip | 597 B | 597 B | ✓ |
withRouter.html gzip | 578 B | 578 B | ✓ |
Overall change | 1.76 kB | 1.76 kB | ✓ |
fixes #22099
when using + in a url (filename like
/pages/hello+world.js
) in development mode, the page will refresh every few seconds as if i was changing the file, even if im not. this is because the EventSource the dev client opens does not encode the url component, causing it to fail and refresh the page after ~5 seconds. this PR is a one line change to fix that.Bug
fixes #number
contributing.md