Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI publish step to trigger after build #21661

Merged
merged 1 commit into from Jan 29, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Jan 29, 2021

This lets the publish step occur faster instead of waiting for other CI tasks to finish first

Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great to prevent botched releases as the result of a test flake. Plus, we can ship updates faster if something went awry.

@ijjk
Copy link
Member Author

ijjk commented Jan 29, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
buildDuration 9.7s 10.4s ⚠️ +676ms
nodeModulesSize 75 MB 75 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
/ failed reqs 0 0
/ total time (seconds) 1.74 1.967 ⚠️ +0.23
/ avg req/sec 1436.64 1271.01 ⚠️ -165.63
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.085 1.268 ⚠️ +0.18
/error-in-render avg req/sec 2304.62 1971.84 ⚠️ -332.78
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
buildDuration 12.2s 11.9s -341ms
nodeModulesSize 75 MB 75 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.19 MB 5.19 MB

Webpack 5 Mode (Decrease detected ✓)
General
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
buildDuration 11.6s 12.6s ⚠️ +1.1s
nodeModulesSize 75 MB 75 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
/ failed reqs 0 0
/ total time (seconds) 1.827 2.007 ⚠️ +0.18
/ avg req/sec 1368.55 1245.83 ⚠️ -122.72
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.206 1.274 ⚠️ +0.07
/error-in-render avg req/sec 2072.39 1961.9 ⚠️ -110.49
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
597-7c719119..27b6.js gzip 13 kB 13 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.58 kB 6.58 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 59.9 kB 59.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
_app-6e0a903..b885.js gzip 1.26 kB 1.26 kB
_error-7a100..a392.js gzip 3.38 kB 3.38 kB
hooks-f7e199..11b9.js gzip 904 B 904 B
index-3dc22c..ffbb.js gzip 232 B 232 B
link-c010d28..b60a.js gzip 1.63 kB 1.63 kB
routerDirect..323a.js gzip 308 B 308 B
withRouter-a..2ef8.js gzip 304 B 304 B
Overall change 8.02 kB 8.02 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
_buildManifest.js gzip 299 B 299 B
Overall change 299 B 299 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js update/ci-publish-step Change
index.html gzip 586 B 586 B
link.html gzip 592 B 592 B
withRouter.html gzip 579 B 579 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "IZ-jvnqGY1AL454bcr9oO",
+        "buildId": "bJiT-DRHLc7EKhPzsUquB",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/IZ-jvnqGY1AL454bcr9oO/_buildManifest.js"
+      src="/_next/static/bJiT-DRHLc7EKhPzsUquB/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/IZ-jvnqGY1AL454bcr9oO/_ssgManifest.js"
+      src="/_next/static/bJiT-DRHLc7EKhPzsUquB/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "IZ-jvnqGY1AL454bcr9oO",
+        "buildId": "bJiT-DRHLc7EKhPzsUquB",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/IZ-jvnqGY1AL454bcr9oO/_buildManifest.js"
+      src="/_next/static/bJiT-DRHLc7EKhPzsUquB/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/IZ-jvnqGY1AL454bcr9oO/_ssgManifest.js"
+      src="/_next/static/bJiT-DRHLc7EKhPzsUquB/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "IZ-jvnqGY1AL454bcr9oO",
+        "buildId": "bJiT-DRHLc7EKhPzsUquB",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/IZ-jvnqGY1AL454bcr9oO/_buildManifest.js"
+      src="/_next/static/bJiT-DRHLc7EKhPzsUquB/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/IZ-jvnqGY1AL454bcr9oO/_ssgManifest.js"
+      src="/_next/static/bJiT-DRHLc7EKhPzsUquB/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 8d51ce0

@Timer Timer merged commit 5be31f5 into vercel:canary Jan 29, 2021
@Timer Timer deleted the update/ci-publish-step branch January 29, 2021 17:16
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants