Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional catchall route refreshes on any query param #21538

Closed
LawJolla opened this issue Jan 26, 2021 · 2 comments
Closed

Optional catchall route refreshes on any query param #21538

LawJolla opened this issue Jan 26, 2021 · 2 comments
Labels
bug Issue was opened via the bug report template.

Comments

@LawJolla
Copy link

What version of Next.js are you using?

10.0.6-canary-8

What version of Node.js are you using?

14.4.0

What browser are you using?

Chrome 88.0.4324.96

What operating system are you using?

macOS

How are you deploying your application?

next dev

Describe the Bug

Thanks everyone for you hard and amazing work!

Trying to implement Instagram style modal routing with optional catchall. However, when the Link as uses a query param, Next Router tiggers a full page reload on the as route.

Expected Behavior

Remain on current route while changing the URL to /catchall/example?q=withQueryParam. Adding a query parameter shouldn't force a hard reload to the as route. It should have the same behavior as the route without the query param.

May be related #21410 (but this PR did not fix my issue).

To Reproduce

Please see Codesandbox reproduction.

https://codesandbox.io/s/dank-dust-fsuw4?file=/pages/index.js

If this isn't a bug and I simply don't know what I'm doing, a kind nudge in the right direction is welcomed. Thank you again!

@LawJolla LawJolla added the bug Issue was opened via the bug report template. label Jan 26, 2021
@LawJolla
Copy link
Author

After looking at this again, this WAS fixed by 10.0.6-canary.7.

Thanks!!

@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue was opened via the bug report template.
Projects
None yet
Development

No branches or pull requests

2 participants