Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade pinned deps for tests #21515

Merged
merged 7 commits into from Jan 25, 2021
Merged

fix: upgrade pinned deps for tests #21515

merged 7 commits into from Jan 25, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Jan 25, 2021

This should eliminate a warning that's causing tests to fail.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@Timer Timer marked this pull request as ready for review January 25, 2021 15:50
ijjk
ijjk previously approved these changes Jan 25, 2021
@ijjk

This comment has been minimized.

@ijjk

This comment has been minimized.

@ijjk
Copy link
Member

ijjk commented Jan 25, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/tests Change
buildDuration 11.1s 11s -105ms
nodeModulesSize 73.3 MB 74.9 MB ⚠️ +1.68 MB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/tests Change
/ failed reqs 0 0
/ total time (seconds) 2.114 2.13 ⚠️ +0.02
/ avg req/sec 1182.67 1173.73 ⚠️ -8.94
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.373 1.336 -0.04
/error-in-render avg req/sec 1820.93 1870.9 +49.97
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/tests Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/tests Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary Timer/next.js hotfix/tests Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/tests Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/tests Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/tests Change
buildDuration 12.4s 12.4s ⚠️ +9ms
nodeModulesSize 73.3 MB 74.9 MB ⚠️ +1.68 MB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/tests Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-HASH.js gzip 6.63 kB 6.63 kB
webpack-HASH.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/tests Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary Timer/next.js hotfix/tests Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/tests Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/tests Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.19 MB 5.19 MB

Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/tests Change
buildDuration 12.8s 12.7s -111ms
nodeModulesSize 73.3 MB 74.9 MB ⚠️ +1.68 MB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/tests Change
/ failed reqs 0 0
/ total time (seconds) 2.136 2.037 -0.1
/ avg req/sec 1170.62 1227.01 +56.39
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.316 1.447 ⚠️ +0.13
/error-in-render avg req/sec 1899.66 1727.53 ⚠️ -172.13
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/tests Change
597-c48889ef..1870.js gzip 13 kB 13 kB
framework.HASH.js gzip 39.3 kB 39.3 kB
main-HASH.js gzip 6.58 kB 6.58 kB
webpack-HASH.js gzip 954 B 954 B
Overall change 59.8 kB 59.8 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/tests Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB
Overall change 31.1 kB 31.1 kB
Client Pages
vercel/next.js canary Timer/next.js hotfix/tests Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB
hooks-725de8..0a15.js gzip 904 B 904 B
index-939503..6e1c.js gzip 232 B 232 B
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB
routerDirect..9360.js gzip 308 B 308 B
withRouter-6..44ec.js gzip 304 B 304 B
Overall change 8.02 kB 8.02 kB
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/tests Change
_buildManifest.js gzip 299 B 299 B
Overall change 299 B 299 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/tests Change
index.html gzip 588 B 588 B
link.html gzip 593 B 593 B
withRouter.html gzip 581 B 581 B
Overall change 1.76 kB 1.76 kB

Diffs

Diff for index.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "mPn5Hy8WqFmeOln1cxN2Q",
+        "buildId": "cpNNBXV9Ol7OT3i7vtXpI",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/mPn5Hy8WqFmeOln1cxN2Q/_buildManifest.js"
+      src="/_next/static/cpNNBXV9Ol7OT3i7vtXpI/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/mPn5Hy8WqFmeOln1cxN2Q/_ssgManifest.js"
+      src="/_next/static/cpNNBXV9Ol7OT3i7vtXpI/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "mPn5Hy8WqFmeOln1cxN2Q",
+        "buildId": "cpNNBXV9Ol7OT3i7vtXpI",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/mPn5Hy8WqFmeOln1cxN2Q/_buildManifest.js"
+      src="/_next/static/cpNNBXV9Ol7OT3i7vtXpI/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/mPn5Hy8WqFmeOln1cxN2Q/_ssgManifest.js"
+      src="/_next/static/cpNNBXV9Ol7OT3i7vtXpI/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "mPn5Hy8WqFmeOln1cxN2Q",
+        "buildId": "cpNNBXV9Ol7OT3i7vtXpI",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/mPn5Hy8WqFmeOln1cxN2Q/_buildManifest.js"
+      src="/_next/static/cpNNBXV9Ol7OT3i7vtXpI/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/mPn5Hy8WqFmeOln1cxN2Q/_ssgManifest.js"
+      src="/_next/static/cpNNBXV9Ol7OT3i7vtXpI/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 97af81f

@Timer Timer merged commit 75c5047 into vercel:canary Jan 25, 2021
@Timer Timer deleted the hotfix/tests branch January 25, 2021 17:08
@Janpot Janpot mentioned this pull request Jan 25, 2021
1 task
@kachkaev kachkaev mentioned this pull request May 1, 2021
1 task
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants