Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: compile style-loader dep #21355

Merged
merged 5 commits into from Jan 20, 2021
Merged

chore: compile style-loader dep #21355

merged 5 commits into from Jan 20, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Jan 19, 2021 •
edited

This PR compiles style-loader to resolve a peer dep warning.

Closes #21359

@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk

This comment has been minimized.

Sign in to view
@ijjk
Copy link
Member

ijjk commented Jan 20, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js ncc/style-loader Change
buildDuration 8.8s 8.6s -215ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +5.73 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js ncc/style-loader Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.743 1.77 ⚠️ +0.03
/ avg req/sec 1434.05 1412.19 ⚠️ -21.86
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.091 1.112 ⚠️ +0.02
/error-in-render avg req/sec 2291.07 2247.53 ⚠️ -43.54
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js ncc/style-loader Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js ncc/style-loader Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js ncc/style-loader Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js ncc/style-loader Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js ncc/style-loader Change
index.html gzip 616 B 616 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js ncc/style-loader Change
buildDuration 10.4s 10.4s -46ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +5.73 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js ncc/style-loader Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js ncc/style-loader Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js ncc/style-loader Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js ncc/style-loader Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js ncc/style-loader Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js ncc/style-loader Change
buildDuration 10.5s 10.6s ⚠️ +101ms
nodeModulesSize 75.3 MB 75.3 MB ⚠️ +5.73 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js ncc/style-loader Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.682 1.707 ⚠️ +0.03
/ avg req/sec 1486.05 1464.95 ⚠️ -21.1
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.051 1.093 ⚠️ +0.04
/error-in-render avg req/sec 2378.06 2287.27 ⚠️ -90.79
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js ncc/style-loader Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js ncc/style-loader Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js ncc/style-loader Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js ncc/style-loader Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js ncc/style-loader Change
index.html gzip 587 B 587 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "JrFIRnL7WHjMJWsrx40dH",
+        "buildId": "-Hnc9d92xObtYKXUYxeny",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/JrFIRnL7WHjMJWsrx40dH/_buildManifest.js"
+      src="/_next/static/-Hnc9d92xObtYKXUYxeny/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/JrFIRnL7WHjMJWsrx40dH/_ssgManifest.js"
+      src="/_next/static/-Hnc9d92xObtYKXUYxeny/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "JrFIRnL7WHjMJWsrx40dH",
+        "buildId": "-Hnc9d92xObtYKXUYxeny",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/JrFIRnL7WHjMJWsrx40dH/_buildManifest.js"
+      src="/_next/static/-Hnc9d92xObtYKXUYxeny/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/JrFIRnL7WHjMJWsrx40dH/_ssgManifest.js"
+      src="/_next/static/-Hnc9d92xObtYKXUYxeny/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "JrFIRnL7WHjMJWsrx40dH",
+        "buildId": "-Hnc9d92xObtYKXUYxeny",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/JrFIRnL7WHjMJWsrx40dH/_buildManifest.js"
+      src="/_next/static/-Hnc9d92xObtYKXUYxeny/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/JrFIRnL7WHjMJWsrx40dH/_ssgManifest.js"
+      src="/_next/static/-Hnc9d92xObtYKXUYxeny/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 654a964

@ijjk
Copy link
Member

ijjk commented Jan 20, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js ncc/style-loader Change
buildDuration 10.3s 10.7s ⚠️ +369ms
nodeModulesSize 75.3 MB 75.3 MB -3.32 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js ncc/style-loader Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.047 2.023 -0.02
/ avg req/sec 1221.07 1235.61 +14.54
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.291 1.297 ⚠️ +0.01
/error-in-render avg req/sec 1936.23 1927.33 ⚠️ -8.9
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js ncc/style-loader Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js ncc/style-loader Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js ncc/style-loader Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js ncc/style-loader Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js ncc/style-loader Change
index.html gzip 616 B 616 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js ncc/style-loader Change
buildDuration 12.5s 12.2s -267ms
nodeModulesSize 75.3 MB 75.3 MB -3.32 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js ncc/style-loader Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js ncc/style-loader Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js ncc/style-loader Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js ncc/style-loader Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js ncc/style-loader Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js ncc/style-loader Change
buildDuration 12.4s 12.3s -19ms
nodeModulesSize 75.3 MB 75.3 MB -3.32 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js ncc/style-loader Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.018 2.054 ⚠️ +0.04
/ avg req/sec 1238.57 1217.03 ⚠️ -21.54
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.253 1.256 0
/error-in-render avg req/sec 1995.27 1990.57 ⚠️ -4.7
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js ncc/style-loader Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 6.58 kB 6.58 kB ✓
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 59.8 kB 59.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js ncc/style-loader Change
polyfills-HASH.js gzip 31.1 kB 31.1 kB ✓
Overall change 31.1 kB 31.1 kB ✓
Client Pages
vercel/next.js canary Timer/next.js ncc/style-loader Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js ncc/style-loader Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js ncc/style-loader Change
index.html gzip 587 B 587 B ✓
link.html gzip 593 B 593 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "s-Z7unbt5cRiyEJTEhCW7",
+        "buildId": "vc98FnmE7xFA4kLGDueQ0",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/s-Z7unbt5cRiyEJTEhCW7/_buildManifest.js"
+      src="/_next/static/vc98FnmE7xFA4kLGDueQ0/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/s-Z7unbt5cRiyEJTEhCW7/_ssgManifest.js"
+      src="/_next/static/vc98FnmE7xFA4kLGDueQ0/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "s-Z7unbt5cRiyEJTEhCW7",
+        "buildId": "vc98FnmE7xFA4kLGDueQ0",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/s-Z7unbt5cRiyEJTEhCW7/_buildManifest.js"
+      src="/_next/static/vc98FnmE7xFA4kLGDueQ0/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/s-Z7unbt5cRiyEJTEhCW7/_ssgManifest.js"
+      src="/_next/static/vc98FnmE7xFA4kLGDueQ0/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "s-Z7unbt5cRiyEJTEhCW7",
+        "buildId": "vc98FnmE7xFA4kLGDueQ0",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/s-Z7unbt5cRiyEJTEhCW7/_buildManifest.js"
+      src="/_next/static/vc98FnmE7xFA4kLGDueQ0/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/s-Z7unbt5cRiyEJTEhCW7/_ssgManifest.js"
+      src="/_next/static/vc98FnmE7xFA4kLGDueQ0/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 08f684f

@Timer Timer marked this pull request as ready for review January 20, 2021 05:24
@kodiakhq kodiakhq bot merged commit 55b8502 into vercel:canary Jan 20, 2021
@ijjk ijjk deleted the ncc/style-loader branch January 20, 2021 05:25
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Timer @ijjk