Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade webpack 5 for empty entrypoint fix #21353

Merged
merged 2 commits into from Jan 19, 2021
Merged

upgrade webpack 5 for empty entrypoint fix #21353

merged 2 commits into from Jan 19, 2021

Conversation

sokra
Copy link
Member

@sokra sokra commented Jan 19, 2021 •
edited

fixes a problem where entrypoints are nearly empty.

@ijjk
Copy link
Member

ijjk commented Jan 19, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
buildDuration 11.3s 11s -255ms
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +10.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.201 2.174 -0.03
/ avg req/sec 1136.04 1150 +13.96
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.424 1.378 -0.05
/error-in-render avg req/sec 1755.31 1813.94 +58.63
Client Bundles (main, webpack, commons)
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
buildDuration 13.2s 13.1s -112ms
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +10.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-HASH.js gzip 6.63 kB 6.63 kB ✓
webpack-HASH.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
polyfills-HASH.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
buildDuration 13.7s 13.6s -73ms
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +10.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.141 2.175 ⚠️ +0.03
/ avg req/sec 1167.67 1149.68 ⚠️ -17.99
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.418 1.413 0
/error-in-render avg req/sec 1763.62 1769.25 +5.63
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
778-d412f8e7..3ee1.js gzip 6.56 kB N/A N/A
838-adcbad39..6e83.js gzip 31.1 kB N/A N/A
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-HASH.js gzip 96 B 6.58 kB ⚠️ +6.49 kB
webpack-HASH.js gzip 954 B 954 B ✓
Overall change 91 kB 59.8 kB -31.2 kB
Legacy Client Bundles (polyfills) Overall increase ⚠️
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
polyfills-HASH.js gzip 88 B 31.1 kB ⚠️ +31 kB
Overall change 88 B 31.1 kB ⚠️ +31 kB
Client Pages
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary sokra/next.js bugfix/webpack5 Change
index.html gzip 585 B 587 B ⚠️ +2 B
link.html gzip 592 B 592 B ✓
withRouter.html gzip 581 B 580 B -1 B
Overall change 1.76 kB 1.76 kB ⚠️ +1 B

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "0vUuoC7ysamM7GY7GEVJa",
+        "buildId": "m2GGqPt0cnpfy-x0arSmN",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0vUuoC7ysamM7GY7GEVJa/_buildManifest.js"
+      src="/_next/static/m2GGqPt0cnpfy-x0arSmN/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0vUuoC7ysamM7GY7GEVJa/_ssgManifest.js"
+      src="/_next/static/m2GGqPt0cnpfy-x0arSmN/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "0vUuoC7ysamM7GY7GEVJa",
+        "buildId": "m2GGqPt0cnpfy-x0arSmN",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0vUuoC7ysamM7GY7GEVJa/_buildManifest.js"
+      src="/_next/static/m2GGqPt0cnpfy-x0arSmN/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0vUuoC7ysamM7GY7GEVJa/_ssgManifest.js"
+      src="/_next/static/m2GGqPt0cnpfy-x0arSmN/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "0vUuoC7ysamM7GY7GEVJa",
+        "buildId": "m2GGqPt0cnpfy-x0arSmN",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/0vUuoC7ysamM7GY7GEVJa/_buildManifest.js"
+      src="/_next/static/m2GGqPt0cnpfy-x0arSmN/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/0vUuoC7ysamM7GY7GEVJa/_ssgManifest.js"
+      src="/_next/static/m2GGqPt0cnpfy-x0arSmN/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 6c57a9d

@kodiakhq kodiakhq bot merged commit 1190043 into vercel:canary Jan 19, 2021
@sokra sokra deleted the bugfix/webpack5 branch January 19, 2021 19:18
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sokra @ijjk @timneutkens