Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade chokidar to fix install warning #21343

Merged
merged 3 commits into from Jan 19, 2021
Merged

chore: upgrade chokidar to fix install warning #21343

merged 3 commits into from Jan 19, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Jan 19, 2021

To resolve:

warning next > chokidar > fsevents@2.1.3: "Please update to latest v2.3 or v2.2"

@ijjk
Copy link
Member

ijjk commented Jan 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js upgrade/chokidar Change
buildDuration 11.8s 11.2s -656ms
nodeModulesSize 77.6 MB 77.6 MB -333 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js upgrade/chokidar Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.273 2.339 ⚠️ +0.07
/ avg req/sec 1099.65 1068.89 ⚠️ -30.76
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.657 1.622 -0.03
/error-in-render avg req/sec 1508.83 1541.74 +32.91
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js upgrade/chokidar Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js upgrade/chokidar Change
buildDuration 13.5s 13.8s ⚠️ +246ms
nodeModulesSize 77.6 MB 77.6 MB -333 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js upgrade/chokidar Change
buildDuration 14.6s 14.7s ⚠️ +149ms
nodeModulesSize 77.6 MB 77.6 MB -333 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js upgrade/chokidar Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.344 2.318 -0.03
/ avg req/sec 1066.51 1078.46 +11.95
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.612 1.692 ⚠️ +0.08
/error-in-render avg req/sec 1550.48 1477.71 ⚠️ -72.77
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
778-d412f8e7..3ee1.js gzip 6.56 kB 6.56 kB ✓
838-adcbad39..6e83.js gzip 31.1 kB 31.1 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-6a6a792..6877.js gzip 96 B 96 B ✓
webpack-e302..54e9.js gzip 954 B 954 B ✓
Overall change 91 kB 91 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
polyfills-a0..538c.js gzip 88 B 88 B ✓
Overall change 88 B 88 B ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js upgrade/chokidar Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "UgVaLbZ-8lGBu7yXT2GwF",
+        "buildId": "dUTc-b2Rc_ZmHqR5tZVD3",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/UgVaLbZ-8lGBu7yXT2GwF/_buildManifest.js"
+      src="/_next/static/dUTc-b2Rc_ZmHqR5tZVD3/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/UgVaLbZ-8lGBu7yXT2GwF/_ssgManifest.js"
+      src="/_next/static/dUTc-b2Rc_ZmHqR5tZVD3/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "UgVaLbZ-8lGBu7yXT2GwF",
+        "buildId": "dUTc-b2Rc_ZmHqR5tZVD3",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/UgVaLbZ-8lGBu7yXT2GwF/_buildManifest.js"
+      src="/_next/static/dUTc-b2Rc_ZmHqR5tZVD3/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/UgVaLbZ-8lGBu7yXT2GwF/_ssgManifest.js"
+      src="/_next/static/dUTc-b2Rc_ZmHqR5tZVD3/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "UgVaLbZ-8lGBu7yXT2GwF",
+        "buildId": "dUTc-b2Rc_ZmHqR5tZVD3",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/UgVaLbZ-8lGBu7yXT2GwF/_buildManifest.js"
+      src="/_next/static/dUTc-b2Rc_ZmHqR5tZVD3/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/UgVaLbZ-8lGBu7yXT2GwF/_ssgManifest.js"
+      src="/_next/static/dUTc-b2Rc_ZmHqR5tZVD3/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 2fae642

@ijjk
Copy link
Member

ijjk commented Jan 19, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js upgrade/chokidar Change
buildDuration 8.7s 8.9s ⚠️ +131ms
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +1.79 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js upgrade/chokidar Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.759 1.804 ⚠️ +0.05
/ avg req/sec 1420.97 1385.89 ⚠️ -35.08
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.12 1.173 ⚠️ +0.05
/error-in-render avg req/sec 2231.51 2131.19 ⚠️ -100.32
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js upgrade/chokidar Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js upgrade/chokidar Change
buildDuration 10.4s 10.5s ⚠️ +11ms
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +1.79 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js upgrade/chokidar Change
buildDuration 11s 11.1s ⚠️ +55ms
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +1.79 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js upgrade/chokidar Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.735 1.715 -0.02
/ avg req/sec 1441.23 1458.13 +16.9
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.13 1.121 -0.01
/error-in-render avg req/sec 2211.55 2230.5 +18.95
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
778-d412f8e7..3ee1.js gzip 6.56 kB 6.56 kB ✓
838-adcbad39..6e83.js gzip 31.1 kB 31.1 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-6a6a792..6877.js gzip 96 B 96 B ✓
webpack-e302..54e9.js gzip 954 B 954 B ✓
Overall change 91 kB 91 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
polyfills-a0..538c.js gzip 88 B 88 B ✓
Overall change 88 B 88 B ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js upgrade/chokidar Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "l3GdsNghPEro68fCdTgeT",
+        "buildId": "xkhvTb3xKddVjkI-HJQaB",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/l3GdsNghPEro68fCdTgeT/_buildManifest.js"
+      src="/_next/static/xkhvTb3xKddVjkI-HJQaB/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/l3GdsNghPEro68fCdTgeT/_ssgManifest.js"
+      src="/_next/static/xkhvTb3xKddVjkI-HJQaB/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "l3GdsNghPEro68fCdTgeT",
+        "buildId": "xkhvTb3xKddVjkI-HJQaB",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/l3GdsNghPEro68fCdTgeT/_buildManifest.js"
+      src="/_next/static/xkhvTb3xKddVjkI-HJQaB/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/l3GdsNghPEro68fCdTgeT/_ssgManifest.js"
+      src="/_next/static/xkhvTb3xKddVjkI-HJQaB/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "l3GdsNghPEro68fCdTgeT",
+        "buildId": "xkhvTb3xKddVjkI-HJQaB",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/l3GdsNghPEro68fCdTgeT/_buildManifest.js"
+      src="/_next/static/xkhvTb3xKddVjkI-HJQaB/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/l3GdsNghPEro68fCdTgeT/_ssgManifest.js"
+      src="/_next/static/xkhvTb3xKddVjkI-HJQaB/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: cc5cd33

@ijjk
Copy link
Member

ijjk commented Jan 19, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js upgrade/chokidar Change
buildDuration 10.3s 10.6s ⚠️ +295ms
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +1.79 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js upgrade/chokidar Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.297 2.267 -0.03
/ avg req/sec 1088.15 1102.67 +14.52
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.553 1.512 -0.04
/error-in-render avg req/sec 1609.39 1653.96 +44.57
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js upgrade/chokidar Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js upgrade/chokidar Change
buildDuration 13.4s 11.9s -1.5s
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +1.79 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Webpack 5 Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js upgrade/chokidar Change
buildDuration 13.4s 13.5s ⚠️ +97ms
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +1.79 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js upgrade/chokidar Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.178 2.194 ⚠️ +0.02
/ avg req/sec 1147.6 1139.45 ⚠️ -8.15
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.482 1.534 ⚠️ +0.05
/error-in-render avg req/sec 1686.98 1630.21 ⚠️ -56.77
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
778-d412f8e7..3ee1.js gzip 6.56 kB 6.56 kB ✓
838-adcbad39..6e83.js gzip 31.1 kB 31.1 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-6a6a792..6877.js gzip 96 B 96 B ✓
webpack-e302..54e9.js gzip 954 B 954 B ✓
Overall change 91 kB 91 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js upgrade/chokidar Change
polyfills-a0..538c.js gzip 88 B 88 B ✓
Overall change 88 B 88 B ✓
Client Pages
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js upgrade/chokidar Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js upgrade/chokidar Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "G4_70d3h9TI0tYRXfnHlQ",
+        "buildId": "lZeAZ8KBb9xEfXJztDKvJ",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/G4_70d3h9TI0tYRXfnHlQ/_buildManifest.js"
+      src="/_next/static/lZeAZ8KBb9xEfXJztDKvJ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/G4_70d3h9TI0tYRXfnHlQ/_ssgManifest.js"
+      src="/_next/static/lZeAZ8KBb9xEfXJztDKvJ/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "G4_70d3h9TI0tYRXfnHlQ",
+        "buildId": "lZeAZ8KBb9xEfXJztDKvJ",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/G4_70d3h9TI0tYRXfnHlQ/_buildManifest.js"
+      src="/_next/static/lZeAZ8KBb9xEfXJztDKvJ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/G4_70d3h9TI0tYRXfnHlQ/_ssgManifest.js"
+      src="/_next/static/lZeAZ8KBb9xEfXJztDKvJ/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "G4_70d3h9TI0tYRXfnHlQ",
+        "buildId": "lZeAZ8KBb9xEfXJztDKvJ",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/G4_70d3h9TI0tYRXfnHlQ/_buildManifest.js"
+      src="/_next/static/lZeAZ8KBb9xEfXJztDKvJ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/G4_70d3h9TI0tYRXfnHlQ/_ssgManifest.js"
+      src="/_next/static/lZeAZ8KBb9xEfXJztDKvJ/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: e1225fe

@kodiakhq kodiakhq bot merged commit d33aad7 into vercel:canary Jan 19, 2021
@Timer Timer deleted the upgrade/chokidar branch January 19, 2021 18:16
@PepijnSenders
Copy link
Contributor

PepijnSenders commented Feb 11, 2021 •
edited

Hey! This upgrade causes yarn@berry to fail since there are multiple different patches on a shared dependency called fsevents.

➤ YN0066: │ fsevents@patch:fsevents@npm%3A2.3.2#builtin<compat/fsevents>::version=2.3.2&hash=127e8e: Cannot apply hunk #1
➤ YN0000: │     }
➤ YN0000: │   
➤ YN0028: │ -   let instance = Native.start(path, handler);
➤ YN0028: │ +   let VFS = require('./vfs');
➤ YN0028: │ +   let vfs = new VFS(path);
➤ YN0028: │ +   let instance = Native.start(vfs.resolvedPath, vfs.wrap(handler));
➤ YN0000: │     if (!instance) throw new Error(`could not watch: ${path}`);
➤ YN0000: │     return () => {

This fsevents package is included by several different libraries and for us it's an older version of jest-haste-map (24.9.0) and chokidar (included by babel-cli@6.26.0) that breaks it. Pretty sure that this could break on other systems as well. Will also report this on the yarn berry repo.

Resoluting jest-haste-map to ^26 fixes the issue for us and chokidar to 3.5.1 fixes it.

@PepijnSenders
Copy link
Contributor

It was apparently fixed in the latest yarn version (2.4.0), so no worries! yarnpkg/berry#2469 (comment)

@benoitgrelard benoitgrelard mentioned this pull request Feb 17, 2021
Merged
@cfbender cfbender mentioned this pull request Mar 17, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Timer @ijjk @PepijnSenders