Change type of GetServerSidePropsContext.req.cookies the be the same as NextApiRequest.cookies #21336

andrehsu · 2021-01-19T14:39:26Z

The original type for GetServerSidePropsContext.req.cookies was introduced in #19724. In the PR, the test at test/integration/typescript/test/index.test.js expects req.cookies to always exist, so req.cookies will never be undefined.

I'm guessing that req.cookies is parsed using the same cookie middleware as NextApiRequest, in which case req.cookies should be { [key: string]: string }, not { [key: string]: any }.

…as NextApiRequest.cookies

andrehsu · 2021-01-23T15:29:02Z

@Timer can I please get a review on this PR? It is a one-line PR, and the integration tests introduced here shows that req.cookies is always supposed to be defined. (And cookies can only be strings.)

ijjk · 2021-01-25T15:54:46Z

Failing test suites

Commit: 0df9a0a

test/integration/dist-dir/test/index.test.js

distDir > should handle null/undefined distDir

Expand output

● distDir › should handle null/undefined distDir

expect(received).toBe(expected) // Object.is equality

Expected: 0
Received: 88

  63 |     await fs.writeFile(nextConfig, origNextConfig)
  64 | 
> 65 |     expect(stderr.length).toBe(0)
     |                           ^
  66 |   })
  67 | })
  68 | 

  at Object.<anonymous> (integration/dist-dir/test/index.test.js:65:27)

test/integration/production-build-dir/test/index.test.js

Production Custom Build Directory > With basic usage > should render the page

Expand output

● Production Custom Build Directory › With basic usage › should render the page

expect(received).toBe(expected) // Object.is equality

Expected: ""
Received: "Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
"

  20 |         stderr: true,
  21 |       })
> 22 |       expect(result.stderr).toBe('')
     |                             ^
  23 | 
  24 |       const app = nextServer({
  25 |         dir: join(__dirname, '../build'),

  at Object.<anonymous> (integration/production-build-dir/test/index.test.js:22:29)

test/integration/cli/test/index.test.js

CLI Usage > build > should warn when unknown argument provided

Expand output

● CLI Usage › build › should warn when unknown argument provided

expect(received).toEqual(expected) // deep equality

- Expected  - 0
+ Received  + 2

+ Browserslist: caniuse-lite is outdated. Please run:
+ npx browserslist@latest --update-db
  Unknown or unexpected option: --random
  ↵

  79 |         stderr: true,
  80 |       })
> 81 |       expect(stderr).toEqual('Unknown or unexpected option: --random\n')
     |                      ^
  82 |     })
  83 |     test('should not throw UnhandledPromiseRejectionWarning', async () => {
  84 |       const { stderr } = await runNextCommand(['build', '--random'], {

  at Object.<anonymous> (integration/cli/test/index.test.js:81:22)

ijjk · 2021-01-25T15:56:17Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	10.2s	10.3s	⚠️ +103ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +106 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.06	2.002	-0.06
/ avg req/sec	1213.67	1249.01	+35.34
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.291	1.261	-0.03
/error-in-render avg req/sec	1935.91	1982.92	+47.01

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	12.2s	12.1s	-92ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +106 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_error.js	1 MB	1 MB	⚠️ +4 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	⚠️ +4 B
link.js	1.06 MB	1.06 MB	⚠️ +4 B
routerDirect.js	1.05 MB	1.05 MB	⚠️ +4 B
withRouter.js	1.05 MB	1.05 MB	⚠️ +4 B
Overall change	5.19 MB	5.19 MB	⚠️ +20 B

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	12.5s	12.5s	⚠️ +76ms
nodeModulesSize	73.3 MB	73.3 MB	⚠️ +106 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.053	2.024	-0.03
/ avg req/sec	1217.67	1235.19	+17.52
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.242	1.243	0
/error-in-render avg req/sec	2012.48	2011.36	⚠️ -1.12

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
index.html gzip	588 B	588 B	✓
link.html gzip	593 B	593 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "njMQ5RYx1bOVpm1jqDQxv",
+        "buildId": "2MmGRN5w676aakBTkgklm",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/njMQ5RYx1bOVpm1jqDQxv/_buildManifest.js"
+      src="/_next/static/2MmGRN5w676aakBTkgklm/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/njMQ5RYx1bOVpm1jqDQxv/_ssgManifest.js"
+      src="/_next/static/2MmGRN5w676aakBTkgklm/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "njMQ5RYx1bOVpm1jqDQxv",
+        "buildId": "2MmGRN5w676aakBTkgklm",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/njMQ5RYx1bOVpm1jqDQxv/_buildManifest.js"
+      src="/_next/static/2MmGRN5w676aakBTkgklm/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/njMQ5RYx1bOVpm1jqDQxv/_ssgManifest.js"
+      src="/_next/static/2MmGRN5w676aakBTkgklm/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "njMQ5RYx1bOVpm1jqDQxv",
+        "buildId": "2MmGRN5w676aakBTkgklm",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/njMQ5RYx1bOVpm1jqDQxv/_buildManifest.js"
+      src="/_next/static/2MmGRN5w676aakBTkgklm/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/njMQ5RYx1bOVpm1jqDQxv/_ssgManifest.js"
+      src="/_next/static/2MmGRN5w676aakBTkgklm/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 0df9a0a

ijjk · 2021-01-26T06:30:52Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	10.6s	10.7s	⚠️ +132ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +106 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.084	2.058	-0.03
/ avg req/sec	1199.4	1214.99	+15.59
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.273	1.258	-0.01
/error-in-render avg req/sec	1964.63	1987.03	+22.4

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	12.8s	12.6s	-181ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +106 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_error.js	1 MB	1 MB	⚠️ +4 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	⚠️ +4 B
link.js	1.06 MB	1.06 MB	⚠️ +4 B
routerDirect.js	1.05 MB	1.05 MB	⚠️ +4 B
withRouter.js	1.05 MB	1.05 MB	⚠️ +4 B
Overall change	5.19 MB	5.19 MB	⚠️ +20 B

Webpack 5 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	13.1s	13.1s	-55ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +106 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.06	2.042	-0.02
/ avg req/sec	1213.34	1224.53	+11.19
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.265	1.318	⚠️ +0.05
/error-in-render avg req/sec	1976.1	1896.1	⚠️ -80

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
index.html gzip	587 B	587 B	✓
link.html gzip	591 B	591 B	✓
withRouter.html gzip	580 B	580 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "PiGn0x6gDEVHKIJ--4SPF",
+        "buildId": "pcZ_nidqkbYy83RG4IpLk",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/PiGn0x6gDEVHKIJ--4SPF/_buildManifest.js"
+      src="/_next/static/pcZ_nidqkbYy83RG4IpLk/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/PiGn0x6gDEVHKIJ--4SPF/_ssgManifest.js"
+      src="/_next/static/pcZ_nidqkbYy83RG4IpLk/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "PiGn0x6gDEVHKIJ--4SPF",
+        "buildId": "pcZ_nidqkbYy83RG4IpLk",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/PiGn0x6gDEVHKIJ--4SPF/_buildManifest.js"
+      src="/_next/static/pcZ_nidqkbYy83RG4IpLk/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/PiGn0x6gDEVHKIJ--4SPF/_ssgManifest.js"
+      src="/_next/static/pcZ_nidqkbYy83RG4IpLk/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "PiGn0x6gDEVHKIJ--4SPF",
+        "buildId": "pcZ_nidqkbYy83RG4IpLk",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/PiGn0x6gDEVHKIJ--4SPF/_buildManifest.js"
+      src="/_next/static/pcZ_nidqkbYy83RG4IpLk/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/PiGn0x6gDEVHKIJ--4SPF/_ssgManifest.js"
+      src="/_next/static/pcZ_nidqkbYy83RG4IpLk/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 4cf9784

…cookies-type

This reverts commit 97d9288.

ijjk · 2021-01-26T13:33:56Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	10.4s	10.1s	-244ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +260 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.019	2.031	⚠️ +0.01
/ avg req/sec	1238.11	1230.9	⚠️ -7.21
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.325	1.277	-0.05
/error-in-render avg req/sec	1887.32	1957.75	+70.43

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	12.2s	11.6s	-641ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +260 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_error.js	1 MB	1 MB	⚠️ +4 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	⚠️ +4 B
link.js	1.06 MB	1.06 MB	⚠️ +4 B
routerDirect.js	1.05 MB	1.05 MB	⚠️ +4 B
withRouter.js	1.05 MB	1.05 MB	⚠️ +4 B
Overall change	5.19 MB	5.19 MB	⚠️ +20 B

Webpack 5 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	11.9s	12.2s	⚠️ +205ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +260 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.995	2.024	⚠️ +0.03
/ avg req/sec	1253.3	1234.96	⚠️ -18.34
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.24	1.284	⚠️ +0.04
/error-in-render avg req/sec	2016.9	1947.16	⚠️ -69.74

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
index.html gzip	587 B	587 B	✓
link.html gzip	591 B	591 B	✓
withRouter.html gzip	580 B	580 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "cU-Rj7uoVAItvfN-R2gqr",
+        "buildId": "p_iQFXaw-tO-eMdkob2yw",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/cU-Rj7uoVAItvfN-R2gqr/_buildManifest.js"
+      src="/_next/static/p_iQFXaw-tO-eMdkob2yw/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/cU-Rj7uoVAItvfN-R2gqr/_ssgManifest.js"
+      src="/_next/static/p_iQFXaw-tO-eMdkob2yw/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "cU-Rj7uoVAItvfN-R2gqr",
+        "buildId": "p_iQFXaw-tO-eMdkob2yw",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/cU-Rj7uoVAItvfN-R2gqr/_buildManifest.js"
+      src="/_next/static/p_iQFXaw-tO-eMdkob2yw/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/cU-Rj7uoVAItvfN-R2gqr/_ssgManifest.js"
+      src="/_next/static/p_iQFXaw-tO-eMdkob2yw/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "cU-Rj7uoVAItvfN-R2gqr",
+        "buildId": "p_iQFXaw-tO-eMdkob2yw",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/cU-Rj7uoVAItvfN-R2gqr/_buildManifest.js"
+      src="/_next/static/p_iQFXaw-tO-eMdkob2yw/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/cU-Rj7uoVAItvfN-R2gqr/_ssgManifest.js"
+      src="/_next/static/p_iQFXaw-tO-eMdkob2yw/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: d13ca03

ijjk · 2021-01-26T13:57:45Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	8.3s	8.8s	⚠️ +472ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +290 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.736	1.791	⚠️ +0.05
/ avg req/sec	1440.13	1395.64	⚠️ -44.49
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.065	1.079	⚠️ +0.01
/error-in-render avg req/sec	2347.14	2317.59	⚠️ -29.55

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	10.1s	10.4s	⚠️ +266ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +290 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_error.js	1 MB	1 MB	⚠️ +4 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	⚠️ +4 B
link.js	1.06 MB	1.06 MB	⚠️ +4 B
routerDirect.js	1.05 MB	1.05 MB	⚠️ +4 B
withRouter.js	1.05 MB	1.05 MB	⚠️ +4 B
Overall change	5.19 MB	5.19 MB	⚠️ +20 B

Webpack 5 Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	10.4s	10.3s	-65ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +290 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.613	1.665	⚠️ +0.05
/ avg req/sec	1549.53	1501.62	⚠️ -47.91
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.068	1.072	0
/error-in-render avg req/sec	2340.24	2332.55	⚠️ -7.69

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
index.html gzip	587 B	587 B	✓
link.html gzip	591 B	591 B	✓
withRouter.html gzip	580 B	580 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "FXeqwscjL8JZvUjw1a_Q6",
+        "buildId": "7xeJl3OiF3xc9B0d69O-n",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/FXeqwscjL8JZvUjw1a_Q6/_buildManifest.js"
+      src="/_next/static/7xeJl3OiF3xc9B0d69O-n/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/FXeqwscjL8JZvUjw1a_Q6/_ssgManifest.js"
+      src="/_next/static/7xeJl3OiF3xc9B0d69O-n/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "FXeqwscjL8JZvUjw1a_Q6",
+        "buildId": "7xeJl3OiF3xc9B0d69O-n",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/FXeqwscjL8JZvUjw1a_Q6/_buildManifest.js"
+      src="/_next/static/7xeJl3OiF3xc9B0d69O-n/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/FXeqwscjL8JZvUjw1a_Q6/_ssgManifest.js"
+      src="/_next/static/7xeJl3OiF3xc9B0d69O-n/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "FXeqwscjL8JZvUjw1a_Q6",
+        "buildId": "7xeJl3OiF3xc9B0d69O-n",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/FXeqwscjL8JZvUjw1a_Q6/_buildManifest.js"
+      src="/_next/static/7xeJl3OiF3xc9B0d69O-n/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/FXeqwscjL8JZvUjw1a_Q6/_ssgManifest.js"
+      src="/_next/static/7xeJl3OiF3xc9B0d69O-n/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 60f2e1b

timneutkens

Looks good to land now 👍

ijjk · 2021-01-26T14:17:06Z

Stats from current PR

Default Server Mode

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	9.2s	9.1s	-114ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +290 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.756	1.789	⚠️ +0.03
/ avg req/sec	1423.66	1397.12	⚠️ -26.54
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.165	1.149	-0.02
/error-in-render avg req/sec	2146.07	2176.19	+30.12

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
index.html gzip	614 B	614 B	✓
link.html gzip	620 B	620 B	✓
withRouter.html gzip	607 B	607 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	11.1s	10.9s	-194ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +290 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
677f882d2ed8..38ed.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-HASH.js gzip	6.63 kB	6.63 kB	✓
webpack-HASH.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_error.js	1 MB	1 MB	⚠️ +4 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	⚠️ +4 B
link.js	1.06 MB	1.06 MB	⚠️ +4 B
routerDirect.js	1.05 MB	1.05 MB	⚠️ +4 B
withRouter.js	1.05 MB	1.05 MB	⚠️ +4 B
Overall change	5.19 MB	5.19 MB	⚠️ +20 B

Webpack 5 Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
buildDuration	11s	11s	⚠️ +12ms
nodeModulesSize	74.9 MB	74.9 MB	⚠️ +290 B

Page Load Tests Overall increase ✓

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.815	1.779	-0.04
/ avg req/sec	1377.14	1404.92	+27.78
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.162	1.109	-0.05
/error-in-render avg req/sec	2150.89	2253.97	+103.08

Client Bundles (main, webpack, commons)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
597-c48889ef..1870.js gzip	13 kB	13 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-HASH.js gzip	6.58 kB	6.58 kB	✓
webpack-HASH.js gzip	954 B	954 B	✓
Overall change	59.8 kB	59.8 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
polyfills-HASH.js gzip	31.1 kB	31.1 kB	✓
Overall change	31.1 kB	31.1 kB	✓

Client Pages

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	andrehsu/next.js fix/cookies-type	Change
index.html gzip	587 B	587 B	✓
link.html gzip	591 B	591 B	✓
withRouter.html gzip	580 B	580 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "H-cbSyvyBm-IlyTnmIO-J",
+        "buildId": "xFD6ydzHE1eW4-vwIV0OE",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/H-cbSyvyBm-IlyTnmIO-J/_buildManifest.js"
+      src="/_next/static/xFD6ydzHE1eW4-vwIV0OE/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/H-cbSyvyBm-IlyTnmIO-J/_ssgManifest.js"
+      src="/_next/static/xFD6ydzHE1eW4-vwIV0OE/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "H-cbSyvyBm-IlyTnmIO-J",
+        "buildId": "xFD6ydzHE1eW4-vwIV0OE",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/H-cbSyvyBm-IlyTnmIO-J/_buildManifest.js"
+      src="/_next/static/xFD6ydzHE1eW4-vwIV0OE/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/H-cbSyvyBm-IlyTnmIO-J/_ssgManifest.js"
+      src="/_next/static/xFD6ydzHE1eW4-vwIV0OE/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "H-cbSyvyBm-IlyTnmIO-J",
+        "buildId": "xFD6ydzHE1eW4-vwIV0OE",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/H-cbSyvyBm-IlyTnmIO-J/_buildManifest.js"
+      src="/_next/static/xFD6ydzHE1eW4-vwIV0OE/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/H-cbSyvyBm-IlyTnmIO-J/_ssgManifest.js"
+      src="/_next/static/xFD6ydzHE1eW4-vwIV0OE/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 8201ca1

Change type of GetServerSidePropsContext.req.cookies the be the same …

4be78ec

…as NextApiRequest.cookies

andrehsu requested review from ijjk, lfades, Timer and timneutkens as code owners January 19, 2021 14:39

ijjk added the type: next label Jan 19, 2021

andrehsu added 2 commits January 25, 2021 23:44

Add type casting

fdd9b46

Merge branch 'canary' into fix/cookies-type

0df9a0a

Merge branch 'canary' into fix/cookies-type

4cf9784

timneutkens added 4 commits January 26, 2021 14:08

Merge branch 'canary' of github.com:vercel/next.js into andrehsu-fix/…

013d61e

…cookies-type

Use existing return type from cookie parser

bc7a110

Remove change that does not affect typing

97d9288

Revert "Remove change that does not affect typing"

d13ca03

This reverts commit 97d9288.

Use correct type in the same place

60f2e1b

timneutkens approved these changes Jan 26, 2021

View reviewed changes

Merge branch 'canary' into fix/cookies-type

8201ca1

andrehsu closed this Jan 26, 2021

andrehsu reopened this Jan 26, 2021

kodiakhq bot merged commit a47d47e into vercel:canary Jan 26, 2021

andrehsu deleted the fix/cookies-type branch January 26, 2021 14:34

This was referenced Jan 29, 2021

[Snyk] Security upgrade next from 6.0.0-canary.6 to 10.0.6 ajesse11x/next.js#600

Open

[Snyk] Security upgrade next from 5.0.0-universal-alpha.15 to 10.0.6 ajesse11x/next.js#601

Open

[Snyk] Security upgrade next from 6.1.2 to 10.0.6 ajesse11x/next.js#602

Open

This was referenced Aug 4, 2021

[Snyk] Security upgrade next from 9.5.5 to 10.0.6 elad165/next.js#402

Open

[Snyk] Security upgrade next from 9.5.5 to 10.0.6 baby636/next.js#133

Open

snyk-bot mentioned this pull request Dec 16, 2021

[Snyk] Fix for 3 vulnerabilities lethu96/next.js#28

Open

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change type of GetServerSidePropsContext.req.cookies the be the same as NextApiRequest.cookies #21336

Change type of GetServerSidePropsContext.req.cookies the be the same as NextApiRequest.cookies #21336

andrehsu commented Jan 19, 2021 •

edited

andrehsu commented Jan 23, 2021

ijjk commented Jan 25, 2021 •

edited

ijjk commented Jan 25, 2021

Diffs

ijjk commented Jan 26, 2021

Diffs

ijjk commented Jan 26, 2021

Diffs

ijjk commented Jan 26, 2021

Diffs

timneutkens left a comment

ijjk commented Jan 26, 2021

Diffs

Change type of GetServerSidePropsContext.req.cookies the be the same as NextApiRequest.cookies #21336

Change type of GetServerSidePropsContext.req.cookies the be the same as NextApiRequest.cookies #21336

Conversation

andrehsu commented Jan 19, 2021 • edited

andrehsu commented Jan 23, 2021

ijjk commented Jan 25, 2021 • edited

Failing test suites

ijjk commented Jan 25, 2021

Stats from current PR

Diffs

ijjk commented Jan 26, 2021

Stats from current PR

Diffs

ijjk commented Jan 26, 2021

Stats from current PR

Diffs

ijjk commented Jan 26, 2021

Stats from current PR

Diffs

timneutkens left a comment

Choose a reason for hiding this comment

ijjk commented Jan 26, 2021

Stats from current PR

Diffs

andrehsu commented Jan 19, 2021 •

edited

ijjk commented Jan 25, 2021 •

edited