Add codemod for files that do not support the new React JSX transform #21281

timneutkens · 2021-01-18T13:19:04Z

Previously our automatic React injection approach injected import React from 'react' automatically whenever JSX was detected. The new official JSX transform solves this by enforcing importing React when it is used.

This codemod automatically converted files that are using a "global React variable" to use import React from 'react'

Previously our automatic React injection approach injected `import React from 'react'` automatically whenever JSX was detected. The new official JSX transform solves this by enforcing importing `React` when it is used. This codemod automatically converted files that are using a "global React variable" to use `import React from 'react'`

ijjk · 2021-01-18T13:35:38Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
buildDuration	9.1s	8.9s	-158ms
nodeModulesSize	77.6 MB	77.6 MB	⚠️ +10.1 kB

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.745	1.782	⚠️ +0.04
/ avg req/sec	1432.35	1402.96	⚠️ -29.39
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.097	1.099	0
/error-in-render avg req/sec	2277.99	2274.75	⚠️ -3.24

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-9e3e4e6..2023.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
buildDuration	10.4s	10.6s	⚠️ +164ms
nodeModulesSize	77.6 MB	77.6 MB	-10 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-9e3e4e6..2023.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Webpack 5 Mode (Decrease detected ✓)

General

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
buildDuration	11.2s	11s	-143ms
nodeModulesSize	77.6 MB	77.6 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.722	1.753	⚠️ +0.03
/ avg req/sec	1451.97	1425.75	⚠️ -26.22
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.1	1.116	⚠️ +0.02
/error-in-render avg req/sec	2272	2240.19	⚠️ -31.81

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
597-3bd7d6bd..868b.js gzip	13 kB	13 kB	✓
778-d412f8e7..3ee1.js gzip	6.56 kB	6.56 kB	✓
838-adcbad39..6e83.js gzip	31.1 kB	31.1 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-6a6a792..6877.js gzip	96 B	96 B	✓
webpack-e302..54e9.js gzip	954 B	954 B	✓
Overall change	91 kB	91 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
polyfills-a0..538c.js gzip	88 B	88 B	✓
Overall change	88 B	88 B	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
index.html gzip	585 B	585 B	✓
link.html gzip	592 B	592 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "DwUMqCT9e1yS3Bno1JNGy",
+        "buildId": "nzSUuIAzGcZOC3kCeVZiD",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/DwUMqCT9e1yS3Bno1JNGy/_buildManifest.js"
+      src="/_next/static/nzSUuIAzGcZOC3kCeVZiD/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/DwUMqCT9e1yS3Bno1JNGy/_ssgManifest.js"
+      src="/_next/static/nzSUuIAzGcZOC3kCeVZiD/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "DwUMqCT9e1yS3Bno1JNGy",
+        "buildId": "nzSUuIAzGcZOC3kCeVZiD",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/DwUMqCT9e1yS3Bno1JNGy/_buildManifest.js"
+      src="/_next/static/nzSUuIAzGcZOC3kCeVZiD/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/DwUMqCT9e1yS3Bno1JNGy/_ssgManifest.js"
+      src="/_next/static/nzSUuIAzGcZOC3kCeVZiD/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "DwUMqCT9e1yS3Bno1JNGy",
+        "buildId": "nzSUuIAzGcZOC3kCeVZiD",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/DwUMqCT9e1yS3Bno1JNGy/_buildManifest.js"
+      src="/_next/static/nzSUuIAzGcZOC3kCeVZiD/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/DwUMqCT9e1yS3Bno1JNGy/_ssgManifest.js"
+      src="/_next/static/nzSUuIAzGcZOC3kCeVZiD/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 1ffd8a2

ijjk · 2021-01-18T14:32:15Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
buildDuration	8.5s	8.8s	⚠️ +241ms
nodeModulesSize	77.6 MB	77.6 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.689	1.704	⚠️ +0.01
/ avg req/sec	1480.13	1467.08	⚠️ -13.05
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.09	1.069	-0.02
/error-in-render avg req/sec	2292.71	2338.2	+45.49

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-9e3e4e6..2023.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
buildDuration	10.4s	10.5s	⚠️ +143ms
nodeModulesSize	77.6 MB	77.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-9e3e4e6..2023.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Webpack 5 Mode (Decrease detected ✓)

General

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
buildDuration	10.6s	10.6s	-59ms
nodeModulesSize	77.6 MB	77.6 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.703	1.747	⚠️ +0.04
/ avg req/sec	1467.82	1430.92	⚠️ -36.9
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.058	1.091	⚠️ +0.03
/error-in-render avg req/sec	2363.51	2291.47	⚠️ -72.04

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
597-3bd7d6bd..868b.js gzip	13 kB	13 kB	✓
778-d412f8e7..3ee1.js gzip	6.56 kB	6.56 kB	✓
838-adcbad39..6e83.js gzip	31.1 kB	31.1 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-6a6a792..6877.js gzip	96 B	96 B	✓
webpack-e302..54e9.js gzip	954 B	954 B	✓
Overall change	91 kB	91 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
polyfills-a0..538c.js gzip	88 B	88 B	✓
Overall change	88 B	88 B	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
index.html gzip	585 B	585 B	✓
link.html gzip	592 B	592 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "WO2zyvcOEEbSfb7x2k5cf",
+        "buildId": "NkHckV_x2SsSneWT0cdQZ",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/WO2zyvcOEEbSfb7x2k5cf/_buildManifest.js"
+      src="/_next/static/NkHckV_x2SsSneWT0cdQZ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/WO2zyvcOEEbSfb7x2k5cf/_ssgManifest.js"
+      src="/_next/static/NkHckV_x2SsSneWT0cdQZ/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "WO2zyvcOEEbSfb7x2k5cf",
+        "buildId": "NkHckV_x2SsSneWT0cdQZ",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/WO2zyvcOEEbSfb7x2k5cf/_buildManifest.js"
+      src="/_next/static/NkHckV_x2SsSneWT0cdQZ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/WO2zyvcOEEbSfb7x2k5cf/_ssgManifest.js"
+      src="/_next/static/NkHckV_x2SsSneWT0cdQZ/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "WO2zyvcOEEbSfb7x2k5cf",
+        "buildId": "NkHckV_x2SsSneWT0cdQZ",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/WO2zyvcOEEbSfb7x2k5cf/_buildManifest.js"
+      src="/_next/static/NkHckV_x2SsSneWT0cdQZ/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/WO2zyvcOEEbSfb7x2k5cf/_ssgManifest.js"
+      src="/_next/static/NkHckV_x2SsSneWT0cdQZ/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 5255f16

docs/upgrading.md

packages/next-codemod/transforms/add-missing-react-import.ts

…t.js into add/react-import-codemod

ijjk · 2021-01-18T14:56:39Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
buildDuration	7.8s	8.3s	⚠️ +501ms
nodeModulesSize	77.6 MB	77.6 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.577	1.717	⚠️ +0.14
/ avg req/sec	1585.18	1456.39	⚠️ -128.79
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	0.992	1.134	⚠️ +0.14
/error-in-render avg req/sec	2521.19	2205.36	⚠️ -315.83

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-9e3e4e6..2023.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
buildDuration	10.4s	10.1s	-327ms
nodeModulesSize	77.6 MB	77.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-9e3e4e6..2023.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
buildDuration	10.7s	10.4s	-264ms
nodeModulesSize	77.6 MB	77.6 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.672	1.705	⚠️ +0.03
/ avg req/sec	1495.61	1466.04	⚠️ -29.57
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.111	0.977	-0.13
/error-in-render avg req/sec	2249.36	2559.31	+309.95

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
597-3bd7d6bd..868b.js gzip	13 kB	13 kB	✓
778-d412f8e7..3ee1.js gzip	6.56 kB	6.56 kB	✓
838-adcbad39..6e83.js gzip	31.1 kB	31.1 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-6a6a792..6877.js gzip	96 B	96 B	✓
webpack-e302..54e9.js gzip	954 B	954 B	✓
Overall change	91 kB	91 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
polyfills-a0..538c.js gzip	88 B	88 B	✓
Overall change	88 B	88 B	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
index.html gzip	585 B	585 B	✓
link.html gzip	592 B	592 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "uj0zAuCtQYmV-6e2UwYHR",
+        "buildId": "jjdnwftTfIE1O2UZqG15O",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/uj0zAuCtQYmV-6e2UwYHR/_buildManifest.js"
+      src="/_next/static/jjdnwftTfIE1O2UZqG15O/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/uj0zAuCtQYmV-6e2UwYHR/_ssgManifest.js"
+      src="/_next/static/jjdnwftTfIE1O2UZqG15O/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "uj0zAuCtQYmV-6e2UwYHR",
+        "buildId": "jjdnwftTfIE1O2UZqG15O",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/uj0zAuCtQYmV-6e2UwYHR/_buildManifest.js"
+      src="/_next/static/jjdnwftTfIE1O2UZqG15O/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/uj0zAuCtQYmV-6e2UwYHR/_ssgManifest.js"
+      src="/_next/static/jjdnwftTfIE1O2UZqG15O/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "uj0zAuCtQYmV-6e2UwYHR",
+        "buildId": "jjdnwftTfIE1O2UZqG15O",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/uj0zAuCtQYmV-6e2UwYHR/_buildManifest.js"
+      src="/_next/static/jjdnwftTfIE1O2UZqG15O/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/uj0zAuCtQYmV-6e2UwYHR/_ssgManifest.js"
+      src="/_next/static/jjdnwftTfIE1O2UZqG15O/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 526c73c

ijjk · 2021-01-18T15:06:36Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
buildDuration	8.8s	8.6s	-159ms
nodeModulesSize	77.6 MB	77.6 MB	✓

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.724	1.735	⚠️ +0.01
/ avg req/sec	1449.78	1441.3	⚠️ -8.48
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.111	1.109	0
/error-in-render avg req/sec	2251.18	2255.19	+4.01

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-9e3e4e6..2023.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
index.html gzip	614 B	614 B	✓
link.html gzip	621 B	621 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
buildDuration	10.3s	10.3s	⚠️ +25ms
nodeModulesSize	77.6 MB	77.6 MB	✓

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
677f882d2ed8..43e3.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-9e3e4e6..2023.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
polyfills-af..9390.js gzip	31.3 kB	31.3 kB	✓
Overall change	31.3 kB	31.3 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Webpack 5 Mode (Increase detected ⚠️)

General

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
buildDuration	10.9s	10.7s	-181ms
nodeModulesSize	77.6 MB	77.6 MB	✓

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.734	1.716	-0.02
/ avg req/sec	1441.83	1456.69	+14.86
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.106	1.107	0
/error-in-render avg req/sec	2259.93	2258.86	⚠️ -1.07

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
597-3bd7d6bd..868b.js gzip	13 kB	13 kB	✓
778-d412f8e7..3ee1.js gzip	6.56 kB	6.56 kB	✓
838-adcbad39..6e83.js gzip	31.1 kB	31.1 kB	✓
framework.HASH.js gzip	39.3 kB	39.3 kB	✓
main-6a6a792..6877.js gzip	96 B	96 B	✓
webpack-e302..54e9.js gzip	954 B	954 B	✓
Overall change	91 kB	91 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
polyfills-a0..538c.js gzip	88 B	88 B	✓
Overall change	88 B	88 B	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_app-a5b2e84..33cf.js gzip	1.26 kB	1.26 kB	✓
_error-6f1f9..5577.js gzip	3.38 kB	3.38 kB	✓
hooks-725de8..0a15.js gzip	904 B	904 B	✓
index-939503..6e1c.js gzip	232 B	232 B	✓
link-e0cc871..fdbb.js gzip	1.63 kB	1.63 kB	✓
routerDirect..9360.js gzip	308 B	308 B	✓
withRouter-6..44ec.js gzip	304 B	304 B	✓
Overall change	8.02 kB	8.02 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
_buildManifest.js gzip	299 B	299 B	✓
Overall change	299 B	299 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/react-import-codemod	Change
index.html gzip	585 B	585 B	✓
link.html gzip	592 B	592 B	✓
withRouter.html gzip	581 B	581 B	✓
Overall change	1.76 kB	1.76 kB	✓

Diffs

Diff for index.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "b08jT3otq5_6sfSCHjhGA",
+        "buildId": "qeFI9gK3FDjnsn5NuuMHL",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/b08jT3otq5_6sfSCHjhGA/_buildManifest.js"
+      src="/_next/static/qeFI9gK3FDjnsn5NuuMHL/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/b08jT3otq5_6sfSCHjhGA/_ssgManifest.js"
+      src="/_next/static/qeFI9gK3FDjnsn5NuuMHL/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for link.html

@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "b08jT3otq5_6sfSCHjhGA",
+        "buildId": "qeFI9gK3FDjnsn5NuuMHL",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/b08jT3otq5_6sfSCHjhGA/_buildManifest.js"
+      src="/_next/static/qeFI9gK3FDjnsn5NuuMHL/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/b08jT3otq5_6sfSCHjhGA/_ssgManifest.js"
+      src="/_next/static/qeFI9gK3FDjnsn5NuuMHL/_ssgManifest.js"
       async=""
     ></script>
   </body>

Diff for withRouter.html

@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "b08jT3otq5_6sfSCHjhGA",
+        "buildId": "qeFI9gK3FDjnsn5NuuMHL",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/b08jT3otq5_6sfSCHjhGA/_buildManifest.js"
+      src="/_next/static/qeFI9gK3FDjnsn5NuuMHL/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/b08jT3otq5_6sfSCHjhGA/_ssgManifest.js"
+      src="/_next/static/qeFI9gK3FDjnsn5NuuMHL/_ssgManifest.js"
       async=""
     ></script>
   </body>

Commit: 0722ec3

timneutkens requested review from chibicode, ijjk, lfades and Timer as code owners January 18, 2021 13:19

ijjk added type: documentation type: next labels Jan 18, 2021

Add option

1ffd8a2

Add section to upgrading guide

5255f16

Timer requested changes Jan 18, 2021

View reviewed changes

docs/upgrading.md Outdated Show resolved Hide resolved

packages/next-codemod/transforms/add-missing-react-import.ts Outdated Show resolved Hide resolved

timneutkens added 3 commits January 18, 2021 15:46

Fix upgrading guide

526c73c

update comment

cdeec64

Merge branch 'add/react-import-codemod' of github.com:timneutkens/nex…

0722ec3

…t.js into add/react-import-codemod

Timer approved these changes Jan 18, 2021

View reviewed changes

vercel deleted a comment from Timer Jan 18, 2021

kodiakhq bot merged commit c5b5c43 into vercel:canary Jan 18, 2021

timneutkens deleted the add/react-import-codemod branch January 18, 2021 15:58

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add codemod for files that do not support the new React JSX transform #21281

Add codemod for files that do not support the new React JSX transform #21281

timneutkens commented Jan 18, 2021

ijjk commented Jan 18, 2021

Diffs

ijjk commented Jan 18, 2021

Diffs

ijjk commented Jan 18, 2021

Diffs

ijjk commented Jan 18, 2021

Diffs

Add codemod for files that do not support the new React JSX transform #21281

Add codemod for files that do not support the new React JSX transform #21281

Conversation

timneutkens commented Jan 18, 2021

ijjk commented Jan 18, 2021

Stats from current PR

Diffs

ijjk commented Jan 18, 2021

Stats from current PR

Diffs

ijjk commented Jan 18, 2021

Stats from current PR

Diffs

ijjk commented Jan 18, 2021

Stats from current PR

Diffs