Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expanded on No Router Instance #21248

Merged
merged 6 commits into from Jan 26, 2021
Merged

expanded on No Router Instance #21248

merged 6 commits into from Jan 26, 2021

Conversation

Robogeek95
Copy link
Contributor

Added more detailed explanation of why there is no router instance, and other ways to fix the error

@ijjk
Copy link
Member

ijjk commented Jan 17, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Robogeek95/next.js patch-2 Change
buildDuration 9.7s 9.5s -221ms
nodeModulesSize 77.6 MB 77.6 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Robogeek95/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.908 1.918 ⚠️ +0.01
/ avg req/sec 1310.36 1303.56 ⚠️ -6.8
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.166 1.182 ⚠️ +0.02
/error-in-render avg req/sec 2143.47 2115.14 ⚠️ -28.33
Client Bundles (main, webpack, commons)
vercel/next.js canary Robogeek95/next.js patch-2 Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-712e20f..aa05.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Robogeek95/next.js patch-2 Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Robogeek95/next.js patch-2 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Robogeek95/next.js patch-2 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Robogeek95/next.js patch-2 Change
index.html gzip 615 B 615 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary Robogeek95/next.js patch-2 Change
buildDuration 11.7s 11.6s -87ms
nodeModulesSize 77.6 MB 77.6 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Robogeek95/next.js patch-2 Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-712e20f..aa05.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Robogeek95/next.js patch-2 Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Robogeek95/next.js patch-2 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Robogeek95/next.js patch-2 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Robogeek95/next.js patch-2 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 1aa32d4

@ijjk
Copy link
Member

ijjk commented Jan 23, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary Robogeek95/next.js patch-2 Change
buildDuration 10s 10.1s ⚠️ +43ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary Robogeek95/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.987 2.024 ⚠️ +0.04
/ avg req/sec 1257.93 1234.99 ⚠️ -22.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.294 1.271 -0.02
/error-in-render avg req/sec 1931.61 1966.77 +35.16
Client Bundles (main, webpack, commons)
vercel/next.js canary Robogeek95/next.js patch-2 Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9ad7be4..1cfb.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Robogeek95/next.js patch-2 Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Robogeek95/next.js patch-2 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Robogeek95/next.js patch-2 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Robogeek95/next.js patch-2 Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary Robogeek95/next.js patch-2 Change
buildDuration 12.3s 12.3s ⚠️ +70ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Robogeek95/next.js patch-2 Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9ad7be4..1cfb.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Robogeek95/next.js patch-2 Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Robogeek95/next.js patch-2 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Robogeek95/next.js patch-2 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Robogeek95/next.js patch-2 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Commit: c1c5a50

timneutkens
timneutkens previously approved these changes Jan 24, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tweaked the wording and removed the mention of window which does not relate to why the router does not work server-side.

@ijjk
Copy link
Member

ijjk commented Jan 24, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary Robogeek95/next.js patch-2 Change
buildDuration 8.8s 8.6s -245ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Robogeek95/next.js patch-2 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.713 1.762 ⚠️ +0.05
/ avg req/sec 1459.57 1419.17 ⚠️ -40.4
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.095 1.107 ⚠️ +0.01
/error-in-render avg req/sec 2282.67 2257.7 ⚠️ -24.97
Client Bundles (main, webpack, commons)
vercel/next.js canary Robogeek95/next.js patch-2 Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9ad7be4..1cfb.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Robogeek95/next.js patch-2 Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Robogeek95/next.js patch-2 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Robogeek95/next.js patch-2 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary Robogeek95/next.js patch-2 Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary Robogeek95/next.js patch-2 Change
buildDuration 10.4s 10.2s -133ms
nodeModulesSize 73.3 MB 73.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary Robogeek95/next.js patch-2 Change
677f882d2ed8..38ed.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9ad7be4..1cfb.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Robogeek95/next.js patch-2 Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary Robogeek95/next.js patch-2 Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary Robogeek95/next.js patch-2 Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary Robogeek95/next.js patch-2 Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.19 MB 5.19 MB ✓
Commit: fe739b1

@ijjk

This comment has been minimized.

Sign in to view
@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. examples Issue/PR related to examples type: next labels Jan 26, 2021
@timneutkens timneutkens changed the base branch from master to canary January 26, 2021 10:18
timneutkens
timneutkens approved these changes Jan 26, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've made some edits and updated the PR.

@kodiakhq kodiakhq bot merged commit 00d453d into vercel:canary Jan 26, 2021
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@chibicode chibicode Awaiting requested review from chibicode

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. examples Issue/PR related to examples type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Robogeek95 @ijjk @timneutkens