Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve two peer dep install warnings #21176

Merged
merged 2 commits into from Jan 15, 2021

Conversation

Timer
Copy link
Member

@Timer Timer commented Jan 15, 2021

This removes the peer dep on webpack from react-dev-overlay, as it is for types only.

This makes the peer dep on webpack optional for react-refresh-utils, as you can provide webpack via the constructor (how Next.js does).

@ijjk
Copy link
Member

ijjk commented Jan 15, 2021

Stats from current PR

Default Server Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
buildDuration 8.9s 8.9s -10ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +52 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
/ failed reqs 0 0
/ total time (seconds) 1.733 1.744 ⚠️ +0.01
/ avg req/sec 1442.19 1433.47 ⚠️ -8.72
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.092 1.088 0
/error-in-render avg req/sec 2288.33 2298.19 +9.86
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-b70be25..6967.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
index.html gzip 613 B 613 B
link.html gzip 619 B 619 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
buildDuration 10.2s 10.3s ⚠️ +146ms
nodeModulesSize 77.5 MB 77.5 MB -10.1 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-b70be25..6967.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 4ea7d45

@Timer Timer requested a review from ijjk January 15, 2021 16:17
@ijjk
Copy link
Member

ijjk commented Jan 15, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
buildDuration 10.6s 10.3s -284ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +52 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
/ failed reqs 0 0
/ total time (seconds) 2.048 2.004 -0.04
/ avg req/sec 1220.93 1247.23 +26.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.283 1.302 ⚠️ +0.02
/error-in-render avg req/sec 1948.26 1920.67 ⚠️ -27.59
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-b70be25..6967.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
index.html gzip 613 B 613 B
link.html gzip 619 B 619 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
buildDuration 12.2s 12.3s ⚠️ +63ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +52 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-b70be25..6967.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/install-warnings Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 76438b6

@kodiakhq kodiakhq bot merged commit 54bee4f into vercel:canary Jan 15, 2021
@Timer Timer deleted the hotfix/install-warnings branch January 15, 2021 16:49
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants