Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: webpack 5 and worker-loader support #21050

Merged
merged 6 commits into from Jan 14, 2021
Merged

fix: webpack 5 and worker-loader support #21050

merged 6 commits into from Jan 14, 2021

Conversation

ramasilveyra
Copy link
Contributor

@ramasilveyra ramasilveyra commented Jan 13, 2021 •
edited by Timer

Fix #21049.

When using next.js with webpack 5 and worker-loader an exception appears.

The exception Uncaught TypeError: Cannot read property 'push' of undefined happens when the web worker code is executed by the browser.

Repro: https://github.com/ramasilveyra/bug-repro-next-w5-worker

  • Updated worker-loader to v3 that supports webpack 5.

  • Re enabled skipped worker-loader test suite and added to be ran with webpack 5.

  • Since the exception happens when the web worker code is executed, the current worker-loader test covers this bug.

  • Previously this test suite was failing with webpack 5:

Screen Shot 2021-01-13 at 1 34 05 AM

@ijjk
Copy link
Member

ijjk commented Jan 13, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
buildDuration 8.7s 8.5s -120ms
nodeModulesSize 80.9 MB 80.9 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.76 1.729 -0.03
/ avg req/sec 1420.57 1445.8 +25.23
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.08 1.105 ⚠️ +0.02
/error-in-render avg req/sec 2315.07 2262.82 ⚠️ -52.25
Client Bundles (main, webpack, commons)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
index.html gzip 615 B 615 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
buildDuration 10.5s 10.5s -76ms
nodeModulesSize 80.9 MB 80.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 5a965c9

@ramasilveyra ramasilveyra marked this pull request as ready for review January 13, 2021 04:57
timneutkens
timneutkens reviewed Jan 13, 2021
View reviewed changes
packages/react-refresh-utils/ReactRefreshWebpackPlugin.ts
@@ -95,6 +95,7 @@ function webpack5(compiler: Compiler) {
// @ts-ignore This exists in webpack 5
const { runtimeTemplate } = this.compilation
return Template.asString([
`if (${RuntimeGlobals.interceptModuleExecution}) {`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a specific integration test to be added for this case? It's unclear what it solves.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timneutkens React refresh template is injected in web worker bundle and an exception is created: Uncaught TypeError: Cannot read property 'push' of undefined

Here there is a repro https://github.com/ramasilveyra/bug-repro-next-w5-worker

I will update pr description with this info.

The exception happens when web worker is executed, so the current worker loader test covers this case.

@ijjk
Copy link
Member

ijjk commented Jan 13, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
buildDuration 8.6s 8.7s ⚠️ +77ms
nodeModulesSize 80.9 MB 80.8 MB -10.1 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.759 1.737 -0.02
/ avg req/sec 1421.08 1439 +17.92
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.107 1.101 -0.01
/error-in-render avg req/sec 2258.39 2270.74 +12.35
Client Bundles (main, webpack, commons)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
index.html gzip 615 B 615 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
buildDuration 10.4s 10.6s ⚠️ +262ms
nodeModulesSize 80.9 MB 80.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 34a27d0

Timer
Timer previously approved these changes Jan 13, 2021
View reviewed changes
@ijjk
Copy link
Member

ijjk commented Jan 13, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
buildDuration 8.7s 8.8s ⚠️ +95ms
nodeModulesSize 80.8 MB 80.9 MB ⚠️ +10.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.725 1.777 ⚠️ +0.05
/ avg req/sec 1449.67 1406.64 ⚠️ -43.03
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.113 1.122 ⚠️ +0.01
/error-in-render avg req/sec 2245.84 2227.51 ⚠️ -18.33
Client Bundles (main, webpack, commons)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
index.html gzip 615 B 615 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
buildDuration 10.4s 10.5s ⚠️ +128ms
nodeModulesSize 80.9 MB 80.9 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 1925f2c

@ijjk
Copy link
Member

ijjk commented Jan 14, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
buildDuration 10.5s 10.6s ⚠️ +157ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +90 B
Page Load Tests Overall increase ✓
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.224 2.198 -0.03
/ avg req/sec 1124.13 1137.6 +13.47
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.527 1.513 -0.01
/error-in-render avg req/sec 1637.22 1651.92 +14.7
Client Bundles (main, webpack, commons)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9d28255..78cd.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
buildDuration 12.2s 12.4s ⚠️ +132ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +90 B
Client Bundles (main, webpack, commons)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9d28255..78cd.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: a792904

@ijjk
Copy link
Member

ijjk commented Jan 14, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
buildDuration 10.5s 11s ⚠️ +518ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +90 B
Page Load Tests Overall increase ✓
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.129 2.079 -0.05
/ avg req/sec 1174.48 1202.77 +28.29
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.352 1.347 -0.01
/error-in-render avg req/sec 1848.56 1855.69 +7.13
Client Bundles (main, webpack, commons)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9d28255..78cd.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
buildDuration 12.7s 12.7s -8ms
nodeModulesSize 77.5 MB 77.5 MB -9.92 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9d28255..78cd.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 73f62b0

@ijjk
Copy link
Member

ijjk commented Jan 14, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
buildDuration 10.4s 10.3s -77ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +90 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.982 2.074 ⚠️ +0.09
/ avg req/sec 1261.38 1205.11 ⚠️ -56.27
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.268 1.329 ⚠️ +0.06
/error-in-render avg req/sec 1971.3 1881.63 ⚠️ -89.67
Client Bundles (main, webpack, commons)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9d28255..78cd.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
buildDuration 12s 12s -15ms
nodeModulesSize 77.5 MB 77.5 MB -10 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9d28255..78cd.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary ramasilveyra/next.js fix/w5-web-worker Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 25d027c

@Timer Timer merged commit d72b2d6 into vercel:canary Jan 14, 2021
@ramasilveyra ramasilveyra deleted the fix/w5-web-worker branch January 14, 2021 21:43
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

broken webpack 5 and worker-loader support
4 participants
@ramasilveyra @ijjk @Timer @timneutkens