Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump minimum suggested React version #21046

Merged
merged 10 commits into from Jan 15, 2021
Merged

Conversation

devknoll
Copy link
Contributor

@devknoll devknoll commented Jan 13, 2021

Bump the minimum suggested React version to 17.0.1

@devknoll devknoll changed the title Update minimum suggested React version Bump minimum suggested React version Jan 13, 2021
@ijjk
Copy link
Member

ijjk commented Jan 13, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
buildDuration 8.6s 8.7s ⚠️ +90ms
nodeModulesSize 80.9 MB 80.9 MB ⚠️ +3.22 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
/ failed reqs 0 0
/ total time (seconds) 1.695 1.7 0
/ avg req/sec 1474.57 1470.84 ⚠️ -3.73
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.082 1.107 ⚠️ +0.02
/error-in-render avg req/sec 2311.54 2257.4 ⚠️ -54.14
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js add-react-16-warning Change
index.html gzip 615 B 615 B
link.html gzip 619 B 619 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary azukaru/next.js add-react-16-warning Change
buildDuration 10.5s 10.3s -175ms
nodeModulesSize 80.9 MB 80.8 MB -6.79 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB
Overall change 31.2 kB 31.2 kB
Client Pages
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 478c764

@ijjk
Copy link
Member

ijjk commented Jan 13, 2021

Failing test suites

Commit: 478c764

test/integration/font-optimization/test/index.test.js

  • Font optimization for SSR apps > should inline the google fonts for static pages
  • Font optimization for SSR apps > should inline the google fonts for static pages with Next/Head
  • Font optimization for SSR apps > should inline the google fonts for SSR pages
  • Font optimization for emulated serverless apps > should inline the google fonts for static pages
  • Font optimization for emulated serverless apps > should inline the google fonts for static pages with Next/Head
  • Font optimization for emulated serverless apps > should inline the google fonts for SSR pages
  • Font optimization for serverless apps > should inline the google fonts for static pages
  • Font optimization for serverless apps > should inline the google fonts for static pages with Next/Head
  • Font optimization for serverless apps > should inline the google fonts for SSR pages
Expand output

● Font optimization for SSR apps › should inline the google fonts for static pages

expect(received).toMatch(expected)

Expected pattern: /<style data-href="https:\/\/fonts\.googleapis\.com\/css\?family=Voces">.*<\/style>/
Received string:  "<!DOCTYPE html><html><head><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css?family=Voces\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta charSet=\"utf-8\"/><title>404: This page could not be found</title><meta name=\"next-head-count\" content=\"3\"/><noscript data-n-css=\"\"></noscript><link rel=\"preload\" href=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_error-6df9485e4c61aedff844.js\" as=\"script\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css?family=Voces\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css2?family=Modak\"/></head><body><div id=\"__next\"><div style=\"color:#000;background:#fff;font-family:-apple-system, BlinkMacSystemFont, Roboto, &quot;Segoe UI&quot;, &quot;Fira Sans&quot;, Avenir, &quot;Helvetica Neue&quot;, &quot;Lucida Grande&quot;, sans-serif;height:100vh;text-align:center;display:flex;flex-direction:column;align-items:center;justify-content:center\"><div><style>body { margin: 0 }</style><h1 style=\"display:inline-block;border-right:1px solid rgba(0, 0, 0,.3);margin:0;margin-right:20px;padding:10px 23px 10px 0;font-size:24px;font-weight:500;vertical-align:top\">404</h1><div style=\"display:inline-block;text-align:left;line-height:49px;height:49px;vertical-align:middle\"><h2 style=\"font-size:14px;font-weight:normal;line-height:inherit;margin:0;padding:0\">This page could not be found<!-- -->.</h2></div></div></div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"statusCode\":404}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"gLoI4sEWZmOWwhFpDJIsw\",\"nextExport\":true,\"isFallback\":false,\"gip\":true}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-0c517e3fc50908d11bf9.js\"></script><script src=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_error-6df9485e4c61aedff844.js\" async=\"\"></script><script src=\"/_next/static/gLoI4sEWZmOWwhFpDJIsw/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/gLoI4sEWZmOWwhFpDJIsw/_ssgManifest.js\" async=\"\"></script></body></html>"

  48 |       '<link rel="stylesheet" data-href="https://fonts.googleapis.com/css?family=Voces"/>'
  49 |     )
> 50 |     expect(html).toMatch(
     |                  ^
  51 |       /<style data-href="https:\/\/fonts\.googleapis\.com\/css\?family=Voces">.*<\/style>/
  52 |     )
  53 |   })

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:50:18)

● Font optimization for SSR apps › should inline the google fonts for static pages with Next/Head

expect(received).toMatch(expected)

Expected pattern: /<style data-href="https:\/\/fonts\.googleapis\.com\/css2\?family=Modak">.*<\/style>/
Received string:  "<!DOCTYPE html><html><head><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css?family=Voces\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta charSet=\"utf-8\"/><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css2?family=Modak\"/><meta name=\"next-head-count\" content=\"3\"/><noscript data-n-css=\"\"></noscript><link rel=\"preload\" href=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/static-head-53dd0e723a0081a2f5fe.js\" as=\"script\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css?family=Voces\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css2?family=Modak\"/></head><body><div id=\"__next\"><div>Hi!</div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/static-head\",\"query\":{},\"buildId\":\"gLoI4sEWZmOWwhFpDJIsw\",\"nextExport\":true,\"autoExport\":true,\"isFallback\":false}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-0c517e3fc50908d11bf9.js\"></script><script src=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/static-head-53dd0e723a0081a2f5fe.js\" async=\"\"></script><script src=\"/_next/static/gLoI4sEWZmOWwhFpDJIsw/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/gLoI4sEWZmOWwhFpDJIsw/_ssgManifest.js\" async=\"\"></script></body></html>"

  59 |       '<link rel="stylesheet" data-href="https://fonts.googleapis.com/css2?family=Modak"/>'
  60 |     )
> 61 |     expect(html).toMatch(
     |                  ^
  62 |       /<style data-href="https:\/\/fonts\.googleapis\.com\/css2\?family=Modak">.*<\/style>/
  63 |     )
  64 |   })

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:61:18)

● Font optimization for SSR apps › should inline the google fonts for SSR pages

expect(received).toMatch(expected)

Expected pattern: /<style data-href="https:\/\/fonts\.googleapis\.com\/css2\?family=Roboto:wght@700">.*<\/style>/
Received string:  "<!DOCTYPE html><html><head><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css?family=Voces\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta charSet=\"utf-8\"/><title>Create Next App</title><link rel=\"icon\" href=\"/favicon.ico\"/><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css2?family=Roboto:wght@700\"/><meta name=\"next-head-count\" content=\"5\"/><noscript data-n-css=\"\"></noscript><link rel=\"preload\" href=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/stars-1375cff7be30938b2751.js\" as=\"script\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css?family=Voces\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css2?family=Roboto:wght@700\"/></head><body><div id=\"__next\"><div class=\"container\"><main><div>Next stars: <!-- -->889.6997160843651</div></main></div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"stars\":889.6997160843651}},\"page\":\"/stars\",\"query\":{},\"buildId\":\"gLoI4sEWZmOWwhFpDJIsw\",\"isFallback\":false,\"gip\":true}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-0c517e3fc50908d11bf9.js\"></script><script src=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/stars-1375cff7be30938b2751.js\" async=\"\"></script><script src=\"/_next/static/gLoI4sEWZmOWwhFpDJIsw/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/gLoI4sEWZmOWwhFpDJIsw/_ssgManifest.js\" async=\"\"></script></body></html>"

  70 |       '<link rel="stylesheet" data-href="https://fonts.googleapis.com/css2?family=Roboto:wght@700"/>'
  71 |     )
> 72 |     expect(html).toMatch(
     |                  ^
  73 |       /<style data-href="https:\/\/fonts\.googleapis\.com\/css2\?family=Roboto:wght@700">.*<\/style>/
  74 |     )
  75 |   })

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:72:18)

● Font optimization for serverless apps › should inline the google fonts for static pages

expect(received).toMatch(expected)

Expected pattern: /<style data-href="https:\/\/fonts\.googleapis\.com\/css\?family=Voces">.*<\/style>/
Received string:  "<!DOCTYPE html><html><head><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css?family=Voces\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta charSet=\"utf-8\"/><title>404: This page could not be found</title><meta name=\"next-head-count\" content=\"3\"/><noscript data-n-css=\"\"></noscript><link rel=\"preload\" href=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_error-6df9485e4c61aedff844.js\" as=\"script\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css?family=Voces\"/></head><body><div id=\"__next\"><div style=\"color:#000;background:#fff;font-family:-apple-system, BlinkMacSystemFont, Roboto, &quot;Segoe UI&quot;, &quot;Fira Sans&quot;, Avenir, &quot;Helvetica Neue&quot;, &quot;Lucida Grande&quot;, sans-serif;height:100vh;text-align:center;display:flex;flex-direction:column;align-items:center;justify-content:center\"><div><style>body { margin: 0 }</style><h1 style=\"display:inline-block;border-right:1px solid rgba(0, 0, 0,.3);margin:0;margin-right:20px;padding:10px 23px 10px 0;font-size:24px;font-weight:500;vertical-align:top\">404</h1><div style=\"display:inline-block;text-align:left;line-height:49px;height:49px;vertical-align:middle\"><h2 style=\"font-size:14px;font-weight:normal;line-height:inherit;margin:0;padding:0\">This page could not be found<!-- -->.</h2></div></div></div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"statusCode\":404}},\"page\":\"/_error\",\"query\":{},\"buildId\":\"OwlZlzbTKeNp9AhPnhliN\",\"runtimeConfig\":{},\"nextExport\":true,\"isFallback\":false,\"gip\":true}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-0c517e3fc50908d11bf9.js\"></script><script src=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_error-6df9485e4c61aedff844.js\" async=\"\"></script><script src=\"/_next/static/OwlZlzbTKeNp9AhPnhliN/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/OwlZlzbTKeNp9AhPnhliN/_ssgManifest.js\" async=\"\"></script></body></html>"

  48 |       '<link rel="stylesheet" data-href="https://fonts.googleapis.com/css?family=Voces"/>'
  49 |     )
> 50 |     expect(html).toMatch(
     |                  ^
  51 |       /<style data-href="https:\/\/fonts\.googleapis\.com\/css\?family=Voces">.*<\/style>/
  52 |     )
  53 |   })

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:50:18)

● Font optimization for serverless apps › should inline the google fonts for static pages with Next/Head

expect(received).toMatch(expected)

Expected pattern: /<style data-href="https:\/\/fonts\.googleapis\.com\/css2\?family=Modak">.*<\/style>/
Received string:  "<!DOCTYPE html><html><head><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css?family=Voces\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta charSet=\"utf-8\"/><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css2?family=Modak\"/><meta name=\"next-head-count\" content=\"3\"/><noscript data-n-css=\"\"></noscript><link rel=\"preload\" href=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/static-head-53dd0e723a0081a2f5fe.js\" as=\"script\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css?family=Voces\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css2?family=Modak\"/></head><body><div id=\"__next\"><div>Hi!</div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/static-head\",\"query\":{},\"buildId\":\"OwlZlzbTKeNp9AhPnhliN\",\"runtimeConfig\":{},\"nextExport\":true,\"autoExport\":true,\"isFallback\":false}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-0c517e3fc50908d11bf9.js\"></script><script src=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/static-head-53dd0e723a0081a2f5fe.js\" async=\"\"></script><script src=\"/_next/static/OwlZlzbTKeNp9AhPnhliN/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/OwlZlzbTKeNp9AhPnhliN/_ssgManifest.js\" async=\"\"></script></body></html>"

  59 |       '<link rel="stylesheet" data-href="https://fonts.googleapis.com/css2?family=Modak"/>'
  60 |     )
> 61 |     expect(html).toMatch(
     |                  ^
  62 |       /<style data-href="https:\/\/fonts\.googleapis\.com\/css2\?family=Modak">.*<\/style>/
  63 |     )
  64 |   })

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:61:18)

● Font optimization for serverless apps › should inline the google fonts for SSR pages

expect(received).toMatch(expected)

Expected pattern: /<style data-href="https:\/\/fonts\.googleapis\.com\/css2\?family=Roboto:wght@700">.*<\/style>/
Received string:  "<!DOCTYPE html><html><head><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css?family=Voces\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta charSet=\"utf-8\"/><title>Create Next App</title><link rel=\"icon\" href=\"/favicon.ico\"/><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css2?family=Roboto:wght@700\"/><meta name=\"next-head-count\" content=\"5\"/><noscript data-n-css=\"\"></noscript><link rel=\"preload\" href=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/stars-1375cff7be30938b2751.js\" as=\"script\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css?family=Voces\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css2?family=Roboto:wght@700\"/></head><body><div id=\"__next\"><div class=\"container\"><main><div>Next stars: <!-- -->877.2668965755605</div></main></div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"stars\":877.2668965755605}},\"page\":\"/stars\",\"query\":{},\"buildId\":\"OwlZlzbTKeNp9AhPnhliN\",\"runtimeConfig\":{},\"nextExport\":false,\"isFallback\":false,\"gip\":true}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-0c517e3fc50908d11bf9.js\"></script><script src=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/stars-1375cff7be30938b2751.js\" async=\"\"></script><script src=\"/_next/static/OwlZlzbTKeNp9AhPnhliN/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/OwlZlzbTKeNp9AhPnhliN/_ssgManifest.js\" async=\"\"></script></body></html>"

  70 |       '<link rel="stylesheet" data-href="https://fonts.googleapis.com/css2?family=Roboto:wght@700"/>'
  71 |     )
> 72 |     expect(html).toMatch(
     |                  ^
  73 |       /<style data-href="https:\/\/fonts\.googleapis\.com\/css2\?family=Roboto:wght@700">.*<\/style>/
  74 |     )
  75 |   })

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:72:18)

● Font optimization for emulated serverless apps › should inline the google fonts for static pages

expect(received).toMatch(expected)

Expected pattern: /<style data-href="https:\/\/fonts\.googleapis\.com\/css\?family=Voces">.*<\/style>/
Received string:  "<!DOCTYPE html><html><head><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css?family=Voces\"/><meta charSet=\"utf-8\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta name=\"next-head-count\" content=\"2\"/><noscript data-n-css=\"\"></noscript><link rel=\"preload\" href=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/index-25eb4386fc3a9a67052d.js\" as=\"script\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css?family=Voces\"/></head><body><div id=\"__next\"><div>Hi!</div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/\",\"query\":{},\"buildId\":\"EaR8SXX2gavLIZ11CAfGX\",\"runtimeConfig\":{},\"nextExport\":true,\"autoExport\":true,\"isFallback\":false}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-0c517e3fc50908d11bf9.js\"></script><script src=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/index-25eb4386fc3a9a67052d.js\" async=\"\"></script><script src=\"/_next/static/EaR8SXX2gavLIZ11CAfGX/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/EaR8SXX2gavLIZ11CAfGX/_ssgManifest.js\" async=\"\"></script></body></html>"

  48 |       '<link rel="stylesheet" data-href="https://fonts.googleapis.com/css?family=Voces"/>'
  49 |     )
> 50 |     expect(html).toMatch(
     |                  ^
  51 |       /<style data-href="https:\/\/fonts\.googleapis\.com\/css\?family=Voces">.*<\/style>/
  52 |     )
  53 |   })

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:50:18)

● Font optimization for emulated serverless apps › should inline the google fonts for static pages with Next/Head

expect(received).toMatch(expected)

Expected pattern: /<style data-href="https:\/\/fonts\.googleapis\.com\/css2\?family=Modak">.*<\/style>/
Received string:  "<!DOCTYPE html><html><head><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css?family=Voces\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta charSet=\"utf-8\"/><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css2?family=Modak\"/><meta name=\"next-head-count\" content=\"3\"/><noscript data-n-css=\"\"></noscript><link rel=\"preload\" href=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/static-head-53dd0e723a0081a2f5fe.js\" as=\"script\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css?family=Voces\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css2?family=Modak\"/></head><body><div id=\"__next\"><div>Hi!</div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/static-head\",\"query\":{},\"buildId\":\"EaR8SXX2gavLIZ11CAfGX\",\"runtimeConfig\":{},\"nextExport\":true,\"autoExport\":true,\"isFallback\":false}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-0c517e3fc50908d11bf9.js\"></script><script src=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/static-head-53dd0e723a0081a2f5fe.js\" async=\"\"></script><script src=\"/_next/static/EaR8SXX2gavLIZ11CAfGX/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/EaR8SXX2gavLIZ11CAfGX/_ssgManifest.js\" async=\"\"></script></body></html>"

  59 |       '<link rel="stylesheet" data-href="https://fonts.googleapis.com/css2?family=Modak"/>'
  60 |     )
> 61 |     expect(html).toMatch(
     |                  ^
  62 |       /<style data-href="https:\/\/fonts\.googleapis\.com\/css2\?family=Modak">.*<\/style>/
  63 |     )
  64 |   })

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:61:18)

● Font optimization for emulated serverless apps › should inline the google fonts for SSR pages

expect(received).toMatch(expected)

Expected pattern: /<style data-href="https:\/\/fonts\.googleapis\.com\/css2\?family=Roboto:wght@700">.*<\/style>/
Received string:  "<!DOCTYPE html><html><head><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css?family=Voces\"/><meta name=\"viewport\" content=\"width=device-width\"/><meta charSet=\"utf-8\"/><title>Create Next App</title><link rel=\"icon\" href=\"/favicon.ico\"/><link rel=\"stylesheet\" data-href=\"https://fonts.googleapis.com/css2?family=Roboto:wght@700\"/><meta name=\"next-head-count\" content=\"5\"/><noscript data-n-css=\"\"></noscript><link rel=\"preload\" href=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" as=\"script\"/><link rel=\"preload\" href=\"/_next/static/chunks/pages/stars-1375cff7be30938b2751.js\" as=\"script\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css?family=Voces\"/><link rel=\"stylesheet\" href=\"https://fonts.googleapis.com/css2?family=Roboto:wght@700\"/></head><body><div id=\"__next\"><div class=\"container\"><main><div>Next stars: <!-- -->288.0059315801482</div></main></div></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{\"stars\":288.0059315801482}},\"page\":\"/stars\",\"query\":{},\"buildId\":\"EaR8SXX2gavLIZ11CAfGX\",\"runtimeConfig\":{},\"nextExport\":false,\"isFallback\":false,\"gip\":true}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-0c517e3fc50908d11bf9.js\"></script><script src=\"/_next/static/chunks/main-34a63a8a4f7e973a15a2.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.3852f242710f966090d1.js\" async=\"\"></script><script src=\"/_next/static/chunks/279ac2b5366948f8a3fe6b33a5b1c5337242d383.86f42b7d96e6ec95d4a6.js\" async=\"\"></script><script src=\"/_next/static/chunks/f6078781a05fe1bcb0902d23dbbb2662c8d200b3.3d2ee0d3cd6c23454fcb.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-d87ccac4ad4f3e7339e2.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/stars-1375cff7be30938b2751.js\" async=\"\"></script><script src=\"/_next/static/EaR8SXX2gavLIZ11CAfGX/_buildManifest.js\" async=\"\"></script><script src=\"/_next/static/EaR8SXX2gavLIZ11CAfGX/_ssgManifest.js\" async=\"\"></script></body></html>"

  70 |       '<link rel="stylesheet" data-href="https://fonts.googleapis.com/css2?family=Roboto:wght@700"/>'
  71 |     )
> 72 |     expect(html).toMatch(
     |                  ^
  73 |       /<style data-href="https:\/\/fonts\.googleapis\.com\/css2\?family=Roboto:wght@700">.*<\/style>/
  74 |     )
  75 |   })

  at Object.<anonymous> (integration/font-optimization/test/index.test.js:72:18)

test/integration/size-limit/test/index.test.js

  • Production response size > should not increase the overall response size of default build
Expand output

● Production response size › should not increase the overall response size of default build

expect(received).toBeCloseTo(expected, precision)

Expected: 282.6
Received: 284.1123046875

Expected precision:    0
Expected difference: < 0.5
Received difference:   1.5123046874999773

  82 | 
  83 |     // Expected difference: < 0.5
> 84 |     expect(delta).toBeCloseTo(282.6, 0)
     |                   ^
  85 |   })
  86 | })
  87 | 

  at Object.<anonymous> (integration/size-limit/test/index.test.js:84:19)

@ijjk
Copy link
Member

ijjk commented Jan 14, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
buildDuration 10.4s 10.4s -16ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +3.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
/ failed reqs 0 0
/ total time (seconds) 2.141 2.126 -0.02
/ avg req/sec 1167.79 1176.19 +8.4
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.306 1.378 ⚠️ +0.07
/error-in-render avg req/sec 1913.97 1813.93 ⚠️ -100.04
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-9d28255..78cd.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js add-react-16-warning Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
buildDuration 12.6s 12.4s -196ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +3.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-9d28255..78cd.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: a2ca10f

@ijjk
Copy link
Member

ijjk commented Jan 14, 2021

Failing test suites

Commit: a2ca10f

test/integration/build-output/test/index.test.js

  • Build Output > Crypto Application > should not include crypto
Expand output

● Build Output › Crypto Application › should not include crypto

expect(received).toBeLessThanOrEqual(expected)

Expected: <= 66.4
Received:    66.6

  169 |       expect(indexSize.endsWith('kB')).toBe(true)
  170 | 
> 171 |       expect(parseFloat(indexFirstLoad)).toBeLessThanOrEqual(66.4)
      |                                          ^
  172 |       expect(parseFloat(indexFirstLoad)).toBeGreaterThanOrEqual(60)
  173 |       expect(indexFirstLoad.endsWith('kB')).toBe(true)
  174 |     })

  at Object.<anonymous> (integration/build-output/test/index.test.js:171:42)

@ijjk
Copy link
Member

ijjk commented Jan 14, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
buildDuration 8.8s 8.7s -76ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +3.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
/ failed reqs 0 0
/ total time (seconds) 1.742 1.725 -0.02
/ avg req/sec 1435.29 1449.59 +14.3
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.103 1.11 ⚠️ +0.01
/error-in-render avg req/sec 2266.5 2251.89 ⚠️ -14.61
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-9d28255..78cd.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js add-react-16-warning Change
index.html gzip 614 B 614 B
link.html gzip 620 B 620 B
withRouter.html gzip 608 B 608 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
buildDuration 10.7s 10.4s -272ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +3.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-9d28255..78cd.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 3568c8f

@devknoll devknoll marked this pull request as ready for review January 14, 2021 19:00
@ijjk
Copy link
Member

ijjk commented Jan 14, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
buildDuration 12s 12.2s ⚠️ +262ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +3.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
/ failed reqs 0 0
/ total time (seconds) 2.506 2.578 ⚠️ +0.07
/ avg req/sec 997.5 969.74 ⚠️ -27.76
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.813 1.907 ⚠️ +0.09
/error-in-render avg req/sec 1378.55 1310.85 ⚠️ -67.7
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-5e5e203..07ba.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js add-react-16-warning Change
index.html gzip 614 B 614 B
link.html gzip 619 B 619 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
buildDuration 14.3s 14.5s ⚠️ +201ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +3.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-5e5e203..07ba.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 206f952

@ijjk
Copy link
Member

ijjk commented Jan 14, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
buildDuration 8.7s 8.9s ⚠️ +248ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +3.6 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
/ failed reqs 0 0
/ total time (seconds) 1.706 1.721 ⚠️ +0.02
/ avg req/sec 1465.22 1452.3 ⚠️ -12.92
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.093 1.108 ⚠️ +0.02
/error-in-render avg req/sec 2288.09 2256.55 ⚠️ -31.54
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-5e5e203..07ba.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js add-react-16-warning Change
index.html gzip 614 B 614 B
link.html gzip 619 B 619 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
buildDuration 10.3s 10.1s -127ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +13.7 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-5e5e203..07ba.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 1132edc

@ijjk
Copy link
Member

ijjk commented Jan 15, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
buildDuration 10.4s 10.5s ⚠️ +64ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +3.6 kB
Page Load Tests Overall increase ✓
vercel/next.js canary azukaru/next.js add-react-16-warning Change
/ failed reqs 0 0
/ total time (seconds) 2.103 2.098 -0.01
/ avg req/sec 1188.92 1191.42 +2.5
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.292 1.283 -0.01
/error-in-render avg req/sec 1934.76 1948.26 +13.5
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-5e5e203..07ba.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Rendered Page Sizes
vercel/next.js canary azukaru/next.js add-react-16-warning Change
index.html gzip 614 B 614 B
link.html gzip 619 B 619 B
withRouter.html gzip 607 B 607 B
Overall change 1.84 kB 1.84 kB

Serverless Mode
General Overall increase ⚠️
vercel/next.js canary azukaru/next.js add-react-16-warning Change
buildDuration 12.2s 12s -255ms
nodeModulesSize 77.5 MB 77.5 MB ⚠️ +3.6 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-5e5e203..07ba.js gzip 6.63 kB 6.63 kB
webpack-50be..df5b.js gzip 751 B 751 B
Overall change 59.4 kB 59.4 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary azukaru/next.js add-react-16-warning Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB
Overall change 31.3 kB 31.3 kB
Client Pages
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB
hooks-c71ae4..70cd.js gzip 887 B 887 B
index-bbee2f..528b.js gzip 227 B 227 B
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB
routerDirect..bf84.js gzip 303 B 303 B
withRouter-a..5826.js gzip 302 B 302 B
Overall change 8.09 kB 8.09 kB
Client Build Manifests
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_buildManifest.js gzip 321 B 321 B
Overall change 321 B 321 B
Serverless bundles
vercel/next.js canary azukaru/next.js add-react-16-warning Change
_error.js 1 MB 1 MB
404.html 2.67 kB 2.67 kB
hooks.html 1.92 kB 1.92 kB
index.js 1 MB 1 MB
link.js 1.06 MB 1.06 MB
routerDirect.js 1.05 MB 1.05 MB
withRouter.js 1.05 MB 1.05 MB
Overall change 5.18 MB 5.18 MB
Commit: 1c499da

@Timer Timer merged commit cd5ea7d into vercel:canary Jan 15, 2021
@Timer Timer deleted the add-react-16-warning branch January 15, 2021 03:30
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants