Update profiling approach to cover webpack runs #20900

timneutkens · 2021-01-08T13:55:23Z

This adds some extra spans to the existing implementation.

ijjk · 2021-01-09T15:03:42Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
buildDuration	8.4s	8.7s	⚠️ +227ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +2.8 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.729	1.683	-0.05
/ avg req/sec	1445.71	1485.69	+39.98
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.067	1.075	⚠️ +0.01
/error-in-render avg req/sec	2343.32	2325.89	⚠️ -17.43

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-dba4ec1..27c0.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-d979103..c5ff.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
index.html gzip	614 B	614 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	606 B	606 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
buildDuration	10.2s	10.1s	-82ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +2.8 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-dba4ec1..27c0.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-d979103..c5ff.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: a7ee508

ijjk · 2021-01-09T16:06:09Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
buildDuration	9s	9s	-83ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +2.8 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.776	1.737	-0.04
/ avg req/sec	1407.35	1439.48	+32.13
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.115	1.12	⚠️ +0.01
/error-in-render avg req/sec	2241.74	2231.98	⚠️ -9.76

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-dba4ec1..27c0.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-d979103..c5ff.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
index.html gzip	614 B	614 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	606 B	606 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
buildDuration	10.7s	10.7s	-22ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +2.8 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-dba4ec1..27c0.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-d979103..c5ff.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: a0c37e1

ijjk · 2021-01-09T21:36:23Z

Stats from current PR

Default Server Mode (Increase detected ⚠️)

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
buildDuration	11s	10.7s	-348ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +2.8 kB

Page Load Tests Overall increase ✓

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.125	2.085	-0.04
/ avg req/sec	1176.21	1198.83	+22.62
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.312	1.306	-0.01
/error-in-render avg req/sec	1905.61	1913.51	+7.9

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-dba4ec1..27c0.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-d979103..c5ff.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
index.html gzip	614 B	614 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	606 B	606 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode

General Overall increase ⚠️

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
buildDuration	13.2s	12.7s	-431ms
nodeModulesSize	80.8 MB	80.8 MB	⚠️ +2.8 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-dba4ec1..27c0.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-d979103..c5ff.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles

	vercel/next.js canary	timneutkens/next.js add/profiling-work	Change
_error.js	1 MB	1 MB	✓
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	✓
link.js	1.06 MB	1.06 MB	✓
routerDirect.js	1.05 MB	1.05 MB	✓
withRouter.js	1.05 MB	1.05 MB	✓
Overall change	5.18 MB	5.18 MB	✓

Commit: 8f4286e

`process.env.NEXT_PHASE` was moved in vercel#20900 to be set during `staticCheckSpan.traceAsyncFn`. I believe this to be a mistake, the NEXT_PHASE should be set earlier in the code execution. On a personal note, this impacts an application I am developing where we rely on the environment variable `NEXT_PHASE` to be set but is `undefined` when we check it.

`process.env.NEXT_PHASE` was moved in #20900 to be set during `staticCheckSpan.traceAsyncFn`. I believe this to be a mistake, the NEXT_PHASE should be set earlier in the code execution. On a personal note, this impacts an application I am developing where we rely on the environment variable `NEXT_PHASE` to be set but is `undefined` when we check it. Co-authored-by: JJ Kasper <jj@jjsweb.site>

timneutkens added 2 commits January 8, 2021 14:40

Update instrumentation to not batch out of band

d2c4556

Update profiling approach to cover webpack runs

adfaffa

timneutkens requested review from ijjk, lfades and Timer as code owners January 8, 2021 13:55

ijjk added the type: next label Jan 8, 2021

This comment has been minimized.

Sign in to view

timneutkens added 2 commits January 8, 2021 17:05

Remove log

c0b41ca

Update instrumentation so that it no longer affects traces

d619046

This comment has been minimized.

Sign in to view

Await static error promise

a7ee508

Add comment as to why all plugins are disabled

a0c37e1

ijjk approved these changes Jan 9, 2021

View reviewed changes

Merge branch 'canary' into add/profiling-work

8f4286e

Timer merged commit 90ad2cb into vercel:canary Jan 10, 2021

timneutkens deleted the add/profiling-work branch February 12, 2021 13:33

jbraithwaite mentioned this pull request Sep 8, 2021

Prevent NEXT_PHASE env change in workers #28941

Merged

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update profiling approach to cover webpack runs #20900

Update profiling approach to cover webpack runs #20900

timneutkens commented Jan 8, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jan 9, 2021

ijjk commented Jan 9, 2021

ijjk commented Jan 9, 2021

Update profiling approach to cover webpack runs #20900

Update profiling approach to cover webpack runs #20900

Conversation

timneutkens commented Jan 8, 2021

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

ijjk commented Jan 9, 2021

Stats from current PR

ijjk commented Jan 9, 2021

Stats from current PR

ijjk commented Jan 9, 2021

Stats from current PR