Font optimization - remove warning message #20874

janicklas-ralph · 2021-01-07T21:19:29Z

No description provided.

…canary' of github.com:zeit/next.js into canary

ijjk · 2021-01-08T20:02:38Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
buildDuration	10.6s	10.4s	-181ms
nodeModulesSize	80.8 MB	80.8 MB	-600 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.082	2.061	-0.02
/ avg req/sec	1200.49	1212.94	+12.45
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.32	1.339	⚠️ +0.02
/error-in-render avg req/sec	1894.58	1867.05	⚠️ -27.53

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-dba4ec1..27c0.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-d979103..c5ff.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Rendered Page Sizes

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
index.html gzip	614 B	614 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	606 B	606 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
buildDuration	12.6s	12.6s	-40ms
nodeModulesSize	80.8 MB	80.8 MB	-600 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
677f882d2ed8..89aa.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-dba4ec1..27c0.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_app-b6fc6bc..222c.js gzip	1.28 kB	1.28 kB	✓
_error-e2ffa..0f3f.js gzip	3.46 kB	3.46 kB	✓
hooks-010c20..8411.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-d979103..c5ff.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_buildManifest.js gzip	323 B	323 B	✓
Overall change	323 B	323 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_error.js	1 MB	1 MB	-145 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	-145 B
link.js	1.06 MB	1.06 MB	-145 B
routerDirect.js	1.05 MB	1.05 MB	-145 B
withRouter.js	1.05 MB	1.05 MB	-145 B
Overall change	5.18 MB	5.17 MB	-725 B

Commit: eefc0fe

timneutkens · 2021-01-11T13:54:40Z

packages/next/next-server/lib/post-process.ts

    let timer = Date.now()
    middleware.inspect(root, postProcessData, data)
-    const inspectTime = Date.now() - timer
    document = await middleware.mutate(document, postProcessData, data)
    timer = Date.now() - timer
    if (timer > MIDDLEWARE_TIME_BUDGET) {


This statement doesn't do anything anymore so let's comment it out!

ijjk · 2021-01-11T19:24:23Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
buildDuration	10.2s	10.1s	-80ms
nodeModulesSize	80.8 MB	80.8 MB	-883 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
/ failed reqs	0	0	✓
/ total time (seconds)	2.037	2.004	-0.03
/ avg req/sec	1227.25	1247.33	+20.08
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	1.272	1.292	⚠️ +0.02
/error-in-render avg req/sec	1964.9	1935.23	⚠️ -29.67

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
index.html gzip	615 B	615 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
buildDuration	12.9s	12.2s	-707ms
nodeModulesSize	80.8 MB	80.8 MB	-883 B

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_error.js	1 MB	1 MB	-134 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	-134 B
link.js	1.06 MB	1.06 MB	-134 B
routerDirect.js	1.05 MB	1.05 MB	-134 B
withRouter.js	1.05 MB	1.05 MB	-134 B
Overall change	5.18 MB	5.18 MB	-670 B

Commit: 9bec143

ijjk · 2021-01-13T15:35:05Z

Stats from current PR

Default Server Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
buildDuration	7.8s	8.3s	⚠️ +444ms
nodeModulesSize	80.9 MB	80.9 MB	-883 B

Page Load Tests Overall decrease ⚠️

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
/ failed reqs	0	0	✓
/ total time (seconds)	1.565	1.61	⚠️ +0.05
/ avg req/sec	1597.82	1552.96	⚠️ -44.86
/error-in-render failed reqs	0	0	✓
/error-in-render total time (seconds)	0.98	1.022	⚠️ +0.04
/error-in-render avg req/sec	2550.67	2445.19	⚠️ -105.48

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Rendered Page Sizes

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
index.html gzip	615 B	615 B	✓
link.html gzip	619 B	619 B	✓
withRouter.html gzip	608 B	608 B	✓
Overall change	1.84 kB	1.84 kB	✓

Serverless Mode (Decrease detected ✓)

General Overall decrease ✓

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
buildDuration	9.4s	9.4s	-9ms
nodeModulesSize	80.9 MB	80.8 MB	-10.9 kB

Client Bundles (main, webpack, commons)

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
677f882d2ed8..b025.js gzip	13.1 kB	13.1 kB	✓
framework.HASH.js gzip	39 kB	39 kB	✓
main-e66dcae..6635.js gzip	6.63 kB	6.63 kB	✓
webpack-50be..df5b.js gzip	751 B	751 B	✓
Overall change	59.4 kB	59.4 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
polyfills-81..14d7.js gzip	31.2 kB	31.2 kB	✓
Overall change	31.2 kB	31.2 kB	✓

Client Pages

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_app-2a09aa2..4a98.js gzip	1.28 kB	1.28 kB	✓
_error-8b758..aef6.js gzip	3.46 kB	3.46 kB	✓
hooks-c71ae4..70cd.js gzip	887 B	887 B	✓
index-bbee2f..528b.js gzip	227 B	227 B	✓
link-7faf09b..eba4.js gzip	1.64 kB	1.64 kB	✓
routerDirect..bf84.js gzip	303 B	303 B	✓
withRouter-a..5826.js gzip	302 B	302 B	✓
Overall change	8.09 kB	8.09 kB	✓

Client Build Manifests

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_buildManifest.js gzip	321 B	321 B	✓
Overall change	321 B	321 B	✓

Serverless bundles Overall decrease ✓

	vercel/next.js canary	janicklas-ralph/next.js font-optimization	Change
_error.js	1 MB	1 MB	-134 B
404.html	2.67 kB	2.67 kB	✓
hooks.html	1.92 kB	1.92 kB	✓
index.js	1 MB	1 MB	-134 B
link.js	1.06 MB	1.06 MB	-134 B
routerDirect.js	1.05 MB	1.05 MB	-134 B
withRouter.js	1.05 MB	1.05 MB	-134 B
Overall change	5.18 MB	5.18 MB	-670 B

Commit: ab489fb

janicklas-ralph added 10 commits April 4, 2020 14:36

Updating native-url version

edabb95

Bump version

c147099

Merge branch 'canary' of github.com:zeit/next.js into canary

63b04ca

Merge branch 'canary' of github.com:zeit/next.js into canary

df52e5e

Merge branch 'canary' of github.com:zeit/next.js into canary

1baaf87

Merge branch 'canary' of github.com:zeit/next.js into canary

68bff2a

Merge branch 'canary' of github.com:zeit/next.js into canary

5f3c00a

Merge branch 'canary' of github.com:janicklas-ralph/next.js; branch '…

bceebd3

…canary' of github.com:zeit/next.js into canary

Merge branch 'canary' of github.com:zeit/next.js into canary

b3921d3

Remove warning message from postprocess step

9fd0e72

janicklas-ralph requested review from ijjk, lfades, Timer and timneutkens as code owners January 7, 2021 21:19

ijjk added the type: next label Jan 7, 2021

rgabs previously approved these changes Jan 8, 2021

View reviewed changes

Fix lint

eefc0fe

janicklas-ralph dismissed rgabs’s stale review via eefc0fe January 8, 2021 19:53

timneutkens reviewed Jan 11, 2021

View reviewed changes

janicklas-ralph added 2 commits January 11, 2021 11:11

Merge branch 'canary' of github.com:zeit/next.js into font-optimization

d61f7db

Remove unwanted code

9bec143

janicklas-ralph requested a review from timneutkens January 11, 2021 19:13

timneutkens approved these changes Jan 13, 2021

View reviewed changes

Merge branch 'canary' into font-optimization

ab489fb

kodiakhq bot merged commit e6e402e into vercel:canary Jan 13, 2021

vercel locked as resolved and limited conversation to collaborators Jan 29, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Font optimization - remove warning message #20874

Font optimization - remove warning message #20874

janicklas-ralph commented Jan 7, 2021

ijjk commented Jan 8, 2021

timneutkens Jan 11, 2021

ijjk commented Jan 11, 2021

ijjk commented Jan 13, 2021

Font optimization - remove warning message #20874

Font optimization - remove warning message #20874

Conversation

janicklas-ralph commented Jan 7, 2021

ijjk commented Jan 8, 2021

Stats from current PR

timneutkens Jan 11, 2021

Choose a reason for hiding this comment

ijjk commented Jan 11, 2021

Stats from current PR

ijjk commented Jan 13, 2021

Stats from current PR