Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image cache for vector and animated images #20480

Merged
merged 3 commits into from Jan 13, 2021
Merged

Fix image cache for vector and animated images #20480

merged 3 commits into from Jan 13, 2021

Conversation

kaykdm
Copy link
Contributor

@kaykdm kaykdm commented Dec 26, 2020 •
edited

Fixes: #19100

According to https://nextjs.org/docs/basic-features/image-optimization#caching Next.js populates a cache dir when using the new component. This is not the case when using SVG files. This results in a performance penalty.

I created a function for writing images to cache directory (wrirteToCacheDir) and it is called for all images.
However, vector and animated images are not optimized before writing them to cache dir

Related to #18179

@vercel vercel bot temporarily deployed to Preview December 26, 2020 06:42 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 26, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 10.8s 11s ⚠️ +165ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +678 B
Page Load Tests Overall increase ✓
vercel/next.js canary kaykdm/next.js fix/image-cache Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.34 2.269 -0.07
/ avg req/sec 1068.31 1101.68 +33.37
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.616 1.62 0
/error-in-render avg req/sec 1546.79 1543.32 ⚠️ -3.47
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary kaykdm/next.js fix/image-cache Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 13.1s 12.7s -377ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +678 B
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: db7e514

@vercel vercel bot temporarily deployed to Preview December 26, 2020 06:54 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 26, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 9s 8.9s -167ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +678 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.736 1.789 ⚠️ +0.05
/ avg req/sec 1439.91 1397.57 ⚠️ -42.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.065 1.096 ⚠️ +0.03
/error-in-render avg req/sec 2348.36 2280.24 ⚠️ -68.12
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary kaykdm/next.js fix/image-cache Change
index.html gzip 612 B 612 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 10.4s 10.5s ⚠️ +83ms
nodeModulesSize 82.6 MB 82.6 MB ⚠️ +678 B
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..5e70.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e0d2962..b163.js gzip 6.56 kB 6.56 kB ✓
webpack-95c2..e870.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-d3..23f6.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-0d19cb6..5497.js gzip 1.28 kB 1.28 kB ✓
_error-85785..a9f3.js gzip 3.44 kB 3.44 kB ✓
hooks-42456f..0c06.js gzip 887 B 887 B ✓
index-8081ce..e44f.js gzip 227 B 227 B ✓
link-0ab9f83..fa00.js gzip 1.61 kB 1.61 kB ✓
routerDirect..c3d8.js gzip 303 B 303 B ✓
withRouter-0..a68e.js gzip 302 B 302 B ✓
Overall change 8.05 kB 8.05 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: 56bfaf8

@ijjk
Copy link
Member

ijjk commented Jan 6, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 10.7s 10.5s -192ms
nodeModulesSize 80.6 MB 80.6 MB ⚠️ +678 B
Page Load Tests Overall increase ✓
vercel/next.js canary kaykdm/next.js fix/image-cache Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.09 2.105 ⚠️ +0.02
/ avg req/sec 1196.43 1187.45 ⚠️ -8.98
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.323 1.308 -0.01
/error-in-render avg req/sec 1889.19 1911.53 +22.34
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d74fce9..a1a1.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Rendered Page Sizes
vercel/next.js canary kaykdm/next.js fix/image-cache Change
index.html gzip 614 B 614 B ✓
link.html gzip 620 B 620 B ✓
withRouter.html gzip 607 B 607 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 12.8s 12.5s -334ms
nodeModulesSize 80.6 MB 80.6 MB ⚠️ +678 B
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..396f.js gzip 13 kB 13 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-d74fce9..a1a1.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.3 kB 59.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-b6fc6bc..222c.js gzip 1.28 kB 1.28 kB ✓
_error-e2ffa..0f3f.js gzip 3.46 kB 3.46 kB ✓
hooks-010c20..8411.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-705099c..c35d.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 323 B 323 B ✓
Overall change 323 B 323 B ✓
Serverless bundles
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: 381d787

@ijjk
Copy link
Member

ijjk commented Jan 12, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 10.6s 10.5s -107ms
nodeModulesSize 80.9 MB 80.9 MB ⚠️ +678 B
Page Load Tests Overall increase ✓
vercel/next.js canary kaykdm/next.js fix/image-cache Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.15 2.118 -0.03
/ avg req/sec 1162.89 1180.28 +17.39
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.35 1.303 -0.05
/error-in-render avg req/sec 1852.16 1918.37 +66.21
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary kaykdm/next.js fix/image-cache Change
index.html gzip 615 B 615 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 12.5s 12.3s -127ms
nodeModulesSize 80.9 MB 80.8 MB -9.46 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: a507ee8

@ijjk
Copy link
Member

ijjk commented Jan 12, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 8.9s 8.9s -9ms
nodeModulesSize 80.9 MB 80.9 MB ⚠️ +678 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.777 1.77 -0.01
/ avg req/sec 1407.1 1412.5 +5.4
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.145 1.154 ⚠️ +0.01
/error-in-render avg req/sec 2183.18 2166.05 ⚠️ -17.13
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary kaykdm/next.js fix/image-cache Change
index.html gzip 615 B 615 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 10.6s 10.7s ⚠️ +64ms
nodeModulesSize 80.9 MB 80.9 MB ⚠️ +678 B
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: d9ee338

@ijjk
Copy link
Member

ijjk commented Jan 12, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 10.5s 10.6s ⚠️ +67ms
nodeModulesSize 80.9 MB 80.8 MB -9.46 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.033 2.083 ⚠️ +0.05
/ avg req/sec 1229.5 1200 ⚠️ -29.5
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.27 1.297 ⚠️ +0.03
/error-in-render avg req/sec 1968.73 1927.98 ⚠️ -40.75
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary kaykdm/next.js fix/image-cache Change
index.html gzip 615 B 615 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 12.2s 12.3s ⚠️ +172ms
nodeModulesSize 80.8 MB 80.9 MB ⚠️ +10.7 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 2ab20ce

styfle
styfle approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@styfle styfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

timneutkens
timneutkens approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on @styfle's approval for auto-merge

@ijjk
Copy link
Member

ijjk commented Jan 13, 2021

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 8.6s 8.6s -84ms
nodeModulesSize 80.9 MB 80.9 MB ⚠️ +678 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.731 1.759 ⚠️ +0.03
/ avg req/sec 1443.96 1421.64 ⚠️ -22.32
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.068 1.067 0
/error-in-render avg req/sec 2339.98 2343.46 +3.48
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary kaykdm/next.js fix/image-cache Change
index.html gzip 615 B 615 B ✓
link.html gzip 619 B 619 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary kaykdm/next.js fix/image-cache Change
buildDuration 10.4s 10.3s -54ms
nodeModulesSize 80.9 MB 80.9 MB ⚠️ +678 B
Client Bundles (main, webpack, commons)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
677f882d2ed8..b025.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e66dcae..6635.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary kaykdm/next.js fix/image-cache Change
polyfills-81..14d7.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary kaykdm/next.js fix/image-cache Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Commit: 75e9305

@kodiakhq kodiakhq bot merged commit e1184fb into vercel:canary Jan 13, 2021
@kaykdm kaykdm deleted the fix/image-cache branch January 15, 2021 01:10
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@styfle styfle styfle approved these changes

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cache folder isn't created when using (Image Component) + SVG images
4 participants
@kaykdm @ijjk @styfle @timneutkens