Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix splitting page path by buildId #19901

Merged
merged 4 commits into from Jan 19, 2021
Merged

Fix splitting page path by buildId #19901

merged 4 commits into from Jan 19, 2021

Conversation

berndartmueller
Copy link
Contributor

@berndartmueller berndartmueller commented Dec 6, 2020 •
edited by ijjk

Running next.js in development causes issues when having pages named "development" or "developments",... as this.buildId = development

Fixes: #19520

@ijjk ijjk added the type: next label Dec 6, 2020
@vercel vercel bot temporarily deployed to Preview December 6, 2020 15:17 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 6, 2020

Stats from current PR

Default Server Mode
General Overall increase ⚠️
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
buildDuration 8.7s 8.6s -123ms
nodeModulesSize 82.5 MB 82.5 MB ⚠️ +202 B
Page Load Tests Overall increase ✓
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.06 2.094 ⚠️ +0.03
/ avg req/sec 1213.8 1194.05 ⚠️ -19.75
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.114 1.104 -0.01
/error-in-render avg req/sec 2244.55 2265.03 +20.48
Client Bundles (main, webpack, commons)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f501b4a..c42e.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.27 kB 8.27 kB ✓
Client Build Manifests
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Rendered Page Sizes
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
buildDuration 10.2s 10.2s ⚠️ +1ms
nodeModulesSize 82.5 MB 82.5 MB ⚠️ +202 B
Client Bundles (main, webpack, commons)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
677f882d2ed8..34b9.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f501b4a..c42e.js gzip 6.56 kB 6.56 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 59 kB 59 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_app-7231d4b..5856.js gzip 1.28 kB 1.28 kB ✓
_error-01375..90b6.js gzip 3.69 kB 3.69 kB ✓
hooks-d4591d..e7c2.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-db223d9..dbd7.js gzip 1.61 kB 1.61 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 8.27 kB 8.27 kB ✓
Client Build Manifests
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_buildManifest.js gzip 322 B 322 B ✓
Overall change 322 B 322 B ✓
Serverless bundles
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.16 MB 5.16 MB ✓
Commit: b97af95

@vercel vercel bot temporarily deployed to Preview December 30, 2020 17:23 Inactive
@ijjk
Copy link
Member

ijjk commented Dec 30, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
buildDuration 9.9s 10.1s ⚠️ +196ms
nodeModulesSize 83 MB 83 MB ⚠️ +201 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.947 2.005 ⚠️ +0.06
/ avg req/sec 1284.15 1247.01 ⚠️ -37.14
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.226 1.26 ⚠️ +0.03
/error-in-render avg req/sec 2038.68 1984.14 ⚠️ -54.54
Client Bundles (main, webpack, commons)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
677f882d2ed8..769b.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a6ce971..96b9.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-21c7af4..bddc.js gzip 1.6 kB 1.6 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.04 kB 8.04 kB ✓
Client Build Manifests
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_buildManifest.js gzip 320 B 320 B ✓
Overall change 320 B 320 B ✓
Rendered Page Sizes
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
index.html gzip 616 B 616 B ✓
link.html gzip 622 B 622 B ✓
withRouter.html gzip 609 B 609 B ✓
Overall change 1.85 kB 1.85 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
buildDuration 12s 12.2s ⚠️ +188ms
nodeModulesSize 83 MB 83 MB ⚠️ +201 B
Client Bundles (main, webpack, commons)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
677f882d2ed8..769b.js gzip 12.8 kB 12.8 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a6ce971..96b9.js gzip 6.59 kB 6.59 kB ✓
webpack-7193..1446.js gzip 751 B 751 B ✓
Overall change 59.1 kB 59.1 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
polyfills-67..b7d1.js gzip 31.2 kB 31.2 kB ✓
Overall change 31.2 kB 31.2 kB ✓
Client Pages
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_app-6220e08..9a40.js gzip 1.28 kB 1.28 kB ✓
_error-4b0b5..2c91.js gzip 3.44 kB 3.44 kB ✓
hooks-5f309a..7282.js gzip 887 B 887 B ✓
index-57f580..c562.js gzip 227 B 227 B ✓
link-21c7af4..bddc.js gzip 1.6 kB 1.6 kB ✓
routerDirect..bd82.js gzip 303 B 303 B ✓
withRouter-2..e384.js gzip 302 B 302 B ✓
Overall change 8.04 kB 8.04 kB ✓
Client Build Manifests
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_buildManifest.js gzip 320 B 320 B ✓
Overall change 320 B 320 B ✓
Serverless bundles
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.17 MB 5.17 MB ✓
Commit: fca8c96

@Timer Timer added this to the iteration 16 milestone Jan 4, 2021
ijjk
ijjk approved these changes Jan 19, 2021
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good to me, I went ahead and added a test to prevent regressing. Thanks for the PR!

@ijjk
Copy link
Member

ijjk commented Jan 19, 2021

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
buildDuration 9s 8.9s -47ms
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +201 B
Page Load Tests Overall increase ✓
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.75 1.744 -0.01
/ avg req/sec 1428.36 1433.85 +5.49
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.161 1.129 -0.03
/error-in-render avg req/sec 2153.5 2214.02 +60.52
Client Bundles (main, webpack, commons)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Rendered Page Sizes
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
index.html gzip 614 B 614 B ✓
link.html gzip 621 B 621 B ✓
withRouter.html gzip 608 B 608 B ✓
Overall change 1.84 kB 1.84 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
buildDuration 10.7s 11s ⚠️ +229ms
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +201 B
Client Bundles (main, webpack, commons)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
677f882d2ed8..43e3.js gzip 13.1 kB 13.1 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-9e3e4e6..2023.js gzip 6.63 kB 6.63 kB ✓
webpack-50be..df5b.js gzip 751 B 751 B ✓
Overall change 59.4 kB 59.4 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
polyfills-af..9390.js gzip 31.3 kB 31.3 kB ✓
Overall change 31.3 kB 31.3 kB ✓
Client Pages
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_app-2a09aa2..4a98.js gzip 1.28 kB 1.28 kB ✓
_error-8b758..aef6.js gzip 3.46 kB 3.46 kB ✓
hooks-c71ae4..70cd.js gzip 887 B 887 B ✓
index-bbee2f..528b.js gzip 227 B 227 B ✓
link-7faf09b..eba4.js gzip 1.64 kB 1.64 kB ✓
routerDirect..bf84.js gzip 303 B 303 B ✓
withRouter-a..5826.js gzip 302 B 302 B ✓
Overall change 8.09 kB 8.09 kB ✓
Client Build Manifests
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_buildManifest.js gzip 321 B 321 B ✓
Overall change 321 B 321 B ✓
Serverless bundles
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_error.js 1 MB 1 MB ✓
404.html 2.67 kB 2.67 kB ✓
hooks.html 1.92 kB 1.92 kB ✓
index.js 1 MB 1 MB ✓
link.js 1.06 MB 1.06 MB ✓
routerDirect.js 1.05 MB 1.05 MB ✓
withRouter.js 1.05 MB 1.05 MB ✓
Overall change 5.18 MB 5.18 MB ✓
Webpack 5 Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
buildDuration 11.5s 11.2s -270ms
nodeModulesSize 77.6 MB 77.6 MB ⚠️ +201 B
Page Load Tests Overall increase ✓
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.772 1.773 0
/ avg req/sec 1410.49 1410.39 ⚠️ -0.1
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.181 1.145 -0.04
/error-in-render avg req/sec 2116.35 2182.98 +66.63
Client Bundles (main, webpack, commons)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
597-3bd7d6bd..868b.js gzip 13 kB 13 kB ✓
778-d412f8e7..3ee1.js gzip 6.56 kB 6.56 kB ✓
838-adcbad39..6e83.js gzip 31.1 kB 31.1 kB ✓
framework.HASH.js gzip 39.3 kB 39.3 kB ✓
main-6a6a792..6877.js gzip 96 B 96 B ✓
webpack-e302..54e9.js gzip 954 B 954 B ✓
Overall change 91 kB 91 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
polyfills-a0..538c.js gzip 88 B 88 B ✓
Overall change 88 B 88 B ✓
Client Pages
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_app-a5b2e84..33cf.js gzip 1.26 kB 1.26 kB ✓
_error-6f1f9..5577.js gzip 3.38 kB 3.38 kB ✓
hooks-725de8..0a15.js gzip 904 B 904 B ✓
index-939503..6e1c.js gzip 232 B 232 B ✓
link-e0cc871..fdbb.js gzip 1.63 kB 1.63 kB ✓
routerDirect..9360.js gzip 308 B 308 B ✓
withRouter-6..44ec.js gzip 304 B 304 B ✓
Overall change 8.02 kB 8.02 kB ✓
Client Build Manifests
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
_buildManifest.js gzip 299 B 299 B ✓
Overall change 299 B 299 B ✓
Rendered Page Sizes
vercel/next.js canary berndartmueller/next.js fix-path-splitting Change
index.html gzip 585 B 585 B ✓
link.html gzip 592 B 592 B ✓
withRouter.html gzip 581 B 581 B ✓
Overall change 1.76 kB 1.76 kB ✓

Diffs

Diff for index.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/",
         "query": {},
-        "buildId": "ny87fgqkrj-OWJyJfB5QC",
+        "buildId": "UfWky6XlUJo2VRkpDds5a",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ny87fgqkrj-OWJyJfB5QC/_buildManifest.js"
+      src="/_next/static/UfWky6XlUJo2VRkpDds5a/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ny87fgqkrj-OWJyJfB5QC/_ssgManifest.js"
+      src="/_next/static/UfWky6XlUJo2VRkpDds5a/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for link.html 
@@ -48,7 +48,7 @@
         "props": { "pageProps": {} },
         "page": "/link",
         "query": {},
-        "buildId": "ny87fgqkrj-OWJyJfB5QC",
+        "buildId": "UfWky6XlUJo2VRkpDds5a",
         "isFallback": false,
         "gip": true
       }
@@ -82,11 +82,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ny87fgqkrj-OWJyJfB5QC/_buildManifest.js"
+      src="/_next/static/UfWky6XlUJo2VRkpDds5a/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ny87fgqkrj-OWJyJfB5QC/_ssgManifest.js"
+      src="/_next/static/UfWky6XlUJo2VRkpDds5a/_ssgManifest.js"
       async=""
     ></script>
   </body>
Diff for withRouter.html 
@@ -43,7 +43,7 @@
         "props": { "pageProps": {} },
         "page": "/withRouter",
         "query": {},
-        "buildId": "ny87fgqkrj-OWJyJfB5QC",
+        "buildId": "UfWky6XlUJo2VRkpDds5a",
         "isFallback": false,
         "gip": true
       }
@@ -77,11 +77,11 @@
       async=""
     ></script>
     <script
-      src="/_next/static/ny87fgqkrj-OWJyJfB5QC/_buildManifest.js"
+      src="/_next/static/UfWky6XlUJo2VRkpDds5a/_buildManifest.js"
       async=""
     ></script>
     <script
-      src="/_next/static/ny87fgqkrj-OWJyJfB5QC/_ssgManifest.js"
+      src="/_next/static/UfWky6XlUJo2VRkpDds5a/_ssgManifest.js"
       async=""
     ></script>
   </body>
Commit: 74c18d9

@kodiakhq kodiakhq bot merged commit 72ce099 into vercel:canary Jan 19, 2021
@berndartmueller berndartmueller deleted the fix-path-splitting branch January 19, 2021 18:31
@ijjk ijjk mentioned this pull request Jan 22, 2021
Closed
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
iteration 16
Development

Successfully merging this pull request may close these issues.

Page with url /developments causes issues with stripNextDataPath()
3 participants
@berndartmueller @ijjk @Timer