Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to generate auto static pages with all locales #17730

Merged
merged 2 commits into from Oct 9, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 8, 2020

Follow-up PR to #17370 this adds generating auto-export, non-dynamic SSG, and fallback pages with all locales. Dynamic SSG pages still control which locales the pages are generated with using getStaticPaths. To further control which locales non-dynamic SSG pages will be prerendered with a follow-up PR adding handling for 404 behavior from getStaticProps will be needed.

x-ref: #17110

@ijjk ijjk added the type: next label Oct 8, 2020
@ijjk
Copy link
Member Author

ijjk commented Oct 8, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
buildDuration 13.5s 14.1s ⚠️ +640ms
nodeModulesSize 63.4 MB 63.4 MB ⚠️ +9.32 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
/ failed reqs 0 0
/ total time (seconds) 2.714 2.824 ⚠️ +0.11
/ avg req/sec 921.11 885.2 ⚠️ -35.91
/error-in-render failed reqs 0 0
/error-in-render total time (seconds) 1.969 1.825 -0.14
/error-in-render avg req/sec 1269.85 1370.22 +100.37
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
677f882d2ed8..9b19.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-ef5fcfe..d66c.js gzip 7.24 kB 7.24 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58 kB 58 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
677f882d2ed8..dule.js gzip 6.9 kB 6.9 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-1c7f28c..dule.js gzip 6.29 kB 6.29 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.73 kB 7.73 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-92d3016..dule.js gzip 1.28 kB 1.28 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Rendered Page Sizes
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
index.html gzip 1 kB 1 kB
link.html gzip 1.01 kB 1.01 kB
withRouter.html gzip 995 B 995 B
Overall change 3.01 kB 3.01 kB

Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
buildDuration 14.7s 15s ⚠️ +358ms
nodeModulesSize 63.4 MB 63.4 MB ⚠️ +9.32 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
677f882d2ed8..9b19.js gzip 11.1 kB 11.1 kB
framework.HASH.js gzip 39 kB 39 kB
main-ef5fcfe..d66c.js gzip 7.24 kB 7.24 kB
webpack-e067..f178.js gzip 751 B 751 B
Overall change 58 kB 58 kB
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
677f882d2ed8..dule.js gzip 6.9 kB 6.9 kB
framework.HA..dule.js gzip 39 kB 39 kB
main-1c7f28c..dule.js gzip 6.29 kB 6.29 kB
webpack-07c5..dule.js gzip 751 B 751 B
Overall change 52.9 kB 52.9 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
polyfills-4b..e242.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB
hooks-89731c..c609.js gzip 887 B 887 B
index-17468f..5d83.js gzip 227 B 227 B
link-409b283..e3ab.js gzip 1.32 kB 1.32 kB
routerDirect..924c.js gzip 284 B 284 B
withRouter-7..c13d.js gzip 284 B 284 B
Overall change 7.73 kB 7.73 kB
Client Pages Modern
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
_app-75d3a82..dule.js gzip 625 B 625 B
_error-4469a..dule.js gzip 2.29 kB 2.29 kB
hooks-cbf13f..dule.js gzip 387 B 387 B
index-b9a643..dule.js gzip 226 B 226 B
link-92d3016..dule.js gzip 1.28 kB 1.28 kB
routerDirect..dule.js gzip 284 B 284 B
withRouter-f..dule.js gzip 282 B 282 B
Overall change 5.37 kB 5.37 kB
Client Build Manifests
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
_buildManifest.js gzip 323 B 323 B
_buildManife..dule.js gzip 329 B 329 B
Overall change 652 B 652 B
Serverless bundles Overall decrease ✓
vercel/next.js canary ijjk/next.js i18n/generate-all-locales Change
_error.js 1.05 MB 1.05 MB -113 B
404.html 4.34 kB 4.34 kB
hooks.html 3.92 kB 3.92 kB
index.js 1.05 MB 1.05 MB -113 B
link.js 1.1 MB 1.1 MB -113 B
routerDirect.js 1.09 MB 1.09 MB -113 B
withRouter.js 1.09 MB 1.09 MB -113 B
Overall change 5.41 MB 5.41 MB -565 B
Commit: da9b32f

@ijjk ijjk marked this pull request as ready for review October 9, 2020 00:19
@kodiakhq kodiakhq bot merged commit 2170dfd into vercel:canary Oct 9, 2020
@ijjk ijjk deleted the i18n/generate-all-locales branch October 9, 2020 15:02
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants