Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix with-apollo example #17686

Merged
merged 2 commits into from Oct 8, 2020
Merged

Fix with-apollo example #17686

merged 2 commits into from Oct 8, 2020

Conversation

HaNdTriX
Copy link
Contributor

@HaNdTriX HaNdTriX commented Oct 7, 2020

Issue

The cache updates are performed in a wrong way, resulting in a duplicate collection:

Error:

webpack-internal:///./node_modules/react-dom/cjs/react-dom.development.js:88 Warning: Encountered two children with the same key, `6f3f7265-0d97-4708-a3ea-7dee76dc0a0a`. Keys should be unique so that components maintain their identity across updates. Non-unique keys may cause children to be duplicated and/or omitted — the behavior is unsupported and could change in a future version.

Video:

broken

Fix

Video:

fixed

@ijjk ijjk added the example bug Issue was opened via the example bug report template. label Oct 7, 2020
@ijjk
Copy link
Member

ijjk commented Oct 7, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
buildDuration 11.2s 11.5s ⚠️ +296ms
nodeModulesSize 63.2 MB 63.2 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.136 2.085 -0.05
/ avg req/sec 1170.55 1198.83 +28.28
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.207 1.282 ⚠️ +0.07
/error-in-render avg req/sec 2070.59 1950.09 ⚠️ -120.5
Client Bundles (main, webpack, commons)
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e5f5aee..31e1.js gzip 7.17 kB 7.17 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.8 kB 57.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-ff4dea7..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 996 B 996 B ✓
Overall change 3.01 kB 3.01 kB ✓
Serverless Mode
General
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
buildDuration 12.4s 12.6s ⚠️ +248ms
nodeModulesSize 63.2 MB 63.2 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
677f882d2ed8..9339.js gzip 10.9 kB 10.9 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-e5f5aee..31e1.js gzip 7.17 kB 7.17 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.8 kB 57.8 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
677f882d2ed8..dule.js gzip 6.77 kB 6.77 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-ff4dea7..dule.js gzip 6.24 kB 6.24 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.7 kB 52.7 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_error.js 1.05 MB 1.05 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.05 MB 1.05 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.09 MB 1.09 MB ✓
withRouter.js 1.09 MB 1.09 MB ✓
Overall change 5.4 MB 5.4 MB ✓
Commit: 26f4817

lfades
lfades approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@lfades lfades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HaNdTriX Thank you!

@ijjk
Copy link
Member

ijjk commented Oct 8, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
buildDuration 14.3s 14.3s ⚠️ +55ms
nodeModulesSize 63.4 MB 63.4 MB ✓
Page Load Tests Overall increase ✓
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.66 2.633 -0.03
/ avg req/sec 939.95 949.47 +9.52
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.713 1.643 -0.07
/error-in-render avg req/sec 1459.29 1522.02 +62.73
Client Bundles (main, webpack, commons)
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
677f882d2ed8..977d.js gzip 11 kB 11 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6f0de25..2754.js gzip 7.21 kB 7.21 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58 kB 58 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
677f882d2ed8..dule.js gzip 6.87 kB 6.87 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9ee6725..dule.js gzip 6.27 kB 6.27 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-537beac..0f9a.js gzip 1.32 kB 1.32 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-02f45f5..dule.js gzip 1.28 kB 1.28 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 653 B 653 B ✓
Rendered Page Sizes
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
index.html gzip 1 kB 1 kB ✓
link.html gzip 1.01 kB 1.01 kB ✓
withRouter.html gzip 994 B 994 B ✓
Overall change 3 kB 3 kB ✓
Serverless Mode
General
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
buildDuration 15.7s 16.1s ⚠️ +357ms
nodeModulesSize 63.4 MB 63.4 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
677f882d2ed8..977d.js gzip 11 kB 11 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-6f0de25..2754.js gzip 7.21 kB 7.21 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 58 kB 58 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
677f882d2ed8..dule.js gzip 6.87 kB 6.87 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9ee6725..dule.js gzip 6.27 kB 6.27 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.9 kB 52.9 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-537beac..0f9a.js gzip 1.32 kB 1.32 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.72 kB 7.72 kB ✓
Client Pages Modern
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-02f45f5..dule.js gzip 1.28 kB 1.28 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 653 B 653 B ✓
Serverless bundles
vercel/next.js canary HaNdTriX/next.js examples/apollo-client Change
_error.js 1.05 MB 1.05 MB ✓
404.html 4.34 kB 4.34 kB ✓
hooks.html 3.92 kB 3.92 kB ✓
index.js 1.05 MB 1.05 MB ✓
link.js 1.1 MB 1.1 MB ✓
routerDirect.js 1.09 MB 1.09 MB ✓
withRouter.js 1.09 MB 1.09 MB ✓
Overall change 5.41 MB 5.41 MB ✓
Commit: 2789cd4

@kodiakhq kodiakhq bot merged commit a79bcfb into vercel:canary Oct 8, 2020
@HaNdTriX HaNdTriX deleted the examples/apollo-client branch October 8, 2020 10:05
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@chibicode chibicode Awaiting requested review from chibicode

@ijjk ijjk Awaiting requested review from ijjk

@Timer Timer Awaiting requested review from Timer

@timneutkens timneutkens Awaiting requested review from timneutkens

Assignees
No one assigned
Labels
example bug Issue was opened via the example bug report template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HaNdTriX @ijjk @lfades