Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to show build indicator while re-fetching GS(S)P data in dev #16789

Merged
merged 3 commits into from Sep 3, 2020
Merged

Update to show build indicator while re-fetching GS(S)P data in dev #16789

merged 3 commits into from Sep 3, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Sep 2, 2020 •
edited

This is a follow-up to #16744 which shows the build/activity indicator while the data is being re-fetched to let the user know the re-fetching is occurring

Closes: #16790

@ijjk ijjk added the type: next label Sep 2, 2020
@ijjk
Copy link
Member Author

ijjk commented Sep 2, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
buildDuration 12.5s 12.7s ⚠️ +249ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +1.1 kB
Page Load Tests Overall increase ✓
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.243 2.245 0
/ avg req/sec 1114.74 1113.4 ⚠️ -1.34
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.254 1.246 -0.01
/error-in-render avg req/sec 1993.47 2006.2 +12.73
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
677f882d2ed8..01b7.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f69b135..640b.js gzip 7.1 kB 7.1 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
677f882d2ed8..dule.js gzip 6.39 kB 6.39 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-ed2fed0..dule.js gzip 6.16 kB 6.16 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
index.html gzip 972 B 972 B ✓
link.html gzip 978 B 978 B ✓
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
buildDuration 14.3s 14.3s ⚠️ +31ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +1.1 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
677f882d2ed8..01b7.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f69b135..640b.js gzip 7.1 kB 7.1 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
677f882d2ed8..dule.js gzip 6.39 kB 6.39 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-ed2fed0..dule.js gzip 6.16 kB 6.16 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.29 MB 5.29 MB ✓
Commit: 533f6e5

@ijjk
Copy link
Member Author

ijjk commented Sep 3, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
buildDuration 13.3s 13.2s -174ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +1.1 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.435 2.432 0
/ avg req/sec 1026.84 1027.77 +0.93
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.263 1.363 ⚠️ +0.1
/error-in-render avg req/sec 1979.35 1834.72 ⚠️ -144.63
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
677f882d2ed8..01b7.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f69b135..640b.js gzip 7.1 kB 7.1 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
677f882d2ed8..dule.js gzip 6.39 kB 6.39 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-ed2fed0..dule.js gzip 6.16 kB 6.16 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
index.html gzip 972 B 972 B ✓
link.html gzip 978 B 978 B ✓
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.91 kB ✓
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
buildDuration 15.2s 15s -171ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +1.1 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
677f882d2ed8..01b7.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-f69b135..640b.js gzip 7.1 kB 7.1 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
677f882d2ed8..dule.js gzip 6.39 kB 6.39 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-ed2fed0..dule.js gzip 6.16 kB 6.16 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-d2344ce..8b36.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-f8c0daf..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js add/data-reloading-indicator Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.08 MB 1.08 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.29 MB 5.29 MB ✓
Commit: 897146f

@kodiakhq kodiakhq bot merged commit 8426f13 into vercel:canary Sep 3, 2020
@ijjk ijjk deleted the add/data-reloading-indicator branch September 3, 2020 15:53
HitoriSensei pushed a commit to HitoriSensei/next.js that referenced this pull request Sep 26, 2020
@ijjk
Update to show build indicator while re-fetching GS(S)P data in dev (v…
77445a6 
…ercel#16789)

This is a follow-up to vercel#16744 which shows the build/activity indicator while the data is being re-fetched to let the user know the re-fetching is occurring 

Closes: vercel#16790
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show the build/activity indicator while re-fetching data for GS(S)P being edited
2 participants
@ijjk @timneutkens