Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Update hydration marker for React 17 #16756

Merged
merged 3 commits into from
Sep 1, 2020
Merged

[test] Update hydration marker for React 17 #16756

merged 3 commits into from
Sep 1, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Sep 1, 2020

No description provided.

@ijjk ijjk added the type: next label Sep 1, 2020
@ijjk
Copy link
Member

ijjk commented Sep 1, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js update/hydration-marker Change
buildDuration 13.9s 13.9s ⚠️ +34ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +255 B
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js update/hydration-marker Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.636 2.55 -0.09
/ avg req/sec 948.4 980.39 +31.99
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.562 1.49 -0.07
/error-in-render avg req/sec 1600.28 1677.35 +77.07
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js update/hydration-marker Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2db3d72..5955.js gzip 7.35 kB 7.35 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js update/hydration-marker Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-d7fe688..dule.js gzip 6.41 kB 6.41 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js update/hydration-marker Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js update/hydration-marker Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js update/hydration-marker Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js update/hydration-marker Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary Timer/next.js update/hydration-marker Change
index.html gzip 971 B 970 B -1 B
link.html gzip 976 B 976 B ✓
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.91 kB -1 B

Diffs

Diff for main-6cc705e..576d0db62.js 
@@ -415,14 +415,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
                   }
                 );
               }
-
-              if (undefined) {
-                window.__NEXT_HYDRATED = true;
-
-                if (window.__NEXT_HYDRATED_CB) {
-                  window.__NEXT_HYDRATED_CB();
-                }
-              }
             }
           },
           {
@@ -1098,6 +1090,17 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
           [callback]
         );
 
+        if (undefined) {
+          // eslint-disable-next-line react-hooks/rules-of-hooks
+          _react["default"].useEffect(function() {
+            window.__NEXT_HYDRATED = true;
+
+            if (window.__NEXT_HYDRATED_CB) {
+              window.__NEXT_HYDRATED_CB();
+            }
+          }, []);
+        }
+
         return children;
       }
Diff for main-a39fd86..30.module.js 
@@ -309,14 +309,6 @@
               }
             );
           }
-
-          if (undefined) {
-            window.__NEXT_HYDRATED = true;
-
-            if (window.__NEXT_HYDRATED_CB) {
-              window.__NEXT_HYDRATED_CB();
-            }
-          }
         }
 
         componentDidUpdate() {
@@ -820,6 +812,17 @@
         // as soon as React flushes the update.
         _react.default.useLayoutEffect(() => callback(), [callback]);
 
+        if (undefined) {
+          // eslint-disable-next-line react-hooks/rules-of-hooks
+          _react.default.useEffect(() => {
+            window.__NEXT_HYDRATED = true;
+
+            if (window.__NEXT_HYDRATED_CB) {
+              window.__NEXT_HYDRATED_CB();
+            }
+          }, []);
+        }
+
         return children;
       }
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-6cc705ea661576d0db62.js"
+      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-6cc705ea661576d0db62.js"
+      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-6cc705ea661576d0db62.js"
+      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js update/hydration-marker Change
buildDuration 16.6s 17.1s ⚠️ +449ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +255 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js update/hydration-marker Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2db3d72..5955.js gzip 7.35 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-cc92da0..0b67.js gzip N/A 7.35 kB N/A
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js update/hydration-marker Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-d7fe688..dule.js gzip 6.41 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-0ed168f..dule.js gzip N/A 6.41 kB N/A
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js update/hydration-marker Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js update/hydration-marker Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js update/hydration-marker Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js update/hydration-marker Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js update/hydration-marker Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: dace9bc

@Timer Timer marked this pull request as ready for review September 1, 2020 17:03
@ijjk
Copy link
Member

ijjk commented Sep 1, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js update/hydration-marker Change
buildDuration 12.9s 13.1s ⚠️ +234ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +255 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js update/hydration-marker Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.291 2.243 -0.05
/ avg req/sec 1091.13 1114.74 +23.61
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.211 1.247 ⚠️ +0.04
/error-in-render avg req/sec 2064.87 2004.56 ⚠️ -60.31
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js update/hydration-marker Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2db3d72..5955.js gzip 7.35 kB 7.35 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js update/hydration-marker Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-d7fe688..dule.js gzip 6.41 kB 6.41 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js update/hydration-marker Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js update/hydration-marker Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js update/hydration-marker Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js update/hydration-marker Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary Timer/next.js update/hydration-marker Change
index.html gzip 971 B 970 B -1 B
link.html gzip 976 B 976 B ✓
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.91 kB -1 B

Diffs

Diff for main-6cc705e..576d0db62.js 
@@ -415,14 +415,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
                   }
                 );
               }
-
-              if (undefined) {
-                window.__NEXT_HYDRATED = true;
-
-                if (window.__NEXT_HYDRATED_CB) {
-                  window.__NEXT_HYDRATED_CB();
-                }
-              }
             }
           },
           {
@@ -1098,6 +1090,17 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
           [callback]
         );
 
+        if (undefined) {
+          // eslint-disable-next-line react-hooks/rules-of-hooks
+          _react["default"].useEffect(function() {
+            window.__NEXT_HYDRATED = true;
+
+            if (window.__NEXT_HYDRATED_CB) {
+              window.__NEXT_HYDRATED_CB();
+            }
+          }, []);
+        }
+
         return children;
       }
Diff for main-a39fd86..30.module.js 
@@ -309,14 +309,6 @@
               }
             );
           }
-
-          if (undefined) {
-            window.__NEXT_HYDRATED = true;
-
-            if (window.__NEXT_HYDRATED_CB) {
-              window.__NEXT_HYDRATED_CB();
-            }
-          }
         }
 
         componentDidUpdate() {
@@ -820,6 +812,17 @@
         // as soon as React flushes the update.
         _react.default.useLayoutEffect(() => callback(), [callback]);
 
+        if (undefined) {
+          // eslint-disable-next-line react-hooks/rules-of-hooks
+          _react.default.useEffect(() => {
+            window.__NEXT_HYDRATED = true;
+
+            if (window.__NEXT_HYDRATED_CB) {
+              window.__NEXT_HYDRATED_CB();
+            }
+          }, []);
+        }
+
         return children;
       }
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-6cc705ea661576d0db62.js"
+      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-6cc705ea661576d0db62.js"
+      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-6cc705ea661576d0db62.js"
+      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js update/hydration-marker Change
buildDuration 14.1s 14.3s ⚠️ +179ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +255 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js update/hydration-marker Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2db3d72..5955.js gzip 7.35 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-cc92da0..0b67.js gzip N/A 7.35 kB N/A
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js update/hydration-marker Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-d7fe688..dule.js gzip 6.41 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-0ed168f..dule.js gzip N/A 6.41 kB N/A
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js update/hydration-marker Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js update/hydration-marker Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js update/hydration-marker Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js update/hydration-marker Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js update/hydration-marker Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 6f1d9cc

@ijjk
Copy link
Member

ijjk commented Sep 1, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js update/hydration-marker Change
buildDuration 13s 13s -73ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +255 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js update/hydration-marker Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.301 2.299 0
/ avg req/sec 1086.38 1087.59 +1.21
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.26 1.274 ⚠️ +0.01
/error-in-render avg req/sec 1984.1 1961.76 ⚠️ -22.34
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js update/hydration-marker Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2db3d72..5955.js gzip 7.35 kB 7.35 kB ✓
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js update/hydration-marker Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-d7fe688..dule.js gzip 6.41 kB 6.41 kB ✓
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js update/hydration-marker Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js update/hydration-marker Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js update/hydration-marker Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js update/hydration-marker Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary Timer/next.js update/hydration-marker Change
index.html gzip 971 B 970 B -1 B
link.html gzip 976 B 976 B ✓
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.91 kB -1 B

Diffs

Diff for main-6cc705e..576d0db62.js 
@@ -415,14 +415,6 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
                   }
                 );
               }
-
-              if (undefined) {
-                window.__NEXT_HYDRATED = true;
-
-                if (window.__NEXT_HYDRATED_CB) {
-                  window.__NEXT_HYDRATED_CB();
-                }
-              }
             }
           },
           {
@@ -1098,6 +1090,17 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
           [callback]
         );
 
+        if (undefined) {
+          // eslint-disable-next-line react-hooks/rules-of-hooks
+          _react["default"].useEffect(function() {
+            window.__NEXT_HYDRATED = true;
+
+            if (window.__NEXT_HYDRATED_CB) {
+              window.__NEXT_HYDRATED_CB();
+            }
+          }, []);
+        }
+
         return children;
       }
Diff for main-a39fd86..30.module.js 
@@ -309,14 +309,6 @@
               }
             );
           }
-
-          if (undefined) {
-            window.__NEXT_HYDRATED = true;
-
-            if (window.__NEXT_HYDRATED_CB) {
-              window.__NEXT_HYDRATED_CB();
-            }
-          }
         }
 
         componentDidUpdate() {
@@ -820,6 +812,17 @@
         // as soon as React flushes the update.
         _react.default.useLayoutEffect(() => callback(), [callback]);
 
+        if (undefined) {
+          // eslint-disable-next-line react-hooks/rules-of-hooks
+          _react.default.useEffect(() => {
+            window.__NEXT_HYDRATED = true;
+
+            if (window.__NEXT_HYDRATED_CB) {
+              window.__NEXT_HYDRATED_CB();
+            }
+          }, []);
+        }
+
         return children;
       }
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-6cc705ea661576d0db62.js"
+      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-6cc705ea661576d0db62.js"
+      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      href="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-6cc705ea661576d0db62.js"
+      src="/_next/static/chunks/main-4b573dcf7e6f6f186bef.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-a39fd861b7ee0e4c0e30.module.js"
+      src="/_next/static/chunks/main-0ed0039a9b022173a5df.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode
General Overall increase ⚠️
vercel/next.js canary Timer/next.js update/hydration-marker Change
buildDuration 15.1s 14.7s -408ms
nodeModulesSize 55.9 MB 55.9 MB ⚠️ +255 B
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js update/hydration-marker Change
677f882d2ed8..9ff9.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-2db3d72..5955.js gzip 7.35 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-cc92da0..0b67.js gzip N/A 7.35 kB N/A
Overall change 57.3 kB 57.3 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js update/hydration-marker Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-d7fe688..dule.js gzip 6.41 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-0ed168f..dule.js gzip N/A 6.41 kB N/A
Overall change 52.3 kB 52.3 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js update/hydration-marker Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js update/hydration-marker Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-ed1b0..8fbd.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-ae98065..267e.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js update/hydration-marker Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-4469a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-cb244c4..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js update/hydration-marker Change
_buildManifest.js gzip 323 B 323 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js update/hydration-marker Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 60eaeb5

@kodiakhq kodiakhq bot merged commit 1c45f70 into vercel:canary Sep 1, 2020
@Timer Timer deleted the update/hydration-marker branch September 1, 2020 17:47
ijjk pushed a commit to ijjk/next.js that referenced this pull request Sep 2, 2020
@Timer @ijjk
[test] Update hydration marker for React 17 (vercel#16756)
2e0986f
This was referenced May 25, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Timer @ijjk