Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Promise.prototype.finally is object #16620

Merged
merged 8 commits into from
Aug 30, 2020
Merged

fix: Promise.prototype.finally is object #16620

merged 8 commits into from
Aug 30, 2020

Conversation

tengmaoqing
Copy link
Contributor

The finally-polyfill did not expose any values.
image

@tengmaoqing tengmaoqing changed the title fix: finally-polyfill is object fix: Promise.prototype.finally is object Aug 27, 2020
@ijjk
Copy link
Member

ijjk commented Aug 27, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 13.8s 13.7s -149ms
nodeModulesSize 57.5 MB 57.5 MB -145 B
Page Load Tests Overall increase ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.581 2.6 ⚠️ +0.02
/ avg req/sec 968.8 961.44 ⚠️ -7.36
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.561 1.517 -0.04
/error-in-render avg req/sec 1601.97 1648.08 +46.11
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB 7.35 kB -3 B
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.4 kB 57.4 kB -3 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB 6.42 kB -7 B
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB -7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
index.html gzip 972 B 972 B ✓
link.html gzip 978 B 979 B ⚠️ +1 B
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.92 kB ⚠️ +1 B

Diffs

Diff for main-2954023..10.module.js 
@@ -203,7 +203,7 @@
       /* global location */
 
       if (!("finally" in Promise.prototype)) {
-        Promise.prototype.finally = __webpack_require__("Z577");
+        __webpack_require__("Z577");
       }
 
       var data = JSON.parse(
Diff for main-aa205a8..ee47aba3c.js 
@@ -285,7 +285,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       /* global location */
 
       if (!("finally" in Promise.prototype)) {
-        Promise.prototype["finally"] = __webpack_require__("Z577");
+        __webpack_require__("Z577");
       }
 
       var data = JSON.parse(
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-5903f7988fd9977ec972.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-a80b89be307a8b36fd4f.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-5903f7988fd9977ec972.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-5903f7988fd9977ec972.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-a80b89be307a8b36fd4f.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-5903f7988fd9977ec972.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-5903f7988fd9977ec972.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-a80b89be307a8b36fd4f.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-5903f7988fd9977ec972.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 15.3s 15.4s ⚠️ +74ms
nodeModulesSize 57.5 MB 57.5 MB -145 B
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-cce7499..d9ad.js gzip N/A 7.35 kB N/A
Overall change 57.4 kB 57.4 kB -3 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-4420937..dule.js gzip N/A 6.42 kB N/A
Overall change 52.3 kB 52.3 kB -7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 28c1089

@ijjk
Copy link
Member

ijjk commented Aug 27, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 11s 10.1s -914ms
nodeModulesSize 57.5 MB 57.5 MB -145 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.883 1.865 -0.02
/ avg req/sec 1327.51 1340.24 +12.73
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.056 1.082 ⚠️ +0.03
/error-in-render avg req/sec 2366.34 2309.57 ⚠️ -56.77
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB 7.35 kB -3 B
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.4 kB 57.4 kB -3 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB 6.42 kB -7 B
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB -7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
index.html gzip 972 B 972 B ✓
link.html gzip 978 B 979 B ⚠️ +1 B
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.92 kB ⚠️ +1 B

Diffs

Diff for main-2954023..10.module.js 
@@ -203,7 +203,7 @@
       /* global location */
 
       if (!("finally" in Promise.prototype)) {
-        Promise.prototype.finally = __webpack_require__("Z577");
+        __webpack_require__("Z577");
       }
 
       var data = JSON.parse(
Diff for main-aa205a8..ee47aba3c.js 
@@ -285,7 +285,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       /* global location */
 
       if (!("finally" in Promise.prototype)) {
-        Promise.prototype["finally"] = __webpack_require__("Z577");
+        __webpack_require__("Z577");
       }
 
       var data = JSON.parse(
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-5903f7988fd9977ec972.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-a80b89be307a8b36fd4f.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-5903f7988fd9977ec972.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-5903f7988fd9977ec972.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-a80b89be307a8b36fd4f.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-5903f7988fd9977ec972.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-5903f7988fd9977ec972.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-a80b89be307a8b36fd4f.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-5903f7988fd9977ec972.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 11.1s 11.5s ⚠️ +374ms
nodeModulesSize 57.5 MB 57.5 MB -145 B
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-cce7499..d9ad.js gzip N/A 7.35 kB N/A
Overall change 57.4 kB 57.4 kB -3 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-4420937..dule.js gzip N/A 6.42 kB N/A
Overall change 52.3 kB 52.3 kB -7 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 3ef0422

@ijjk
Copy link
Member

ijjk commented Aug 27, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 12.6s 12.8s ⚠️ +127ms
nodeModulesSize 57.5 MB 57.5 MB -251 B
Page Load Tests Overall increase ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.444 2.39 -0.05
/ avg req/sec 1022.99 1045.83 +22.84
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.48 1.492 ⚠️ +0.01
/error-in-render avg req/sec 1689.61 1676.06 ⚠️ -13.55
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB 7.34 kB -16 B
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.4 kB 57.4 kB -16 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB 6.4 kB -18 B
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.3 kB -18 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
index.html gzip 972 B 971 B -1 B
link.html gzip 978 B 978 B ✓
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.91 kB -1 B

Diffs

Diff for main-2954023..10.module.js 
@@ -202,9 +202,7 @@
       var _router2 = __webpack_require__("nOHt");
       /* global location */
 
-      if (!("finally" in Promise.prototype)) {
-        Promise.prototype.finally = __webpack_require__("Z577");
-      }
+      __webpack_require__("Z577"); /// <reference types="react-dom/experimental" />
 
       var data = JSON.parse(
         document.getElementById("__NEXT_DATA__").textContent
Diff for main-aa205a8..ee47aba3c.js 
@@ -284,9 +284,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       var _router2 = __webpack_require__("nOHt");
       /* global location */
 
-      if (!("finally" in Promise.prototype)) {
-        Promise.prototype["finally"] = __webpack_require__("Z577");
-      }
+      __webpack_require__("Z577"); /// <reference types="react-dom/experimental" />
 
       var data = JSON.parse(
         document.getElementById("__NEXT_DATA__").textContent
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-baecff3f5275b2512f3f.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-9a4dd6772315b661561b.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-baecff3f5275b2512f3f.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-baecff3f5275b2512f3f.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-9a4dd6772315b661561b.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-baecff3f5275b2512f3f.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-baecff3f5275b2512f3f.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-9a4dd6772315b661561b.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-baecff3f5275b2512f3f.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 14.9s 14.5s -434ms
nodeModulesSize 57.5 MB 57.5 MB -251 B
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..7f47.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-d47df98..0462.js gzip N/A 7.34 kB N/A
Overall change 57.4 kB 57.4 kB -16 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.15 kB 6.15 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-c5f0e08..dule.js gzip N/A 6.4 kB N/A
Overall change 52.3 kB 52.3 kB -18 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 65e3d1b

Timer
Timer requested changes Aug 27, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please upgrade us to finally-polyfill@0.2.0 which has the correct conditional check

@tengmaoqing tengmaoqing requested a review from Timer August 28, 2020 07:56
@ijjk
Copy link
Member

ijjk commented Aug 28, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 11.8s 12.5s ⚠️ +689ms
nodeModulesSize 57.5 MB 57.5 MB -276 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.246 2.218 -0.03
/ avg req/sec 1113.14 1127.19 +14.05
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.168 1.212 ⚠️ +0.04
/error-in-render avg req/sec 2140.91 2063.51 ⚠️ -77.4
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB 7.35 kB -10 B
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB -10 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB 6.4 kB -21 B
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.2 kB -21 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
index.html gzip 972 B 971 B -1 B
link.html gzip 978 B 977 B -1 B
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.91 kB -2 B

Diffs

Diff for main-2954023..10.module.js 
@@ -202,9 +202,7 @@
       var _router2 = __webpack_require__("nOHt");
       /* global location */
 
-      if (!("finally" in Promise.prototype)) {
-        Promise.prototype.finally = __webpack_require__("Z577");
-      }
+      __webpack_require__("Z577"); /// <reference types="react-dom/experimental" />
 
       var data = JSON.parse(
         document.getElementById("__NEXT_DATA__").textContent
@@ -867,22 +865,18 @@
     },
 
     /***/ Z577: /***/ function(module, exports) {
-      Promise.prototype.finally = function(n) {
-        if ("function" != typeof n) return this.then(n, n);
-        var t = this.constructor || Promise;
-        return this.then(
-          function(r) {
-            return t.resolve(n()).then(function() {
-              return r;
-            });
-          },
-          function(r) {
-            return t.resolve(n()).then(function() {
-              throw r;
-            });
-          }
-        );
-      };
+      Promise.prototype.finally ||
+        (Promise.prototype.finally = function(t) {
+          if ("function" != typeof t) return this.then(t, t);
+          const e = this.constructor || Promise;
+          return this.then(
+            o => e.resolve(t()).then(() => o),
+            o =>
+              e.resolve(t()).then(() => {
+                throw o;
+              })
+          );
+        });
 
       /***/
     },
Diff for main-aa205a8..ee47aba3c.js 
@@ -284,9 +284,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       var _router2 = __webpack_require__("nOHt");
       /* global location */
 
-      if (!("finally" in Promise.prototype)) {
-        Promise.prototype["finally"] = __webpack_require__("Z577");
-      }
+      __webpack_require__("Z577"); /// <reference types="react-dom/experimental" />
 
       var data = JSON.parse(
         document.getElementById("__NEXT_DATA__").textContent
@@ -1174,22 +1172,18 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
     },
 
     /***/ Z577: /***/ function(module, exports) {
-      Promise.prototype.finally = function(n) {
-        if ("function" != typeof n) return this.then(n, n);
-        var t = this.constructor || Promise;
-        return this.then(
-          function(r) {
-            return t.resolve(n()).then(function() {
-              return r;
-            });
-          },
-          function(r) {
-            return t.resolve(n()).then(function() {
-              throw r;
-            });
-          }
-        );
-      };
+      Promise.prototype.finally ||
+        (Promise.prototype.finally = function(t) {
+          if ("function" != typeof t) return this.then(t, t);
+          const e = this.constructor || Promise;
+          return this.then(
+            o => e.resolve(t()).then(() => o),
+            o =>
+              e.resolve(t()).then(() => {
+                throw o;
+              })
+          );
+        });
 
       /***/
     },
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 13.8s 13.9s ⚠️ +139ms
nodeModulesSize 57.5 MB 57.5 MB -276 B
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-49b1fd5..c64c.js gzip N/A 7.35 kB N/A
Overall change 57.3 kB 57.3 kB -10 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-99715b4..dule.js gzip N/A 6.4 kB N/A
Overall change 52.3 kB 52.2 kB -21 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 5d01678

@ijjk
Copy link
Member

ijjk commented Aug 28, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 12.1s 12.1s ✓
nodeModulesSize 57.5 MB 57.5 MB -276 B
Page Load Tests Overall increase ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.213 2.165 -0.05
/ avg req/sec 1129.84 1154.71 +24.87
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.203 1.197 -0.01
/error-in-render avg req/sec 2078.9 2088.16 +9.26
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB 7.35 kB -10 B
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB -10 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB 6.4 kB -21 B
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.2 kB -21 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
index.html gzip 972 B 971 B -1 B
link.html gzip 978 B 977 B -1 B
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.91 kB -2 B

Diffs

Diff for main-2954023..10.module.js 
@@ -202,9 +202,7 @@
       var _router2 = __webpack_require__("nOHt");
       /* global location */
 
-      if (!("finally" in Promise.prototype)) {
-        Promise.prototype.finally = __webpack_require__("Z577");
-      }
+      __webpack_require__("Z577"); /// <reference types="react-dom/experimental" />
 
       var data = JSON.parse(
         document.getElementById("__NEXT_DATA__").textContent
@@ -867,22 +865,18 @@
     },
 
     /***/ Z577: /***/ function(module, exports) {
-      Promise.prototype.finally = function(n) {
-        if ("function" != typeof n) return this.then(n, n);
-        var t = this.constructor || Promise;
-        return this.then(
-          function(r) {
-            return t.resolve(n()).then(function() {
-              return r;
-            });
-          },
-          function(r) {
-            return t.resolve(n()).then(function() {
-              throw r;
-            });
-          }
-        );
-      };
+      Promise.prototype.finally ||
+        (Promise.prototype.finally = function(t) {
+          if ("function" != typeof t) return this.then(t, t);
+          const e = this.constructor || Promise;
+          return this.then(
+            o => e.resolve(t()).then(() => o),
+            o =>
+              e.resolve(t()).then(() => {
+                throw o;
+              })
+          );
+        });
 
       /***/
     },
Diff for main-aa205a8..ee47aba3c.js 
@@ -284,9 +284,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       var _router2 = __webpack_require__("nOHt");
       /* global location */
 
-      if (!("finally" in Promise.prototype)) {
-        Promise.prototype["finally"] = __webpack_require__("Z577");
-      }
+      __webpack_require__("Z577"); /// <reference types="react-dom/experimental" />
 
       var data = JSON.parse(
         document.getElementById("__NEXT_DATA__").textContent
@@ -1174,22 +1172,18 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
     },
 
     /***/ Z577: /***/ function(module, exports) {
-      Promise.prototype.finally = function(n) {
-        if ("function" != typeof n) return this.then(n, n);
-        var t = this.constructor || Promise;
-        return this.then(
-          function(r) {
-            return t.resolve(n()).then(function() {
-              return r;
-            });
-          },
-          function(r) {
-            return t.resolve(n()).then(function() {
-              throw r;
-            });
-          }
-        );
-      };
+      Promise.prototype.finally ||
+        (Promise.prototype.finally = function(t) {
+          if ("function" != typeof t) return this.then(t, t);
+          const e = this.constructor || Promise;
+          return this.then(
+            o => e.resolve(t()).then(() => o),
+            o =>
+              e.resolve(t()).then(() => {
+                throw o;
+              })
+          );
+        });
 
       /***/
     },
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 13.8s 13.7s -98ms
nodeModulesSize 57.5 MB 57.5 MB -276 B
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-49b1fd5..c64c.js gzip N/A 7.35 kB N/A
Overall change 57.3 kB 57.3 kB -10 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-99715b4..dule.js gzip N/A 6.4 kB N/A
Overall change 52.3 kB 52.2 kB -21 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 299f412

Timer
Timer approved these changes Aug 30, 2020
View reviewed changes
Copy link
Member

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk
Copy link
Member

ijjk commented Aug 30, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 12.1s 12.3s ⚠️ +261ms
nodeModulesSize 57.4 MB 57.4 MB -276 B
Page Load Tests Overall increase ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.249 2.168 -0.08
/ avg req/sec 1111.62 1153.13 +41.51
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.215 1.169 -0.05
/error-in-render avg req/sec 2057.04 2137.99 +80.95
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB 7.35 kB -10 B
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB -10 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB 6.4 kB -21 B
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.2 kB -21 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
index.html gzip 972 B 971 B -1 B
link.html gzip 978 B 977 B -1 B
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.91 kB -2 B

Diffs

Diff for main-2954023..10.module.js 
@@ -202,9 +202,7 @@
       var _router2 = __webpack_require__("nOHt");
       /* global location */
 
-      if (!("finally" in Promise.prototype)) {
-        Promise.prototype.finally = __webpack_require__("Z577");
-      }
+      __webpack_require__("Z577"); /// <reference types="react-dom/experimental" />
 
       var data = JSON.parse(
         document.getElementById("__NEXT_DATA__").textContent
@@ -867,22 +865,18 @@
     },
 
     /***/ Z577: /***/ function(module, exports) {
-      Promise.prototype.finally = function(n) {
-        if ("function" != typeof n) return this.then(n, n);
-        var t = this.constructor || Promise;
-        return this.then(
-          function(r) {
-            return t.resolve(n()).then(function() {
-              return r;
-            });
-          },
-          function(r) {
-            return t.resolve(n()).then(function() {
-              throw r;
-            });
-          }
-        );
-      };
+      Promise.prototype.finally ||
+        (Promise.prototype.finally = function(t) {
+          if ("function" != typeof t) return this.then(t, t);
+          const e = this.constructor || Promise;
+          return this.then(
+            o => e.resolve(t()).then(() => o),
+            o =>
+              e.resolve(t()).then(() => {
+                throw o;
+              })
+          );
+        });
 
       /***/
     },
Diff for main-aa205a8..ee47aba3c.js 
@@ -284,9 +284,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       var _router2 = __webpack_require__("nOHt");
       /* global location */
 
-      if (!("finally" in Promise.prototype)) {
-        Promise.prototype["finally"] = __webpack_require__("Z577");
-      }
+      __webpack_require__("Z577"); /// <reference types="react-dom/experimental" />
 
       var data = JSON.parse(
         document.getElementById("__NEXT_DATA__").textContent
@@ -1174,22 +1172,18 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
     },
 
     /***/ Z577: /***/ function(module, exports) {
-      Promise.prototype.finally = function(n) {
-        if ("function" != typeof n) return this.then(n, n);
-        var t = this.constructor || Promise;
-        return this.then(
-          function(r) {
-            return t.resolve(n()).then(function() {
-              return r;
-            });
-          },
-          function(r) {
-            return t.resolve(n()).then(function() {
-              throw r;
-            });
-          }
-        );
-      };
+      Promise.prototype.finally ||
+        (Promise.prototype.finally = function(t) {
+          if ("function" != typeof t) return this.then(t, t);
+          const e = this.constructor || Promise;
+          return this.then(
+            o => e.resolve(t()).then(() => o),
+            o =>
+              e.resolve(t()).then(() => {
+                throw o;
+              })
+          );
+        });
 
       /***/
     },
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 13.8s 13.6s -166ms
nodeModulesSize 57.4 MB 57.4 MB -276 B
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-49b1fd5..c64c.js gzip N/A 7.35 kB N/A
Overall change 57.3 kB 57.3 kB -10 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-99715b4..dule.js gzip N/A 6.4 kB N/A
Overall change 52.3 kB 52.2 kB -21 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 0ca8184

@ijjk
Copy link
Member

ijjk commented Aug 30, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 11.7s 12s ⚠️ +260ms
nodeModulesSize 57.4 MB 57.4 MB -276 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.216 2.243 ⚠️ +0.03
/ avg req/sec 1128.4 1114.46 ⚠️ -13.94
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.364 1.354 -0.01
/error-in-render avg req/sec 1832.51 1845.87 +13.36
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB 7.35 kB -10 B
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB -10 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB 6.4 kB -21 B
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.2 kB -21 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
index.html gzip 972 B 971 B -1 B
link.html gzip 978 B 977 B -1 B
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.91 kB -2 B

Diffs

Diff for main-2954023..10.module.js 
@@ -202,9 +202,7 @@
       var _router2 = __webpack_require__("nOHt");
       /* global location */
 
-      if (!("finally" in Promise.prototype)) {
-        Promise.prototype.finally = __webpack_require__("Z577");
-      }
+      __webpack_require__("Z577"); /// <reference types="react-dom/experimental" />
 
       var data = JSON.parse(
         document.getElementById("__NEXT_DATA__").textContent
@@ -867,22 +865,18 @@
     },
 
     /***/ Z577: /***/ function(module, exports) {
-      Promise.prototype.finally = function(n) {
-        if ("function" != typeof n) return this.then(n, n);
-        var t = this.constructor || Promise;
-        return this.then(
-          function(r) {
-            return t.resolve(n()).then(function() {
-              return r;
-            });
-          },
-          function(r) {
-            return t.resolve(n()).then(function() {
-              throw r;
-            });
-          }
-        );
-      };
+      Promise.prototype.finally ||
+        (Promise.prototype.finally = function(t) {
+          if ("function" != typeof t) return this.then(t, t);
+          const e = this.constructor || Promise;
+          return this.then(
+            o => e.resolve(t()).then(() => o),
+            o =>
+              e.resolve(t()).then(() => {
+                throw o;
+              })
+          );
+        });
 
       /***/
     },
Diff for main-aa205a8..ee47aba3c.js 
@@ -284,9 +284,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       var _router2 = __webpack_require__("nOHt");
       /* global location */
 
-      if (!("finally" in Promise.prototype)) {
-        Promise.prototype["finally"] = __webpack_require__("Z577");
-      }
+      __webpack_require__("Z577"); /// <reference types="react-dom/experimental" />
 
       var data = JSON.parse(
         document.getElementById("__NEXT_DATA__").textContent
@@ -1174,22 +1172,18 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
     },
 
     /***/ Z577: /***/ function(module, exports) {
-      Promise.prototype.finally = function(n) {
-        if ("function" != typeof n) return this.then(n, n);
-        var t = this.constructor || Promise;
-        return this.then(
-          function(r) {
-            return t.resolve(n()).then(function() {
-              return r;
-            });
-          },
-          function(r) {
-            return t.resolve(n()).then(function() {
-              throw r;
-            });
-          }
-        );
-      };
+      Promise.prototype.finally ||
+        (Promise.prototype.finally = function(t) {
+          if ("function" != typeof t) return this.then(t, t);
+          const e = this.constructor || Promise;
+          return this.then(
+            o => e.resolve(t()).then(() => o),
+            o =>
+              e.resolve(t()).then(() => {
+                throw o;
+              })
+          );
+        });
 
       /***/
     },
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 13.6s 13.2s -453ms
nodeModulesSize 57.4 MB 57.4 MB -276 B
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-49b1fd5..c64c.js gzip N/A 7.35 kB N/A
Overall change 57.3 kB 57.3 kB -10 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-99715b4..dule.js gzip N/A 6.4 kB N/A
Overall change 52.3 kB 52.2 kB -21 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: d878237

@ijjk
Copy link
Member

ijjk commented Aug 30, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 13.3s 12.8s -464ms
nodeModulesSize 57.4 MB 57.4 MB -276 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.443 2.525 ⚠️ +0.08
/ avg req/sec 1023.15 990.24 ⚠️ -32.91
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.457 1.542 ⚠️ +0.08
/error-in-render avg req/sec 1715.48 1621.72 ⚠️ -93.76
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB 7.35 kB -10 B
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.3 kB 57.3 kB -10 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB 6.4 kB -21 B
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52.3 kB 52.2 kB -21 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
index.html gzip 972 B 971 B -1 B
link.html gzip 978 B 977 B -1 B
withRouter.html gzip 964 B 964 B ✓
Overall change 2.91 kB 2.91 kB -2 B

Diffs

Diff for main-2954023..10.module.js 
@@ -202,9 +202,7 @@
       var _router2 = __webpack_require__("nOHt");
       /* global location */
 
-      if (!("finally" in Promise.prototype)) {
-        Promise.prototype.finally = __webpack_require__("Z577");
-      }
+      __webpack_require__("Z577"); /// <reference types="react-dom/experimental" />
 
       var data = JSON.parse(
         document.getElementById("__NEXT_DATA__").textContent
@@ -867,22 +865,18 @@
     },
 
     /***/ Z577: /***/ function(module, exports) {
-      Promise.prototype.finally = function(n) {
-        if ("function" != typeof n) return this.then(n, n);
-        var t = this.constructor || Promise;
-        return this.then(
-          function(r) {
-            return t.resolve(n()).then(function() {
-              return r;
-            });
-          },
-          function(r) {
-            return t.resolve(n()).then(function() {
-              throw r;
-            });
-          }
-        );
-      };
+      Promise.prototype.finally ||
+        (Promise.prototype.finally = function(t) {
+          if ("function" != typeof t) return this.then(t, t);
+          const e = this.constructor || Promise;
+          return this.then(
+            o => e.resolve(t()).then(() => o),
+            o =>
+              e.resolve(t()).then(() => {
+                throw o;
+              })
+          );
+        });
 
       /***/
     },
Diff for main-aa205a8..ee47aba3c.js 
@@ -284,9 +284,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
       var _router2 = __webpack_require__("nOHt");
       /* global location */
 
-      if (!("finally" in Promise.prototype)) {
-        Promise.prototype["finally"] = __webpack_require__("Z577");
-      }
+      __webpack_require__("Z577"); /// <reference types="react-dom/experimental" />
 
       var data = JSON.parse(
         document.getElementById("__NEXT_DATA__").textContent
@@ -1174,22 +1172,18 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
     },
 
     /***/ Z577: /***/ function(module, exports) {
-      Promise.prototype.finally = function(n) {
-        if ("function" != typeof n) return this.then(n, n);
-        var t = this.constructor || Promise;
-        return this.then(
-          function(r) {
-            return t.resolve(n()).then(function() {
-              return r;
-            });
-          },
-          function(r) {
-            return t.resolve(n()).then(function() {
-              throw r;
-            });
-          }
-        );
-      };
+      Promise.prototype.finally ||
+        (Promise.prototype.finally = function(t) {
+          if ("function" != typeof t) return this.then(t, t);
+          const e = this.constructor || Promise;
+          return this.then(
+            o => e.resolve(t()).then(() => o),
+            o =>
+              e.resolve(t()).then(() => {
+                throw o;
+              })
+          );
+        });
 
       /***/
     },
Diff for index.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -87,13 +87,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -7,7 +7,7 @@
     <noscript data-n-css="true"></noscript>
     <link
       rel="preload"
-      href="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      href="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -82,13 +82,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-aa205a82b27ee47aba3c.js"
+      src="/_next/static/chunks/main-b79b1e531d6d98106011.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-2954023e99b1f192ce10.module.js"
+      src="/_next/static/chunks/main-e4ec5a082a22aa0ac788.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
buildDuration 14.2s 14.3s ⚠️ +43ms
nodeModulesSize 57.4 MB 57.4 MB -276 B
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..f20b.js gzip 10.3 kB 10.3 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-ce79c9a..12c9.js gzip 7.36 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-49b1fd5..c64c.js gzip N/A 7.35 kB N/A
Overall change 57.3 kB 57.3 kB -10 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
677f882d2ed8..dule.js gzip 6.13 kB 6.13 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-9973c26..dule.js gzip 6.42 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-99715b4..dule.js gzip N/A 6.4 kB N/A
Overall change 52.3 kB 52.2 kB -21 B
Legacy Client Bundles (polyfills)
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-28298..e0c9.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-65c8a..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary tengmaoqing/next.js fix_finally_polyfill Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.22 kB 4.22 kB ✓
hooks.html 3.86 kB 3.86 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.28 MB 5.28 MB ✓
Commit: 238bcce

@kodiakhq kodiakhq bot merged commit 6926ab7 into vercel:canary Aug 30, 2020
ijjk added a commit to ijjk/next.js that referenced this pull request Sep 1, 2020
@ijjk
Revert "fix: Promise.prototype.finally is object (vercel#16620)"
7523583 
This reverts commit 6926ab7.
@ijjk ijjk mentioned this pull request Sep 1, 2020
Merged
Timer pushed a commit that referenced this pull request Sep 1, 2020
@ijjk
Revert "fix: Promise.prototype.finally is object (#16620)" (#16753)
91a50d3 
This reverts commit 6926ab7.
This was referenced May 25, 2021
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Janpot Janpot Janpot left review comments

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tengmaoqing @ijjk @Timer @Janpot