Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IE11 CSS Compatibility #16336

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Fix IE11 CSS Compatibility #16336

merged 1 commit into from
Aug 19, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Aug 19, 2020

Fixes #16335

@ijjk
Copy link
Member

ijjk commented Aug 19, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
buildDuration 13.9s 14.2s ⚠️ +267ms
nodeModulesSize 57.7 MB 57.7 MB ⚠️ +129 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.642 2.697 ⚠️ +0.06
/ avg req/sec 946.2 927.02 ⚠️ -19.18
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.615 1.701 ⚠️ +0.09
/error-in-render avg req/sec 1548.21 1469.39 ⚠️ -78.82
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-8da9cf5..55dc.js gzip 7.18 kB 7.17 kB -5 B
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.1 kB 57.1 kB -5 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e458620..dule.js gzip 6.2 kB 6.2 kB -1 B
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB -1 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
index.html gzip 947 B 948 B ⚠️ +1 B
link.html gzip 953 B 954 B ⚠️ +1 B
withRouter.html gzip 938 B 940 B ⚠️ +2 B
Overall change 2.84 kB 2.84 kB ⚠️ +4 B

Diffs

Diff for main-02c0657..76.module.js 
@@ -781,7 +781,7 @@
           [].slice
             .call(document.querySelectorAll("link[data-n-staging]"))
             .forEach(el => {
-              el.remove();
+              el.parentNode.removeChild(el);
             });
         }
 
@@ -801,7 +801,7 @@
             // Remove old stylesheets:
             [].slice
               .call(document.querySelectorAll("link[data-n-p]"))
-              .forEach(el => el.remove()); // Activate new stylesheets:
+              .forEach(el => el.parentNode.removeChild(el)); // Activate new stylesheets:
             [].slice
               .call(document.querySelectorAll("link[data-n-staging]"))
               .forEach(el => {
Diff for main-e9105a4..cb75348e7.js 
@@ -975,7 +975,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
                         [].slice
                           .call(document.querySelectorAll("link[data-n-p]"))
                           .forEach(function(el) {
-                            return el.remove();
+                            return el.parentNode.removeChild(el);
                           }); // Activate new stylesheets:
                         [].slice
                           .call(
@@ -998,7 +998,7 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
                       [].slice
                         .call(document.querySelectorAll("link[data-n-staging]"))
                         .forEach(function(el) {
-                          el.remove();
+                          el.parentNode.removeChild(el);
                         });
                     };
Diff for index.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/chunks/main-02c06573f47461638176.module.js"
+      href="/_next/static/chunks/main-57d2d514817ea1374d8f.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -81,13 +81,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-e9105a4c4bfcb75348e7.js"
+      src="/_next/static/chunks/main-04baf02431fd25696fe5.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-02c06573f47461638176.module.js"
+      src="/_next/static/chunks/main-57d2d514817ea1374d8f.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/chunks/main-02c06573f47461638176.module.js"
+      href="/_next/static/chunks/main-57d2d514817ea1374d8f.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -86,13 +86,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-e9105a4c4bfcb75348e7.js"
+      src="/_next/static/chunks/main-04baf02431fd25696fe5.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-02c06573f47461638176.module.js"
+      src="/_next/static/chunks/main-57d2d514817ea1374d8f.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/chunks/main-02c06573f47461638176.module.js"
+      href="/_next/static/chunks/main-57d2d514817ea1374d8f.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -81,13 +81,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-e9105a4c4bfcb75348e7.js"
+      src="/_next/static/chunks/main-04baf02431fd25696fe5.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-02c06573f47461638176.module.js"
+      src="/_next/static/chunks/main-57d2d514817ea1374d8f.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
buildDuration 16.2s 16.1s -117ms
nodeModulesSize 57.7 MB 57.7 MB ⚠️ +129 B
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
677f882d2ed8..4e55.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-8da9cf5..55dc.js gzip 7.18 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-e65ff7b..7031.js gzip N/A 7.17 kB N/A
Overall change 57.1 kB 57.1 kB -5 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-e458620..dule.js gzip 6.2 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-949574a..dule.js gzip N/A 6.2 kB N/A
Overall change 52 kB 52 kB -1 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-000f151..65d4.js gzip 1.29 kB 1.29 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.69 kB 7.69 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-4cfda7a..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.35 kB 5.35 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 651 B 651 B ✓
Serverless bundles
vercel/next.js canary Timer/next.js hotfix/ie11-compat Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Commit: cc96ac7

@Timer Timer merged commit 9746043 into vercel:canary Aug 19, 2020
@Timer Timer deleted the hotfix/ie11-compat branch August 19, 2020 06:34
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@Timer
Fix IE11 CSS Compatibility (vercel#16336)
7f8b924
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix IE11 compatibility on next@canary
2 participants
@Timer @ijjk