Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forEach error in CSS commit in ie11 #16282

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Fix forEach error in CSS commit in ie11 #16282

merged 1 commit into from
Aug 18, 2020

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Aug 18, 2020 •
edited by Timer

This fixes an error that was occurring in ie11 due to forEach being called on querySelectorAll before it was massaged to an array.

x-ref: #16126
Fixes #16283

@ijjk
Copy link
Member Author

ijjk commented Aug 18, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
buildDuration 11.9s 12.1s ⚠️ +129ms
nodeModulesSize 57.6 MB 57.6 MB ⚠️ +228 B
Page Load Tests Overall decrease ⚠️
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.174 2.215 ⚠️ +0.04
/ avg req/sec 1149.9 1128.87 ⚠️ -21.03
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.128 1.205 ⚠️ +0.08
/error-in-render avg req/sec 2215.36 2074.06 ⚠️ -141.3
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
677f882d2ed8..aa9e.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a8b6d00..223c.js gzip 7.17 kB 7.16 kB -7 B
webpack-e067..f178.js gzip 751 B 751 B ✓
Overall change 57.1 kB 57.1 kB -7 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-f294dd0..dule.js gzip 6.18 kB 6.18 kB -3 B
webpack-07c5..dule.js gzip 751 B 751 B ✓
Overall change 52 kB 52 kB -3 B
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-00b8972..6e4e.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.7 kB 7.7 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-72c64d9..dule.js gzip 1.27 kB 1.27 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
index.html gzip 946 B 946 B ✓
link.html gzip 951 B 952 B ⚠️ +1 B
withRouter.html gzip 938 B 939 B ⚠️ +1 B
Overall change 2.83 kB 2.84 kB ⚠️ +2 B

Diffs

Diff for main-471cc3f..d5.module.js 
@@ -774,9 +774,11 @@
         }
 
         function onAbort() {
-          document.querySelectorAll("link[data-n-staging]").forEach(el => {
-            el.remove();
-          });
+          [].slice
+            .call(document.querySelectorAll("link[data-n-staging]"))
+            .forEach(el => {
+              el.remove();
+            });
         }
 
         renderPromise.catch(abortError => {
@@ -793,8 +795,8 @@
             true
           ) {
             // Remove old stylesheets:
-            document
-              .querySelectorAll("link[data-n-p]")
+            [].slice
+              .call(document.querySelectorAll("link[data-n-p]"))
               .forEach(el => el.remove()); // Activate new stylesheets:
             [].slice
               .call(document.querySelectorAll("link[data-n-staging]"))
Diff for main-e888061..7e25a1421.js 
@@ -972,8 +972,8 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
                         true
                       ) {
                         // Remove old stylesheets:
-                        document
-                          .querySelectorAll("link[data-n-p]")
+                        [].slice
+                          .call(document.querySelectorAll("link[data-n-p]"))
                           .forEach(function(el) {
                             return el.remove();
                           }); // Activate new stylesheets:
@@ -992,8 +992,8 @@ _N_E = (window["webpackJsonp_N_E"] = window["webpackJsonp_N_E"] || []).push([
                     };
 
                     onAbort = function _onAbort() {
-                      document
-                        .querySelectorAll("link[data-n-staging]")
+                      [].slice
+                        .call(document.querySelectorAll("link[data-n-staging]"))
                         .forEach(function(el) {
                           el.remove();
                         });
Diff for index.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/chunks/main-471cc3f5dad70718dfd5.module.js"
+      href="/_next/static/chunks/main-7751e12991e32f743d3e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -81,13 +81,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-e88806185567e25a1421.js"
+      src="/_next/static/chunks/main-662c5b17a1d45248b5d2.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-471cc3f5dad70718dfd5.module.js"
+      src="/_next/static/chunks/main-7751e12991e32f743d3e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/chunks/main-471cc3f5dad70718dfd5.module.js"
+      href="/_next/static/chunks/main-7751e12991e32f743d3e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -86,13 +86,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-e88806185567e25a1421.js"
+      src="/_next/static/chunks/main-662c5b17a1d45248b5d2.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-471cc3f5dad70718dfd5.module.js"
+      src="/_next/static/chunks/main-7751e12991e32f743d3e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -6,7 +6,7 @@
     <meta name="next-head-count" content="2" />
     <link
       rel="preload"
-      href="/_next/static/chunks/main-471cc3f5dad70718dfd5.module.js"
+      href="/_next/static/chunks/main-7751e12991e32f743d3e.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -81,13 +81,13 @@
       src="/_next/static/chunks/polyfills-f73ba3fc145972ef83e9.js"
     ></script>
     <script
-      src="/_next/static/chunks/main-e88806185567e25a1421.js"
+      src="/_next/static/chunks/main-662c5b17a1d45248b5d2.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/main-471cc3f5dad70718dfd5.module.js"
+      src="/_next/static/chunks/main-7751e12991e32f743d3e.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
buildDuration 13.7s 12.7s -947ms
nodeModulesSize 57.6 MB 57.6 MB ⚠️ +228 B
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
677f882d2ed8..aa9e.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39 kB 39 kB ✓
main-a8b6d00..223c.js gzip 7.17 kB N/A N/A
webpack-e067..f178.js gzip 751 B 751 B ✓
main-c6e605d..8738.js gzip N/A 7.16 kB N/A
Overall change 57.1 kB 57.1 kB -7 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
677f882d2ed8..dule.js gzip 6.11 kB 6.11 kB ✓
framework.HA..dule.js gzip 39 kB 39 kB ✓
main-f294dd0..dule.js gzip 6.18 kB N/A N/A
webpack-07c5..dule.js gzip 751 B 751 B ✓
main-b606df5..dule.js gzip N/A 6.18 kB N/A
Overall change 52 kB 52 kB -3 B
Legacy Client Bundles (polyfills)
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
polyfills-4b..e242.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
_app-9a0b9e1..b37e.js gzip 1.28 kB 1.28 kB ✓
_error-1464c..a26f.js gzip 3.44 kB 3.44 kB ✓
hooks-89731c..c609.js gzip 887 B 887 B ✓
index-17468f..5d83.js gzip 227 B 227 B ✓
link-00b8972..6e4e.js gzip 1.3 kB 1.3 kB ✓
routerDirect..924c.js gzip 284 B 284 B ✓
withRouter-7..c13d.js gzip 284 B 284 B ✓
Overall change 7.7 kB 7.7 kB ✓
Client Pages Modern
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
_app-75d3a82..dule.js gzip 625 B 625 B ✓
_error-e550f..dule.js gzip 2.29 kB 2.29 kB ✓
hooks-cbf13f..dule.js gzip 387 B 387 B ✓
index-b9a643..dule.js gzip 226 B 226 B ✓
link-72c64d9..dule.js gzip 1.27 kB 1.27 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-f..dule.js gzip 282 B 282 B ✓
Overall change 5.36 kB 5.36 kB ✓
Client Build Manifests
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
_buildManifest.js gzip 322 B 322 B ✓
_buildManife..dule.js gzip 330 B 330 B ✓
Overall change 652 B 652 B ✓
Serverless bundles
vercel/next.js canary ijjk/next.js fix/css-change-ie11 Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.07 MB 1.07 MB ✓
withRouter.js 1.07 MB 1.07 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Commit: f2030d1

@kodiakhq kodiakhq bot merged commit 9aadd1a into vercel:canary Aug 18, 2020
@Timer Timer deleted the fix/css-change-ie11 branch August 18, 2020 03:59
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@ijjk
Fix forEach error in CSS commit in ie11 (vercel#16282)
7eb205e 
This fixes an error that was occurring in ie11 due to `forEach` being called on `querySelectorAll` before it was massaged to an array.

x-ref: vercel#16126
Fixes vercel#16283
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[internal] [canary only] Fix IE 11 compat
2 participants
@ijjk @Timer