Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Terser 5 #16194

Merged
merged 6 commits into from
Aug 16, 2020
Merged

Update to Terser 5 #16194

merged 6 commits into from
Aug 16, 2020

Conversation

chicoxyzzy
Copy link
Contributor

@chicoxyzzy chicoxyzzy commented Aug 14, 2020 •
edited by timneutkens

terser-webpack-plugin is now compatible with Terser 5

webpack-contrib/terser-webpack-plugin#285

Fixes #16000

@ijjk
Copy link
Member

ijjk commented Aug 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
vercel/next.js canary chicoxyzzy/next.js update_terser Change
buildDuration 12.8s 13.2s ⚠️ +374ms
nodeModulesSize 57.3 MB 57.3 MB ✓
Page Load Tests Overall decrease ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.24 2.231 -0.01
/ avg req/sec 1116.12 1120.44 +4.32
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.236 1.248 ⚠️ +0.01
/error-in-render avg req/sec 2022.31 2003.8 ⚠️ -18.51
Client Bundles (main, webpack, commons)
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary chicoxyzzy/next.js update_terser Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Rendered Page Sizes
vercel/next.js canary chicoxyzzy/next.js update_terser Change
index.html gzip 946 B 946 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 939 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode
General
vercel/next.js canary chicoxyzzy/next.js update_terser Change
buildDuration 14.6s 14.6s ⚠️ +14ms
nodeModulesSize 57.3 MB 57.3 MB ✓
Client Bundles (main, webpack, commons)
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-d9f8cd0..c4c7.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-b9a17ec..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary chicoxyzzy/next.js update_terser Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Serverless bundles
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.26 MB 5.26 MB ✓
Commit: 1ff125d

timneutkens
timneutkens previously approved these changes Aug 16, 2020
View reviewed changes
@ijjk
Copy link
Member

ijjk commented Aug 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
buildDuration 14.6s 14s -633ms
nodeModulesSize 57.3 MB 57.6 MB ⚠️ +286 kB
Page Load Tests Overall increase ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.635 2.634 0
/ avg req/sec 948.59 949.01 +0.42
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.582 1.571 -0.01
/error-in-render avg req/sec 1580.42 1591.12 +10.7
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB -22 B
framework.HASH.js gzip 39.1 kB 39 kB -180 B
main-52b3964..e4b8.js gzip 6.74 kB 6.72 kB -21 B
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.7 kB -223 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..dule.js gzip 6.12 kB 6.07 kB -47 B
framework.HA..dule.js gzip 39.1 kB 39 kB -180 B
main-af2596f..dule.js gzip 5.82 kB 5.79 kB -28 B
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.6 kB -255 B
Legacy Client Bundles (polyfills) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
polyfills-75..1629.js gzip 31 kB 31 kB -31 B
Overall change 31 kB 31 kB -31 B
Client Pages Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.44 kB -16 B
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.3 kB ⚠️ +1 B
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.7 kB -15 B
Client Pages Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-97e743e..dule.js gzip 626 B 625 B -1 B
_error-b4004..dule.js gzip 2.3 kB 2.29 kB -14 B
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.27 kB ⚠️ +2 B
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.36 kB -13 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_buildManifest.js gzip 321 B 322 B ⚠️ +1 B
_buildManife..dule.js gzip 329 B 330 B ⚠️ +1 B
Overall change 650 B 652 B ⚠️ +2 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
index.html gzip 947 B 949 B ⚠️ +2 B
link.html gzip 955 B 955 B ✓
withRouter.html gzip 942 B 942 B ✓
Overall change 2.84 kB 2.85 kB ⚠️ +2 B
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
buildDuration 16.5s 15.6s -863ms
nodeModulesSize 57.3 MB 57.6 MB ⚠️ +286 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..c139.js gzip 10.2 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39 kB -180 B
main-52b3964..e4b8.js gzip 6.74 kB N/A N/A
webpack-ccf5..276a.js gzip 751 B N/A N/A
677f882d2ed8..2585.js gzip N/A 10.2 kB N/A
main-6984394..c1c4.js gzip N/A 6.72 kB N/A
webpack-e067..f178.js gzip N/A 751 B N/A
Overall change 56.9 kB 56.7 kB -223 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..dule.js gzip 6.12 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39 kB -180 B
main-af2596f..dule.js gzip 5.82 kB N/A N/A
webpack-10c7..dule.js gzip 751 B N/A N/A
677f882d2ed8..dule.js gzip N/A 6.07 kB N/A
main-85be351..dule.js gzip N/A 5.79 kB N/A
webpack-07c5..dule.js gzip N/A 751 B N/A
Overall change 51.8 kB 51.6 kB -255 B
Legacy Client Bundles (polyfills) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
polyfills-75..1629.js gzip 31 kB N/A N/A
polyfills-4b..e242.js gzip N/A 31 kB N/A
Overall change 31 kB 31 kB -31 B
Client Pages Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-874bd8a..0103.js gzip 1.28 kB N/A N/A
_error-fa39c..ec40.js gzip 3.45 kB N/A N/A
hooks-585f07..95a3.js gzip 887 B N/A N/A
index-c7b63f..fc02.js gzip 227 B N/A N/A
link-4c2bd9b..eadd.js gzip 1.29 kB N/A N/A
routerDirect..ebc7.js gzip 284 B N/A N/A
withRouter-2..db68.js gzip 284 B N/A N/A
_app-9a0b9e1..b37e.js gzip N/A 1.28 kB N/A
_error-1464c..a26f.js gzip N/A 3.44 kB N/A
hooks-89731c..c609.js gzip N/A 887 B N/A
index-17468f..5d83.js gzip N/A 227 B N/A
link-00b8972..6e4e.js gzip N/A 1.3 kB N/A
routerDirect..924c.js gzip N/A 284 B N/A
withRouter-7..c13d.js gzip N/A 284 B N/A
Overall change 7.71 kB 7.7 kB -15 B
Client Pages Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-97e743e..dule.js gzip 626 B N/A N/A
_error-b4004..dule.js gzip 2.3 kB N/A N/A
hooks-696209..dule.js gzip 387 B N/A N/A
index-a4dd74..dule.js gzip 226 B N/A N/A
link-236a801..dule.js gzip 1.26 kB N/A N/A
routerDirect..dule.js gzip 284 B N/A N/A
withRouter-1..dule.js gzip 282 B N/A N/A
_app-75d3a82..dule.js gzip N/A 625 B N/A
_error-e550f..dule.js gzip N/A 2.29 kB N/A
hooks-cbf13f..dule.js gzip N/A 387 B N/A
index-b9a643..dule.js gzip N/A 226 B N/A
link-72c64d9..dule.js gzip N/A 1.27 kB N/A
routerDirect..dule.js gzip N/A 284 B N/A
withRouter-f..dule.js gzip N/A 282 B N/A
Overall change 5.37 kB 5.36 kB -13 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_buildManifest.js gzip 321 B 322 B ⚠️ +1 B
_buildManife..dule.js gzip 329 B 330 B ⚠️ +1 B
Overall change 650 B 652 B ⚠️ +2 B
Serverless bundles
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Commit: 711796a

@ijjk
Copy link
Member

ijjk commented Aug 16, 2020

Failing test suites

Commit: 711796a

test/integration/size-limit/test/index.test.js

  • Production response size > should not increase the overall response size of default build
Expand output

● Production response size › should not increase the overall response size of default build

expect(received).toBeGreaterThanOrEqual(expected)

Expected: >= -1024
Received:    -1116

  83 |     const delta = responseSizesBytes - 277 * 1024
  84 |     expect(delta).toBeLessThanOrEqual(1024) // don't increase size more than 1kb
> 85 |     expect(delta).toBeGreaterThanOrEqual(-1024) // don't decrease size more than 1kb without updating target
     |                   ^
  86 |   })
  87 | 
  88 |   it('should not increase the overall response size of modern build', async () => {

  at Object.<anonymous> (integration/size-limit/test/index.test.js:85:19)

@ijjk
Copy link
Member

ijjk commented Aug 16, 2020 •
edited

Failing test suites

Commit: c74e9ef

test/integration/cli/test/index.test.js

  • CLI Usage > dev > NODE_OPTIONS='--inspect'
Expand output

● CLI Usage › dev › NODE_OPTIONS='--inspect'

expect(received).toMatch(expected)

Matcher error: received value must be a string

Received has value: undefined

  119 |         env: { NODE_OPTIONS: '--inspect' },
  120 |       })
> 121 |       expect(output).toMatch(new RegExp(`http://localhost:${port}`))
      |                      ^
  122 |     })
  123 | 
  124 |     test('-p', async () => {

  at Object.<anonymous> (integration/cli/test/index.test.js:121:22)

test/integration/size-limit/test/index.test.js

  • Production response size > should not increase the overall response size of default build
Expand output

● Production response size › should not increase the overall response size of default build

expect(received).toBeGreaterThanOrEqual(expected)

Expected: >= -1024
Received:    -1116

  83 |     const delta = responseSizesBytes - 277 * 1024
  84 |     expect(delta).toBeLessThanOrEqual(1024) // don't increase size more than 1kb
> 85 |     expect(delta).toBeGreaterThanOrEqual(-1024) // don't decrease size more than 1kb without updating target
     |                   ^
  86 |   })
  87 | 
  88 |   it('should not increase the overall response size of modern build', async () => {

  at Object.<anonymous> (integration/size-limit/test/index.test.js:85:19)

@ijjk
Copy link
Member

ijjk commented Aug 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
buildDuration 11.9s 11.7s -190ms
nodeModulesSize 57.3 MB 57.6 MB ⚠️ +286 kB
Page Load Tests Overall increase ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.246 2.191 -0.06
/ avg req/sec 1113.17 1141.25 +28.08
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.329 1.349 ⚠️ +0.02
/error-in-render avg req/sec 1881.51 1853.73 ⚠️ -27.78
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB -22 B
framework.HASH.js gzip 39.1 kB 39 kB -180 B
main-52b3964..e4b8.js gzip 6.74 kB 6.72 kB -21 B
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.7 kB -223 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..dule.js gzip 6.12 kB 6.07 kB -47 B
framework.HA..dule.js gzip 39.1 kB 39 kB -180 B
main-af2596f..dule.js gzip 5.82 kB 5.79 kB -28 B
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.6 kB -255 B
Legacy Client Bundles (polyfills) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
polyfills-75..1629.js gzip 31 kB 31 kB -31 B
Overall change 31 kB 31 kB -31 B
Client Pages Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.44 kB -16 B
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.3 kB ⚠️ +1 B
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.7 kB -15 B
Client Pages Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-97e743e..dule.js gzip 626 B 625 B -1 B
_error-b4004..dule.js gzip 2.3 kB 2.29 kB -14 B
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.27 kB ⚠️ +2 B
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.36 kB -13 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_buildManifest.js gzip 321 B 322 B ⚠️ +1 B
_buildManife..dule.js gzip 329 B 330 B ⚠️ +1 B
Overall change 650 B 652 B ⚠️ +2 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
index.html gzip 947 B 949 B ⚠️ +2 B
link.html gzip 955 B 955 B ✓
withRouter.html gzip 942 B 942 B ✓
Overall change 2.84 kB 2.85 kB ⚠️ +2 B
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
buildDuration 12.4s 12.6s ⚠️ +132ms
nodeModulesSize 57.3 MB 57.6 MB ⚠️ +286 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..c139.js gzip 10.2 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39 kB -180 B
main-52b3964..e4b8.js gzip 6.74 kB N/A N/A
webpack-ccf5..276a.js gzip 751 B N/A N/A
677f882d2ed8..2585.js gzip N/A 10.2 kB N/A
main-6984394..c1c4.js gzip N/A 6.72 kB N/A
webpack-e067..f178.js gzip N/A 751 B N/A
Overall change 56.9 kB 56.7 kB -223 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..dule.js gzip 6.12 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39 kB -180 B
main-af2596f..dule.js gzip 5.82 kB N/A N/A
webpack-10c7..dule.js gzip 751 B N/A N/A
677f882d2ed8..dule.js gzip N/A 6.07 kB N/A
main-85be351..dule.js gzip N/A 5.79 kB N/A
webpack-07c5..dule.js gzip N/A 751 B N/A
Overall change 51.8 kB 51.6 kB -255 B
Legacy Client Bundles (polyfills) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
polyfills-75..1629.js gzip 31 kB N/A N/A
polyfills-4b..e242.js gzip N/A 31 kB N/A
Overall change 31 kB 31 kB -31 B
Client Pages Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-874bd8a..0103.js gzip 1.28 kB N/A N/A
_error-fa39c..ec40.js gzip 3.45 kB N/A N/A
hooks-585f07..95a3.js gzip 887 B N/A N/A
index-c7b63f..fc02.js gzip 227 B N/A N/A
link-4c2bd9b..eadd.js gzip 1.29 kB N/A N/A
routerDirect..ebc7.js gzip 284 B N/A N/A
withRouter-2..db68.js gzip 284 B N/A N/A
_app-9a0b9e1..b37e.js gzip N/A 1.28 kB N/A
_error-1464c..a26f.js gzip N/A 3.44 kB N/A
hooks-89731c..c609.js gzip N/A 887 B N/A
index-17468f..5d83.js gzip N/A 227 B N/A
link-00b8972..6e4e.js gzip N/A 1.3 kB N/A
routerDirect..924c.js gzip N/A 284 B N/A
withRouter-7..c13d.js gzip N/A 284 B N/A
Overall change 7.71 kB 7.7 kB -15 B
Client Pages Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-97e743e..dule.js gzip 626 B N/A N/A
_error-b4004..dule.js gzip 2.3 kB N/A N/A
hooks-696209..dule.js gzip 387 B N/A N/A
index-a4dd74..dule.js gzip 226 B N/A N/A
link-236a801..dule.js gzip 1.26 kB N/A N/A
routerDirect..dule.js gzip 284 B N/A N/A
withRouter-1..dule.js gzip 282 B N/A N/A
_app-75d3a82..dule.js gzip N/A 625 B N/A
_error-e550f..dule.js gzip N/A 2.29 kB N/A
hooks-cbf13f..dule.js gzip N/A 387 B N/A
index-b9a643..dule.js gzip N/A 226 B N/A
link-72c64d9..dule.js gzip N/A 1.27 kB N/A
routerDirect..dule.js gzip N/A 284 B N/A
withRouter-f..dule.js gzip N/A 282 B N/A
Overall change 5.37 kB 5.36 kB -13 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_buildManifest.js gzip 321 B 322 B ⚠️ +1 B
_buildManife..dule.js gzip 329 B 330 B ⚠️ +1 B
Overall change 650 B 652 B ⚠️ +2 B
Serverless bundles
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Commit: c74e9ef

@ijjk
Copy link
Member

ijjk commented Aug 16, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
buildDuration 10.6s 10.9s ⚠️ +320ms
nodeModulesSize 57.3 MB 57.6 MB ⚠️ +286 kB
Page Load Tests Overall increase ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.004 1.978 -0.03
/ avg req/sec 1247.27 1264.06 +16.79
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.237 1.181 -0.06
/error-in-render avg req/sec 2021.18 2117.27 +96.09
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB -22 B
framework.HASH.js gzip 39.1 kB 39 kB -180 B
main-52b3964..e4b8.js gzip 6.74 kB 6.72 kB -21 B
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.7 kB -223 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..dule.js gzip 6.12 kB 6.07 kB -47 B
framework.HA..dule.js gzip 39.1 kB 39 kB -180 B
main-af2596f..dule.js gzip 5.82 kB 5.79 kB -28 B
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.6 kB -255 B
Legacy Client Bundles (polyfills) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
polyfills-75..1629.js gzip 31 kB 31 kB -31 B
Overall change 31 kB 31 kB -31 B
Client Pages Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.44 kB -16 B
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.3 kB ⚠️ +1 B
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.7 kB -15 B
Client Pages Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-97e743e..dule.js gzip 626 B 625 B -1 B
_error-b4004..dule.js gzip 2.3 kB 2.29 kB -14 B
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.27 kB ⚠️ +2 B
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.36 kB -13 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_buildManifest.js gzip 321 B 322 B ⚠️ +1 B
_buildManife..dule.js gzip 329 B 330 B ⚠️ +1 B
Overall change 650 B 652 B ⚠️ +2 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
index.html gzip 947 B 949 B ⚠️ +2 B
link.html gzip 955 B 955 B ✓
withRouter.html gzip 942 B 942 B ✓
Overall change 2.84 kB 2.85 kB ⚠️ +2 B
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
buildDuration 12.3s 12.2s -100ms
nodeModulesSize 57.3 MB 57.6 MB ⚠️ +286 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..c139.js gzip 10.2 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39 kB -180 B
main-52b3964..e4b8.js gzip 6.74 kB N/A N/A
webpack-ccf5..276a.js gzip 751 B N/A N/A
677f882d2ed8..2585.js gzip N/A 10.2 kB N/A
main-6984394..c1c4.js gzip N/A 6.72 kB N/A
webpack-e067..f178.js gzip N/A 751 B N/A
Overall change 56.9 kB 56.7 kB -223 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..dule.js gzip 6.12 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39 kB -180 B
main-af2596f..dule.js gzip 5.82 kB N/A N/A
webpack-10c7..dule.js gzip 751 B N/A N/A
677f882d2ed8..dule.js gzip N/A 6.07 kB N/A
main-85be351..dule.js gzip N/A 5.79 kB N/A
webpack-07c5..dule.js gzip N/A 751 B N/A
Overall change 51.8 kB 51.6 kB -255 B
Legacy Client Bundles (polyfills) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
polyfills-75..1629.js gzip 31 kB N/A N/A
polyfills-4b..e242.js gzip N/A 31 kB N/A
Overall change 31 kB 31 kB -31 B
Client Pages Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-874bd8a..0103.js gzip 1.28 kB N/A N/A
_error-fa39c..ec40.js gzip 3.45 kB N/A N/A
hooks-585f07..95a3.js gzip 887 B N/A N/A
index-c7b63f..fc02.js gzip 227 B N/A N/A
link-4c2bd9b..eadd.js gzip 1.29 kB N/A N/A
routerDirect..ebc7.js gzip 284 B N/A N/A
withRouter-2..db68.js gzip 284 B N/A N/A
_app-9a0b9e1..b37e.js gzip N/A 1.28 kB N/A
_error-1464c..a26f.js gzip N/A 3.44 kB N/A
hooks-89731c..c609.js gzip N/A 887 B N/A
index-17468f..5d83.js gzip N/A 227 B N/A
link-00b8972..6e4e.js gzip N/A 1.3 kB N/A
routerDirect..924c.js gzip N/A 284 B N/A
withRouter-7..c13d.js gzip N/A 284 B N/A
Overall change 7.71 kB 7.7 kB -15 B
Client Pages Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-97e743e..dule.js gzip 626 B N/A N/A
_error-b4004..dule.js gzip 2.3 kB N/A N/A
hooks-696209..dule.js gzip 387 B N/A N/A
index-a4dd74..dule.js gzip 226 B N/A N/A
link-236a801..dule.js gzip 1.26 kB N/A N/A
routerDirect..dule.js gzip 284 B N/A N/A
withRouter-1..dule.js gzip 282 B N/A N/A
_app-75d3a82..dule.js gzip N/A 625 B N/A
_error-e550f..dule.js gzip N/A 2.29 kB N/A
hooks-cbf13f..dule.js gzip N/A 387 B N/A
index-b9a643..dule.js gzip N/A 226 B N/A
link-72c64d9..dule.js gzip N/A 1.27 kB N/A
routerDirect..dule.js gzip N/A 284 B N/A
withRouter-f..dule.js gzip N/A 282 B N/A
Overall change 5.37 kB 5.36 kB -13 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_buildManifest.js gzip 321 B 322 B ⚠️ +1 B
_buildManife..dule.js gzip 329 B 330 B ⚠️ +1 B
Overall change 650 B 652 B ⚠️ +2 B
Serverless bundles
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Commit: 235ce1e

@ijjk
Copy link
Member

ijjk commented Aug 16, 2020

Failing test suites

Commit: 235ce1e

test/integration/size-limit/test/index.test.js

  • Production response size > should not increase the overall response size of default build
Expand output

● Production response size › should not increase the overall response size of default build

expect(received).toBeGreaterThanOrEqual(expected)

Expected: >= -1024
Received:    -1116

  83 |     const delta = responseSizesBytes - 277 * 1024
  84 |     expect(delta).toBeLessThanOrEqual(1024) // don't increase size more than 1kb
> 85 |     expect(delta).toBeGreaterThanOrEqual(-1024) // don't decrease size more than 1kb without updating target
     |                   ^
  86 |   })
  87 | 
  88 |   it('should not increase the overall response size of modern build', async () => {

  at Object.<anonymous> (integration/size-limit/test/index.test.js:85:19)

@ijjk
Copy link
Member

ijjk commented Aug 16, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
buildDuration 11.4s 11s -338ms
nodeModulesSize 57.3 MB 57.6 MB ⚠️ +286 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.011 2.081 ⚠️ +0.07
/ avg req/sec 1242.92 1201.54 ⚠️ -41.38
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.101 1.087 -0.01
/error-in-render avg req/sec 2270.84 2300.92 +30.08
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB -22 B
framework.HASH.js gzip 39.1 kB 39 kB -180 B
main-52b3964..e4b8.js gzip 6.74 kB 6.72 kB -21 B
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.7 kB -223 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..dule.js gzip 6.12 kB 6.07 kB -47 B
framework.HA..dule.js gzip 39.1 kB 39 kB -180 B
main-af2596f..dule.js gzip 5.82 kB 5.79 kB -28 B
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.6 kB -255 B
Legacy Client Bundles (polyfills) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
polyfills-75..1629.js gzip 31 kB 31 kB -31 B
Overall change 31 kB 31 kB -31 B
Client Pages Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.44 kB -16 B
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.3 kB ⚠️ +1 B
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.7 kB -15 B
Client Pages Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-97e743e..dule.js gzip 626 B 625 B -1 B
_error-b4004..dule.js gzip 2.3 kB 2.29 kB -14 B
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.27 kB ⚠️ +2 B
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.36 kB -13 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_buildManifest.js gzip 321 B 322 B ⚠️ +1 B
_buildManife..dule.js gzip 329 B 330 B ⚠️ +1 B
Overall change 650 B 652 B ⚠️ +2 B
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
index.html gzip 947 B 949 B ⚠️ +2 B
link.html gzip 955 B 955 B ✓
withRouter.html gzip 942 B 942 B ✓
Overall change 2.84 kB 2.85 kB ⚠️ +2 B
Serverless Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
buildDuration 12.7s 12.7s ⚠️ +50ms
nodeModulesSize 57.3 MB 57.6 MB ⚠️ +286 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..c139.js gzip 10.2 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39 kB -180 B
main-52b3964..e4b8.js gzip 6.74 kB N/A N/A
webpack-ccf5..276a.js gzip 751 B N/A N/A
677f882d2ed8..2585.js gzip N/A 10.2 kB N/A
main-6984394..c1c4.js gzip N/A 6.72 kB N/A
webpack-e067..f178.js gzip N/A 751 B N/A
Overall change 56.9 kB 56.7 kB -223 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
677f882d2ed8..dule.js gzip 6.12 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39 kB -180 B
main-af2596f..dule.js gzip 5.82 kB N/A N/A
webpack-10c7..dule.js gzip 751 B N/A N/A
677f882d2ed8..dule.js gzip N/A 6.07 kB N/A
main-85be351..dule.js gzip N/A 5.79 kB N/A
webpack-07c5..dule.js gzip N/A 751 B N/A
Overall change 51.8 kB 51.6 kB -255 B
Legacy Client Bundles (polyfills) Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
polyfills-75..1629.js gzip 31 kB N/A N/A
polyfills-4b..e242.js gzip N/A 31 kB N/A
Overall change 31 kB 31 kB -31 B
Client Pages Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-874bd8a..0103.js gzip 1.28 kB N/A N/A
_error-fa39c..ec40.js gzip 3.45 kB N/A N/A
hooks-585f07..95a3.js gzip 887 B N/A N/A
index-c7b63f..fc02.js gzip 227 B N/A N/A
link-4c2bd9b..eadd.js gzip 1.29 kB N/A N/A
routerDirect..ebc7.js gzip 284 B N/A N/A
withRouter-2..db68.js gzip 284 B N/A N/A
_app-9a0b9e1..b37e.js gzip N/A 1.28 kB N/A
_error-1464c..a26f.js gzip N/A 3.44 kB N/A
hooks-89731c..c609.js gzip N/A 887 B N/A
index-17468f..5d83.js gzip N/A 227 B N/A
link-00b8972..6e4e.js gzip N/A 1.3 kB N/A
routerDirect..924c.js gzip N/A 284 B N/A
withRouter-7..c13d.js gzip N/A 284 B N/A
Overall change 7.71 kB 7.7 kB -15 B
Client Pages Modern Overall decrease ✓
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_app-97e743e..dule.js gzip 626 B N/A N/A
_error-b4004..dule.js gzip 2.3 kB N/A N/A
hooks-696209..dule.js gzip 387 B N/A N/A
index-a4dd74..dule.js gzip 226 B N/A N/A
link-236a801..dule.js gzip 1.26 kB N/A N/A
routerDirect..dule.js gzip 284 B N/A N/A
withRouter-1..dule.js gzip 282 B N/A N/A
_app-75d3a82..dule.js gzip N/A 625 B N/A
_error-e550f..dule.js gzip N/A 2.29 kB N/A
hooks-cbf13f..dule.js gzip N/A 387 B N/A
index-b9a643..dule.js gzip N/A 226 B N/A
link-72c64d9..dule.js gzip N/A 1.27 kB N/A
routerDirect..dule.js gzip N/A 284 B N/A
withRouter-f..dule.js gzip N/A 282 B N/A
Overall change 5.37 kB 5.36 kB -13 B
Client Build Manifests Overall increase ⚠️
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_buildManifest.js gzip 321 B 322 B ⚠️ +1 B
_buildManife..dule.js gzip 329 B 330 B ⚠️ +1 B
Overall change 650 B 652 B ⚠️ +2 B
Serverless bundles
vercel/next.js canary chicoxyzzy/next.js update_terser Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB ✓
routerDirect.js 1.06 MB 1.06 MB ✓
withRouter.js 1.06 MB 1.06 MB ✓
Overall change 5.27 MB 5.27 MB ✓
Commit: 5443870

@timneutkens timneutkens merged commit feeb941 into vercel:canary Aug 16, 2020
@chicoxyzzy chicoxyzzy deleted the update_terser branch August 16, 2020 19:18
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@chicoxyzzy @timneutkens @kodiakhq
Update to Terser 5 (vercel#16194)
6d2d939 
Co-authored-by: Tim Neutkens <timneutkens@me.com>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens left review comments

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

@Timer Timer Awaiting requested review from Timer

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump terser to 5.0.0
3 participants
@chicoxyzzy @ijjk @timneutkens