Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify low priority files in manifest #16181

Merged
merged 3 commits into from
Aug 14, 2020
Merged

Modify low priority files in manifest #16181

merged 3 commits into from
Aug 14, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Aug 14, 2020 •
edited

This pull request edits the BuildManifest that is sent to /_document instead of modifying a single input array to decouple its implementation details.

Optimally, we'd eliminate the files key all together.

Related to #16182

@ijjk
Copy link
Member

ijjk commented Aug 14, 2020 •
edited

Failing test suites

Commit: f7bcf5b

test/integration/auto-export-serverless/test/index.test.js

  • Auto Export Serverless > Refreshes query on mount
Expand output

● Auto Export Serverless › Refreshes query on mount

expect(received).toMatch(expected)

Expected pattern: /post.*post-1/
Received string:  "<div id=\"__next\"><p>post: </p></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/[post]\",\"query\":{},\"buildId\":\"wM8XIaf3IRtQxPW2Zpd8_\",\"runtimeConfig\":{},\"nextExport\":true,\"autoExport\":true,\"isFallback\":false}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-bcc5e025ef473b937a0a.js\"></script><script src=\"/_next/static/chunks/main-f3284c78595dc8ea78fc.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-ccf5ab034a524403276a.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.34a4b1c4d8a0795fb8a4.js\" async=\"\"></script><script src=\"/_next/static/chunks/commons.8bc233247fade06c54fe.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-4f457bd8c397d95f2c20.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/%5Bpost%5D-70ed79bc7369b6e787d5.js\" async=\"\"></script><script src=\"/_next/static/wM8XIaf3IRtQxPW2Zpd8_/_ssgManifest.js\" async=\"\"></script>"

  18 |     const browser = await webdriver(appPort, '/post-1')
  19 |     const html = await browser.eval('document.body.innerHTML')
> 20 |     expect(html).toMatch(/post.*post-1/)
     |                  ^
  21 |     expect(html).toMatch(/nextExport/)
  22 | 
  23 |     await killApp(app)

  at Object.<anonymous> (integration/auto-export-serverless/test/index.test.js:20:18)

test/integration/auto-export/test/index.test.js

  • Auto Export > dev > Refreshes query on mount
  • Auto Export > dev > should update asPath after mount
  • Auto Export > production > Refreshes query on mount
  • Auto Export > production > should update asPath after mount
Expand output

● Auto Export › production › Refreshes query on mount

expect(received).toMatch(expected)

Expected pattern: /post.*post-1/
Received string:  "<div id=\"__next\"><p>post: </p></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/[post]\",\"query\":{},\"buildId\":\"N47td1h-22qYjulmQ8gFC\",\"nextExport\":true,\"autoExport\":true,\"isFallback\":false}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-4f190352f132b0d6d70a.js\"></script><script src=\"/_next/static/chunks/main-9b58b62bbbaf95713227.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-ccf5ab034a524403276a.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.ac53bf9a06a82b6f2dce.js\" async=\"\"></script><script src=\"/_next/static/chunks/9a11ed41b14919c70d04b27fbbe4c200a8fb2826.74b2f28369c98fc0d95f.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-ecb22c1f789b91a83542.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/%5Bpost%5D-6ca1859d6a13c4dac224.js\" async=\"\"></script><script src=\"/_next/static/N47td1h-22qYjulmQ8gFC/_ssgManifest.js\" async=\"\"></script>"

  36 |     const browser = await webdriver(appPort, '/post-1')
  37 |     const html = await browser.eval('document.body.innerHTML')
> 38 |     expect(html).toMatch(/post.*post-1/)
     |                  ^
  39 |     expect(html).toMatch(/nextExport/)
  40 |   })
  41 | 

  at Object.<anonymous> (integration/auto-export/test/index.test.js:38:18)

● Auto Export › production › should update asPath after mount

expect(received).toMatch(expected)

Expected pattern: /\/zeit\/cmnt-2/
Received string:  "<head><meta charset=\"utf-8\"><meta name=\"viewport\" content=\"width=device-width\"><meta name=\"next-head-count\" content=\"2\"><link rel=\"preload\" href=\"/_next/static/chunks/main-9b58b62bbbaf95713227.js\" as=\"script\"><link rel=\"preload\" href=\"/_next/static/chunks/webpack-ccf5ab034a524403276a.js\" as=\"script\"><link rel=\"preload\" href=\"/_next/static/chunks/framework.ac53bf9a06a82b6f2dce.js\" as=\"script\"><link rel=\"preload\" href=\"/_next/static/chunks/9a11ed41b14919c70d04b27fbbe4c200a8fb2826.74b2f28369c98fc0d95f.js\" as=\"script\"><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app-ecb22c1f789b91a83542.js\" as=\"script\"><link rel=\"preload\" href=\"/_next/static/chunks/pages/%5Bpost%5D/%5Bcmnt%5D-50b2963c75036a310d67.js\" as=\"script\"></head><body><div id=\"__next\"><p>/[post]/[cmnt]</p></div><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/[post]/[cmnt]\",\"query\":{},\"buildId\":\"N47td1h-22qYjulmQ8gFC\",\"nextExport\":true,\"autoExport\":true,\"isFallback\":false}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills-4f190352f132b0d6d70a.js\"></script><script src=\"/_next/static/chunks/main-9b58b62bbbaf95713227.js\" async=\"\"></script><script src=\"/_next/static/chunks/webpack-ccf5ab034a524403276a.js\" async=\"\"></script><script src=\"/_next/static/chunks/framework.ac53bf9a06a82b6f2dce.js\" async=\"\"></script><script src=\"/_next/static/chunks/9a11ed41b14919c70d04b27fbbe4c200a8fb2826.74b2f28369c98fc0d95f.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/_app-ecb22c1f789b91a83542.js\" async=\"\"></script><script src=\"/_next/static/chunks/pages/%5Bpost%5D/%5Bcmnt%5D-50b2963c75036a310d67.js\" async=\"\"></script><script src=\"/_next/static/N47td1h-22qYjulmQ8gFC/_ssgManifest.js\" async=\"\"></script></body>"

  43 |     const browser = await webdriver(appPort, '/zeit/cmnt-2')
  44 |     const html = await browser.eval(`document.documentElement.innerHTML`)
> 45 |     expect(html).toMatch(/\/zeit\/cmnt-2/)
     |                  ^
  46 |   })
  47 | 
  48 |   it('should not replace URL with page name while asPath is delayed', async () => {

  at Object.<anonymous> (integration/auto-export/test/index.test.js:45:18)

● Auto Export › dev › Refreshes query on mount

expect(received).toMatch(expected)

Expected pattern: /post.*post-1/
Received string:  "<div id=\"__next\"><p>post: </p></div><script src=\"/_next/static/chunks/react-refresh.js?ts=1597376509867\"></script><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/[post]\",\"query\":{},\"buildId\":\"development\",\"nextExport\":true,\"autoExport\":true,\"isFallback\":false}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills.js?ts=1597376509867\"></script><script src=\"/_next/static/chunks/main.js?ts=1597376509867\"></script><script src=\"/_next/static/chunks/webpack.js?ts=1597376509867\"></script><script src=\"/_next/static/chunks/pages/_app.js?ts=1597376509867\"></script><script src=\"/_next/static/chunks/pages/%5Bpost%5D.js?ts=1597376509867\"></script><div id=\"__next-build-watcher\" style=\"position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;\"></div><div id=\"__next-prerender-indicator\" style=\"position: fixed; bottom: 20px; right: 10px; width: 0px; height: 0px; z-index: 99998; transition: all 100ms ease 0s;\"></div><script src=\"/_next/static/development/_ssgManifest.js?ts=1597376509867\"></script>"

  36 |     const browser = await webdriver(appPort, '/post-1')
  37 |     const html = await browser.eval('document.body.innerHTML')
> 38 |     expect(html).toMatch(/post.*post-1/)
     |                  ^
  39 |     expect(html).toMatch(/nextExport/)
  40 |   })
  41 | 

  at Object.<anonymous> (integration/auto-export/test/index.test.js:38:18)

● Auto Export › dev › should update asPath after mount

expect(received).toMatch(expected)

Expected pattern: /\/zeit\/cmnt-2/
Received string:  "<head><meta charset=\"utf-8\"><meta name=\"viewport\" content=\"width=device-width\"><meta name=\"next-head-count\" content=\"2\"><link rel=\"preload\" href=\"/_next/static/chunks/main.js?ts=1597376510633\" as=\"script\"><link rel=\"preload\" href=\"/_next/static/chunks/webpack.js?ts=1597376510633\" as=\"script\"><link rel=\"preload\" href=\"/_next/static/chunks/pages/_app.js?ts=1597376510633\" as=\"script\"><link rel=\"preload\" href=\"/_next/static/chunks/pages/%5Bpost%5D/%5Bcmnt%5D.js?ts=1597376510633\" as=\"script\"><noscript id=\"__next_css__DO_NOT_USE__\"></noscript><script charset=\"utf-8\" src=\"/_next/static/chunks/0.js\"></script></head><body><div id=\"__next\"><p>/[post]/[cmnt]</p></div><script src=\"/_next/static/chunks/react-refresh.js?ts=1597376510633\"></script><script id=\"__NEXT_DATA__\" type=\"application/json\">{\"props\":{\"pageProps\":{}},\"page\":\"/[post]/[cmnt]\",\"query\":{},\"buildId\":\"development\",\"nextExport\":true,\"autoExport\":true,\"isFallback\":false}</script><script nomodule=\"\" src=\"/_next/static/chunks/polyfills.js?ts=1597376510633\"></script><script src=\"/_next/static/chunks/main.js?ts=1597376510633\"></script><script src=\"/_next/static/chunks/webpack.js?ts=1597376510633\"></script><script src=\"/_next/static/chunks/pages/_app.js?ts=1597376510633\"></script><script src=\"/_next/static/chunks/pages/%5Bpost%5D/%5Bcmnt%5D.js?ts=1597376510633\"></script><div id=\"__next-build-watcher\" style=\"position: fixed; bottom: 10px; right: 20px; width: 0px; height: 0px; z-index: 99999;\"></div><div id=\"__next-prerender-indicator\" style=\"position: fixed; bottom: 20px; right: 10px; width: 0px; height: 0px; z-index: 99998; transition: all 100ms ease 0s;\"></div><script src=\"/_next/static/development/_ssgManifest.js?ts=1597376510633\"></script></body>"

  43 |     const browser = await webdriver(appPort, '/zeit/cmnt-2')
  44 |     const html = await browser.eval(`document.documentElement.innerHTML`)
> 45 |     expect(html).toMatch(/\/zeit\/cmnt-2/)
     |                  ^
  46 |   })
  47 | 
  48 |   it('should not replace URL with page name while asPath is delayed', async () => {

  at Object.<anonymous> (integration/auto-export/test/index.test.js:45:18)

test/integration/basepath/test/index.test.js

  • basePath development > should update dynamic params after mount correctly
  • basePath production > should update dynamic params after mount correctly
  • basePath serverless > should update dynamic params after mount correctly
Expand output

● basePath development › should update dynamic params after mount correctly

expect(received).toContain(expected) // indexOf

Expected substring: "slug: hello-dynamic"
Received string:    "slug:"

  261 |     const browser = await webdriver(context.appPort, '/docs/hello-dynamic')
  262 |     const text = await browser.elementByCss('#slug').text()
> 263 |     expect(text).toContain('slug: hello-dynamic')
      |                  ^
  264 |   })
  265 | 
  266 |   it('should navigate to index page with getStaticProps', async () => {

  at Object.<anonymous> (integration/basepath/test/index.test.js:263:18)

● basePath production › should update dynamic params after mount correctly

expect(received).toContain(expected) // indexOf

Expected substring: "slug: hello-dynamic"
Received string:    "slug:"

  261 |     const browser = await webdriver(context.appPort, '/docs/hello-dynamic')
  262 |     const text = await browser.elementByCss('#slug').text()
> 263 |     expect(text).toContain('slug: hello-dynamic')
      |                  ^
  264 |   })
  265 | 
  266 |   it('should navigate to index page with getStaticProps', async () => {

  at Object.<anonymous> (integration/basepath/test/index.test.js:263:18)
      at runMicrotasks (<anonymous>)

● basePath serverless › should update dynamic params after mount correctly

expect(received).toContain(expected) // indexOf

Expected substring: "slug: hello-dynamic"
Received string:    "slug:"

  261 |     const browser = await webdriver(context.appPort, '/docs/hello-dynamic')
  262 |     const text = await browser.elementByCss('#slug').text()
> 263 |     expect(text).toContain('slug: hello-dynamic')
      |                  ^
  264 |   })
  265 | 
  266 |   it('should navigate to index page with getStaticProps', async () => {

  at Object.<anonymous> (integration/basepath/test/index.test.js:263:18)

@ijjk
Copy link
Member

ijjk commented Aug 14, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js change/additional-paths Change
buildDuration 12s 12.4s ⚠️ +395ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +1.33 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js change/additional-paths Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.242 2.242 ✓
/ avg req/sec 1114.93 1115.05 +0.12
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.39 1.409 ⚠️ +0.02
/error-in-render avg req/sec 1798.06 1774.21 ⚠️ -23.85
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js change/additional-paths Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-b57f5ce..0446.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js change/additional-paths Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-65b0875..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js change/additional-paths Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js change/additional-paths Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js change/additional-paths Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js change/additional-paths Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js change/additional-paths Change
index.html gzip 946 B 946 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js change/additional-paths Change
buildDuration 13.9s 14s ⚠️ +139ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +1.33 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js change/additional-paths Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-b57f5ce..0446.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js change/additional-paths Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-65b0875..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js change/additional-paths Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js change/additional-paths Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js change/additional-paths Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js change/additional-paths Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary Timer/next.js change/additional-paths Change
_error.js 1.03 MB 1.03 MB ⚠️ +438 B
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ⚠️ +438 B
link.js 1.07 MB 1.07 MB ⚠️ +438 B
routerDirect.js 1.06 MB 1.06 MB ⚠️ +438 B
withRouter.js 1.06 MB 1.06 MB ⚠️ +438 B
Overall change 5.26 MB 5.26 MB ⚠️ +2.19 kB
Commit: f7bcf5b

@ijjk
Copy link
Member

ijjk commented Aug 14, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js change/additional-paths Change
buildDuration 12.7s 12.5s -194ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +1.37 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js change/additional-paths Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.359 2.315 -0.04
/ avg req/sec 1059.6 1079.71 +20.11
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.398 1.393 0
/error-in-render avg req/sec 1787.68 1794.37 +6.69
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js change/additional-paths Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-b57f5ce..0446.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js change/additional-paths Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-65b0875..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js change/additional-paths Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js change/additional-paths Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js change/additional-paths Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js change/additional-paths Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js change/additional-paths Change
index.html gzip 946 B 946 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js change/additional-paths Change
buildDuration 14.4s 15.1s ⚠️ +712ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +1.37 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js change/additional-paths Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-b57f5ce..0446.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js change/additional-paths Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-65b0875..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js change/additional-paths Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js change/additional-paths Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js change/additional-paths Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js change/additional-paths Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary Timer/next.js change/additional-paths Change
_error.js 1.03 MB 1.03 MB ⚠️ +454 B
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ⚠️ +454 B
link.js 1.07 MB 1.07 MB ⚠️ +454 B
routerDirect.js 1.06 MB 1.06 MB ⚠️ +454 B
withRouter.js 1.06 MB 1.06 MB ⚠️ +454 B
Overall change 5.26 MB 5.26 MB ⚠️ +2.27 kB
Commit: aa5bdab

@ijjk
Copy link
Member

ijjk commented Aug 14, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js change/additional-paths Change
buildDuration 11.1s 10.4s -705ms
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +1.37 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js change/additional-paths Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.989 1.914 -0.08
/ avg req/sec 1257.22 1306.04 +48.82
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.124 1.039 -0.09
/error-in-render avg req/sec 2223.94 2405.7 +181.76
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js change/additional-paths Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-b57f5ce..0446.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js change/additional-paths Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-65b0875..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js change/additional-paths Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js change/additional-paths Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js change/additional-paths Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js change/additional-paths Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js change/additional-paths Change
index.html gzip 946 B 946 B ✓
link.html gzip 954 B 954 B ✓
withRouter.html gzip 940 B 940 B ✓
Overall change 2.84 kB 2.84 kB ✓
Serverless Mode (Increase detected ⚠️)
General Overall increase ⚠️
vercel/next.js canary Timer/next.js change/additional-paths Change
buildDuration 12.1s 13.1s ⚠️ +1.1s
nodeModulesSize 57.3 MB 57.3 MB ⚠️ +1.37 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary Timer/next.js change/additional-paths Change
677f882d2ed8..c139.js gzip 10.2 kB 10.2 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-b57f5ce..0446.js gzip 6.74 kB 6.74 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary Timer/next.js change/additional-paths Change
677f882d2ed8..dule.js gzip 6.12 kB 6.12 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-65b0875..dule.js gzip 5.82 kB 5.82 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.8 kB 51.8 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js change/additional-paths Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js change/additional-paths Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js change/additional-paths Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js change/additional-paths Change
_buildManifest.js gzip 321 B 321 B ✓
_buildManife..dule.js gzip 329 B 329 B ✓
Overall change 650 B 650 B ✓
Serverless bundles Overall increase ⚠️
vercel/next.js canary Timer/next.js change/additional-paths Change
_error.js 1.03 MB 1.03 MB ⚠️ +454 B
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ⚠️ +454 B
link.js 1.07 MB 1.07 MB ⚠️ +454 B
routerDirect.js 1.06 MB 1.06 MB ⚠️ +454 B
withRouter.js 1.06 MB 1.06 MB ⚠️ +454 B
Overall change 5.26 MB 5.26 MB ⚠️ +2.27 kB
Commit: e37e568

@kodiakhq kodiakhq bot merged commit 3597978 into vercel:canary Aug 14, 2020
@Timer Timer deleted the change/additional-paths branch August 14, 2020 04:30
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@Timer
Modify low priority files in manifest (vercel#16181)
17f1133 
This pull request edits the `BuildManifest` that is sent to `/_document` instead of modifying a single input array to decouple its implementation details.

Optimally, we'd eliminate the `files` key all together.

---

Related to vercel#16182
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@lfades lfades Awaiting requested review from lfades

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Timer @ijjk