Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused router method #16149

Merged
merged 2 commits into from
Aug 13, 2020
Merged

Remove unused router method #16149

merged 2 commits into from
Aug 13, 2020

Conversation

Timer
Copy link
Member

@Timer Timer commented Aug 13, 2020

This PR removes a legacy router method that was used for old-style HMR, now replaced by Fast Refresh.

This method was not public:

export type NextRouter = BaseRouter &
  Pick<
    Router,
    | 'push'
    | 'replace'
    | 'reload'
    | 'back'
    | 'prefetch'
    | 'beforePopState'
    | 'events'
    | 'isFallback'
  >

Even if someone found this method, it's highly unlikely they could use it successfully—it required the full module object.

@ijjk
Copy link
Member

ijjk commented Aug 13, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
buildDuration 11.7s 11.6s -92ms
nodeModulesSize 57.3 MB 57.3 MB -1.75 kB
Page Load Tests Overall decrease ⚠️
vercel/next.js canary Timer/next.js remove/dead-method Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.041 2.134 ⚠️ +0.09
/ avg req/sec 1224.94 1171.36 ⚠️ -53.58
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.127 1.128 0
/error-in-render avg req/sec 2217.47 2217.08 ⚠️ -0.39
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
677f882d2ed8..ee8a.js gzip 10 kB 9.93 kB -88 B
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.5 kB -88 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
677f882d2ed8..dule.js gzip 5.92 kB 5.84 kB -81 B
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.5 kB -81 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js remove/dead-method Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js remove/dead-method Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js remove/dead-method Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js remove/dead-method Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary Timer/next.js remove/dead-method Change
index.html gzip 947 B 948 B ⚠️ +1 B
link.html gzip 955 B 956 B ⚠️ +1 B
withRouter.html gzip 940 B 942 B ⚠️ +2 B
Overall change 2.84 kB 2.85 kB ⚠️ +4 B

Diffs

Diff for 677f882d2ed8..a6bebf348.js 
@@ -1007,35 +1007,6 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
         }
 
         _createClass(Router, [
-          {
-            key: "update",
-            value: function update(route, mod) {
-              var Component = mod["default"] || mod;
-              var data = this.components[route];
-
-              if (!data) {
-                throw new Error(
-                  "Cannot update unavailable route: ".concat(route)
-                );
-              }
-
-              var newData = Object.assign({}, data, {
-                Component: Component,
-                __N_SSG: mod.__N_SSG,
-                __N_SSP: mod.__N_SSP
-              });
-              this.components[route] = newData; // pages/_app.js updated
-
-              if (route === "/_app") {
-                this.notify(this.components[this.route]);
-                return;
-              }
-
-              if (route === this.route) {
-                this.notify(newData);
-              }
-            }
-          },
           {
             key: "reload",
             value: function reload() {
Diff for 677f882d2ed8..91.module.js 
@@ -853,31 +853,6 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           }
         }
 
-        update(route, mod) {
-          var Component = mod.default || mod;
-          var data = this.components[route];
-
-          if (!data) {
-            throw new Error("Cannot update unavailable route: ".concat(route));
-          }
-
-          var newData = Object.assign({}, data, {
-            Component,
-            __N_SSG: mod.__N_SSG,
-            __N_SSP: mod.__N_SSP
-          });
-          this.components[route] = newData; // pages/_app.js updated
-
-          if (route === "/_app") {
-            this.notify(this.components[this.route]);
-            return;
-          }
-
-          if (route === this.route) {
-            this.notify(newData);
-          }
-        }
-
         reload() {
           window.location.reload();
         }
Diff for index.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.822a9f325587422a18e7.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c181104beb02c78c1519.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.822a9f325587422a18e7.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.822a9f325587422a18e7.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -122,13 +122,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c181104beb02c78c1519.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.822a9f325587422a18e7.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.822a9f325587422a18e7.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.c181104beb02c78c1519.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.822a9f325587422a18e7.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
buildDuration 13.1s 12.8s -227ms
nodeModulesSize 57.3 MB 57.3 MB -1.75 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
677f882d2ed8..ee8a.js gzip 10 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
677f882d2ed8..c5f5.js gzip N/A 9.93 kB N/A
Overall change 56.6 kB 56.5 kB -88 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
677f882d2ed8..dule.js gzip 5.92 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 5.84 kB N/A
Overall change 51.6 kB 51.5 kB -81 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js remove/dead-method Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js remove/dead-method Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js remove/dead-method Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js remove/dead-method Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB -558 B
routerDirect.js 1.06 MB 1.06 MB -558 B
withRouter.js 1.06 MB 1.06 MB -558 B
Overall change 5.26 MB 5.26 MB -1.67 kB
Commit: c86ba86

@ijjk
Copy link
Member

ijjk commented Aug 13, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
buildDuration 11.9s 12.2s ⚠️ +288ms
nodeModulesSize 57.3 MB 57.3 MB -1.75 kB
Page Load Tests Overall increase ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.074 2.093 ⚠️ +0.02
/ avg req/sec 1205.21 1194.31 ⚠️ -10.9
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.187 1.157 -0.03
/error-in-render avg req/sec 2106.1 2160.38 +54.28
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
677f882d2ed8..b9b7.js gzip 10 kB 9.93 kB -88 B
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.5 kB -88 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
677f882d2ed8..dule.js gzip 5.92 kB 5.84 kB -82 B
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.5 kB -82 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js remove/dead-method Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js remove/dead-method Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js remove/dead-method Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js remove/dead-method Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes
vercel/next.js canary Timer/next.js remove/dead-method Change
index.html gzip 948 B 949 B ⚠️ +1 B
link.html gzip 957 B 956 B -1 B
withRouter.html gzip 943 B 943 B ✓
Overall change 2.85 kB 2.85 kB ✓

Diffs

Diff for 677f882d2ed8..a3.module.js 
@@ -853,31 +853,6 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           }
         }
 
-        update(route, mod) {
-          var Component = mod.default || mod;
-          var data = this.components[route];
-
-          if (!data) {
-            throw new Error("Cannot update unavailable route: ".concat(route));
-          }
-
-          var newData = Object.assign({}, data, {
-            Component,
-            __N_SSG: mod.__N_SSG,
-            __N_SSP: mod.__N_SSP
-          });
-          this.components[route] = newData; // pages/_app.js updated
-
-          if (route === "/_app") {
-            this.notify(this.components[this.route]);
-            return;
-          }
-
-          if (route === this.route) {
-            this.notify(newData);
-          }
-        }
-
         reload() {
           window.location.reload();
         }
Diff for 677f882d2ed8..e42045eb9.js 
@@ -1007,35 +1007,6 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
         }
 
         _createClass(Router, [
-          {
-            key: "update",
-            value: function update(route, mod) {
-              var Component = mod["default"] || mod;
-              var data = this.components[route];
-
-              if (!data) {
-                throw new Error(
-                  "Cannot update unavailable route: ".concat(route)
-                );
-              }
-
-              var newData = Object.assign({}, data, {
-                Component: Component,
-                __N_SSG: mod.__N_SSG,
-                __N_SSP: mod.__N_SSP
-              });
-              this.components[route] = newData; // pages/_app.js updated
-
-              if (route === "/_app") {
-                this.notify(this.components[this.route]);
-                return;
-              }
-
-              if (route === this.route) {
-                this.notify(newData);
-              }
-            }
-          },
           {
             key: "reload",
             value: function reload() {
Diff for index.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7432ef7012751c677416.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b24a65d61f5e42045eb9.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8387d6359c388fc3a7a7.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7432ef7012751c677416.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7432ef7012751c677416.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -122,13 +122,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b24a65d61f5e42045eb9.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8387d6359c388fc3a7a7.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7432ef7012751c677416.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7432ef7012751c677416.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.b24a65d61f5e42045eb9.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.8387d6359c388fc3a7a7.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.684f19324ab7205510a3.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.7432ef7012751c677416.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
buildDuration 13.5s 13.5s ⚠️ +62ms
nodeModulesSize 57.3 MB 57.3 MB -1.75 kB
Client Bundles (main, webpack, commons) Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
677f882d2ed8..b9b7.js gzip 10 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-5c21840..49c9.js gzip 6.69 kB 6.69 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
677f882d2ed8..9460.js gzip N/A 9.93 kB N/A
Overall change 56.6 kB 56.5 kB -88 B
Client Bundles (main, webpack, commons) Modern Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
677f882d2ed8..dule.js gzip 5.92 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-c0c009b..dule.js gzip 5.78 kB 5.78 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 5.84 kB N/A
Overall change 51.6 kB 51.5 kB -82 B
Legacy Client Bundles (polyfills)
vercel/next.js canary Timer/next.js remove/dead-method Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary Timer/next.js remove/dead-method Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary Timer/next.js remove/dead-method Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary Timer/next.js remove/dead-method Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary Timer/next.js remove/dead-method Change
_error.js 1.03 MB 1.03 MB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB ✓
link.js 1.07 MB 1.07 MB -558 B
routerDirect.js 1.06 MB 1.06 MB -558 B
withRouter.js 1.06 MB 1.06 MB -558 B
Overall change 5.26 MB 5.26 MB -1.67 kB
Commit: 1ae1d24

@kodiakhq kodiakhq bot merged commit ff0571a into vercel:canary Aug 13, 2020
@Timer Timer deleted the remove/dead-method branch August 13, 2020 05:58
@timneutkens
Copy link
Member

Awesome 🚀

m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@Timer
Remove unused router method (vercel#16149)
c7e755b 
This PR removes a legacy router method that was used for old-style HMR, now replaced by Fast Refresh.

This method was not public:
```tsx
export type NextRouter = BaseRouter &
  Pick<
    Router,
    | 'push'
    | 'replace'
    | 'reload'
    | 'back'
    | 'prefetch'
    | 'beforePopState'
    | 'events'
    | 'isFallback'
  >
```

Even if someone found this method, it's highly unlikely they could use it successfully—it required the full module object.
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lfades lfades lfades approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Timer @ijjk @timneutkens @lfades