Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tslint disables #16116

Merged
merged 1 commit into from
Aug 12, 2020
Merged

Remove tslint disables #16116

merged 1 commit into from
Aug 12, 2020

Conversation

timneutkens
Copy link
Member

We no longer use tslint so these comments don't do anything.

@ijjk
Copy link
Member

ijjk commented Aug 12, 2020

Stats from current PR

Default Server Mode (Increase detected ⚠️)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
buildDuration 14.2s 14.2s -34ms
nodeModulesSize 57.3 MB 57.3 MB -1.46 kB
Page Load Tests Overall increase ✓
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.639 2.53 -0.11
/ avg req/sec 947.24 988.31 +41.07
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.564 1.533 -0.03
/error-in-render avg req/sec 1598.66 1630.74 +32.08
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
677f882d2ed8..6aa6.js gzip 10 kB 10 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-9a7a5f4..661e.js gzip 6.71 kB 6.71 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
677f882d2ed8..dule.js gzip 5.92 kB 5.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-d0ac695..dule.js gzip 5.79 kB 5.79 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Rendered Page Sizes Overall increase ⚠️
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
index.html gzip 945 B 947 B ⚠️ +2 B
link.html gzip 954 B 954 B ✓
withRouter.html gzip 939 B 940 B ⚠️ +1 B
Overall change 2.84 kB 2.84 kB ⚠️ +3 B

Diffs

Diff for 677f882d2ed8..29ff1dba4.js 
@@ -633,7 +633,6 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
           },
           off: function off(type, handler) {
             if (all[type]) {
-              // tslint:disable-next-line:no-bitwise
               all[type].splice(all[type].indexOf(handler) >>> 0, 1);
             }
           },
@@ -3300,11 +3299,9 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
               try {
                 _singletonRouter[eventField].apply(_singletonRouter, arguments);
               } catch (err) {
-                // tslint:disable-next-line:no-console
                 console.error(
                   "Error when running the Router event: ".concat(eventField)
-                ); // tslint:disable-next-line:no-console
-
+                );
                 console.error("".concat(err.message, "\n").concat(err.stack));
               }
             }
Diff for 677f882d2ed8..a6.module.js 
@@ -501,7 +501,6 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
 
           off(type, handler) {
             if (all[type]) {
-              // tslint:disable-next-line:no-bitwise
               all[type].splice(all[type].indexOf(handler) >>> 0, 1);
             }
           },
@@ -1718,11 +1717,9 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI
               try {
                 _singletonRouter[eventField](...arguments);
               } catch (err) {
-                // tslint:disable-next-line:no-console
                 console.error(
                   "Error when running the Router event: ".concat(eventField)
-                ); // tslint:disable-next-line:no-console
-
+                );
                 console.error("".concat(err.message, "\n").concat(err.stack));
               }
             }
Diff for index.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6e957134ad87644bd4a6.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.25e748ff47129ff1dba4.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6e957134ad87644bd4a6.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for link.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6e957134ad87644bd4a6.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -122,13 +122,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.25e748ff47129ff1dba4.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6e957134ad87644bd4a6.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Diff for withRouter.html 
@@ -24,7 +24,7 @@
     />
     <link
       rel="preload"
-      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6e957134ad87644bd4a6.module.js"
+      href="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
       as="script"
       crossorigin="anonymous"
     />
@@ -117,13 +117,13 @@
       type="module"
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.25e748ff47129ff1dba4.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.3d0d08a6a1da6bebf348.js"
       async=""
       crossorigin="anonymous"
       nomodule=""
     ></script>
     <script
-      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.6e957134ad87644bd4a6.module.js"
+      src="/_next/static/chunks/677f882d2ed86fa3467b8979053c1a4c3f8bc4df.e969023da6b448224391.module.js"
       async=""
       crossorigin="anonymous"
       type="module"
Serverless Mode (Decrease detected ✓)
General Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
buildDuration 16s 15.7s -368ms
nodeModulesSize 57.3 MB 57.3 MB -1.46 kB
Client Bundles (main, webpack, commons)
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
677f882d2ed8..6aa6.js gzip 10 kB N/A N/A
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
main-9a7a5f4..661e.js gzip 6.71 kB 6.71 kB ✓
webpack-ccf5..276a.js gzip 751 B 751 B ✓
677f882d2ed8..ee8a.js gzip N/A 10 kB N/A
Overall change 56.6 kB 56.6 kB ✓
Client Bundles (main, webpack, commons) Modern
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
677f882d2ed8..dule.js gzip 5.92 kB N/A N/A
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
main-d0ac695..dule.js gzip 5.79 kB 5.79 kB ✓
webpack-10c7..dule.js gzip 751 B 751 B ✓
677f882d2ed8..dule.js gzip N/A 5.92 kB N/A
Overall change 51.6 kB 51.6 kB ✓
Legacy Client Bundles (polyfills)
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
polyfills-75..1629.js gzip 31 kB 31 kB ✓
Overall change 31 kB 31 kB ✓
Client Pages
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
_app-874bd8a..0103.js gzip 1.28 kB 1.28 kB ✓
_error-fa39c..ec40.js gzip 3.45 kB 3.45 kB ✓
hooks-585f07..95a3.js gzip 887 B 887 B ✓
index-c7b63f..fc02.js gzip 227 B 227 B ✓
link-4c2bd9b..eadd.js gzip 1.29 kB 1.29 kB ✓
routerDirect..ebc7.js gzip 284 B 284 B ✓
withRouter-2..db68.js gzip 284 B 284 B ✓
Overall change 7.71 kB 7.71 kB ✓
Client Pages Modern
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
_app-97e743e..dule.js gzip 626 B 626 B ✓
_error-b4004..dule.js gzip 2.3 kB 2.3 kB ✓
hooks-696209..dule.js gzip 387 B 387 B ✓
index-a4dd74..dule.js gzip 226 B 226 B ✓
link-236a801..dule.js gzip 1.26 kB 1.26 kB ✓
routerDirect..dule.js gzip 284 B 284 B ✓
withRouter-1..dule.js gzip 282 B 282 B ✓
Overall change 5.37 kB 5.37 kB ✓
Client Build Manifests
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
_buildManifest.js gzip 273 B 273 B ✓
_buildManife..dule.js gzip 279 B 279 B ✓
Overall change 552 B 552 B ✓
Serverless bundles Overall decrease ✓
vercel/next.js canary timneutkens/next.js fix/remove-tslint-comments Change
_error.js 1.03 MB 1.03 MB -103 B
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.82 kB 3.82 kB ✓
index.js 1.03 MB 1.03 MB -103 B
link.js 1.07 MB 1.07 MB -192 B
routerDirect.js 1.06 MB 1.06 MB -192 B
withRouter.js 1.06 MB 1.06 MB -192 B
Overall change 5.26 MB 5.26 MB -782 B
Commit: 0719ccd

@kodiakhq kodiakhq bot merged commit e72ac76 into vercel:canary Aug 12, 2020
m-lautenbach pushed a commit to m-lautenbach/next.js that referenced this pull request Aug 20, 2020
@timneutkens
Remove tslint disables (vercel#16116)
4348ff4 
We no longer use tslint so these comments don't do anything.
@timneutkens timneutkens deleted the fix/remove-tslint-comments branch February 12, 2021 13:33
@vercel vercel locked as resolved and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Timer Timer Timer approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@lfades lfades Awaiting requested review from lfades

Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@timneutkens @ijjk @Timer