Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Our non-standard NODE_ENV error should know the target environment #14022

Closed
Timer opened this issue Jun 10, 2020 · 3 comments · Fixed by #14033
Closed

Our non-standard NODE_ENV error should know the target environment #14022

Timer opened this issue Jun 10, 2020 · 3 comments · Fixed by #14033
Labels
Developer Experience Issues related to Next.js logs, Error overlay, etc. good first issue Easy to fix issues, good for newcomers

Comments

@Timer
Copy link
Member

Timer commented Jun 10, 2020 •
edited

Our NON_STANDARD_NODE_ENV error should warn when it detects development during next start or next build and when it detects production during next dev.

See #14019 where we did not warn for development in production, used to bypass intentional restrictions.
@Timer Timer added good first issue Easy to fix issues, good for newcomers kind: story labels Jun 10, 2020
@Timer Timer added this to the 9.x.x milestone Jun 10, 2020
@moh12594
Copy link
Contributor

Hi @Timer , I can take it ! 🙂

@moh12594 moh12594 mentioned this issue Jun 10, 2020
Merged
@flohil flohil mentioned this issue Jun 11, 2020
Closed
@Timer Timer modified the milestones: 9.x.x, backlog Jun 15, 2020
@Timer Timer modified the milestones: backlog, 10.x.x Jan 4, 2021
@tomsturge
Copy link

Can this warning be suppressed?

@styfle styfle modified the milestones: 11.x.x, 12.0.4 Nov 5, 2021
@timneutkens timneutkens removed this from the 12.0.5 milestone Nov 17, 2021
@timneutkens timneutkens added the Developer Experience Issues related to Next.js logs, Error overlay, etc. label Nov 18, 2021
@kodiakhq kodiakhq bot closed this as completed in #14033 Dec 7, 2021
kodiakhq bot pushed a commit that referenced this issue Dec 7, 2021
@moh12594 @timneutkens
fix(NODE_ENV): Warn when launching start or build on development (#14033
d459b5f 
)

The PR aims to fix [#14022](#14022)

Co-authored-by: Tim Neutkens <6324199+timneutkens@users.noreply.github.com>
@balazsorban44
Copy link
Member

This issue has been automatically locked due to no recent activity. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@vercel vercel locked as resolved and limited conversation to collaborators Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Developer Experience Issues related to Next.js logs, Error overlay, etc. good first issue Easy to fix issues, good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(NODE_ENV): Warn when launching start or build on development moh12594/next.js
6 participants
@tomsturge @styfle @Timer @timneutkens @balazsorban44 @moh12594