Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove react redundant imports on examples #13169

Merged
merged 5 commits into from
May 22, 2020
Merged

chore: Remove react redundant imports on examples #13169

merged 5 commits into from
May 22, 2020
+6 −14

Conversation

willianjusten
Copy link
Contributor

@willianjusten willianjusten commented May 20, 2020 •
edited
Loading

This issue is related to #12964 . I covered the following examples

  • api-routes-apollo-server-and-client-auth
  • analyze-bundles
  • custom-server
  • custom-server-actionhero

willianjusten and others added 4 commits May 20, 2020 20:09
@willianjusten
Remove React redundant import on analyze-bundles example

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
e1c207a 
 Co-authored-by: Marcus Silva <mvfsillva@gmail.com>
@willianjusten @mvfsillva
Remove React redundant import on `api-routes-apollo-server-and-client…
051bad9 
…-auth` example

Co-authored-by: Marcus Silva <mvfsillva@gmail.com>
@willianjusten
Remove React redundant import on custom-server example
5593825 
    Co-authored-by: Marcus Silva <mvfsillva@gmail.com>
@willianjusten @mvfsillva
Remove React redundant import on custom-server-actionhero example
5e1cf01 
Co-authored-by: Marcus Silva <mvfsillva@gmail.com>
@willianjusten willianjusten mentioned this pull request May 20, 2020
Closed
@ijjk
Copy link
Member

ijjk commented May 20, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
buildDuration 13.5s 13s -513ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
/ failed reqs 0 0 ✓
/ total time (seconds) 2.292 2.395 ⚠️ +0.1
/ avg req/sec 1090.85 1043.66 -47.19
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.5 1.536 ⚠️ +0.04
/error-in-render avg req/sec 1666.3 1627.94 -38.36
Client Bundles (main, webpack, commons)
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
index.html gzip 928 B 928 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
buildDuration 14.5s 14.7s ⚠️ +173ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@rafaelalmeidatk rafaelalmeidatk added the examples Issue was opened via the examples template. label May 21, 2020
@ijjk
Copy link
Member

ijjk commented May 21, 2020

Stats from current PR

Default Server Mode (Decrease detected ✓)
General
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
buildDuration 10.9s 12.1s ⚠️ +1.1s
nodeModulesSize 61.8 MB 61.8 MB ✓
Page Load Tests Overall decrease ⚠️
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
/ failed reqs 0 0 ✓
/ total time (seconds) 1.894 1.805 -0.09
/ avg req/sec 1319.73 1384.68 ⚠️ +64.95
/error-in-render failed reqs 0 0 ✓
/error-in-render total time (seconds) 1.064 1.157 ⚠️ +0.09
/error-in-render avg req/sec 2348.7 2160.62 -188.08
Client Bundles (main, webpack, commons)
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Rendered Page Sizes
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
index.html gzip 928 B 928 B ✓
link.html gzip 937 B 937 B ✓
withRouter.html gzip 924 B 924 B ✓
Overall change 2.79 kB 2.79 kB ✓
Serverless Mode
General
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
buildDuration 11.9s 11.8s -73ms
nodeModulesSize 61.8 MB 61.8 MB ✓
Client Bundles (main, webpack, commons)
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
main-HASH.js gzip 6.49 kB 6.49 kB ✓
webpack-HASH.js gzip 746 B 746 B ✓
de003c3a9d30..fef6.js gzip 10.5 kB 10.5 kB ✓
framework.HASH.js gzip 39.1 kB 39.1 kB ✓
Overall change 56.9 kB 56.9 kB ✓
Client Bundles (main, webpack, commons) Modern
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
main-HASH.module.js gzip 5.58 kB 5.58 kB ✓
webpack-HASH..dule.js gzip 746 B 746 B ✓
de003c3a9d30..dule.js gzip 6.92 kB 6.92 kB ✓
framework.HA..dule.js gzip 39.1 kB 39.1 kB ✓
Overall change 52.4 kB 52.4 kB ✓
Legacy Client Bundles (polyfills)
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
polyfills-HASH.js gzip 26.3 kB 26.3 kB ✓
Overall change 26.3 kB 26.3 kB ✓
Client Pages
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_app.js gzip 1.26 kB 1.26 kB ✓
_error.js gzip 3.25 kB 3.25 kB ✓
hooks.js gzip 881 B 881 B ✓
index.js gzip 222 B 222 B ✓
link.js gzip 2.06 kB 2.06 kB ✓
routerDirect.js gzip 279 B 279 B ✓
withRouter.js gzip 278 B 278 B ✓
Overall change 8.22 kB 8.22 kB ✓
Client Pages Modern
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_app.module.js gzip 604 B 604 B ✓
_error.module.js gzip 2.04 kB 2.04 kB ✓
hooks.module.js gzip 383 B 383 B ✓
index.module.js gzip 223 B 223 B ✓
link.module.js gzip 1.52 kB 1.52 kB ✓
routerDirect..dule.js gzip 281 B 281 B ✓
withRouter.m..dule.js gzip 278 B 278 B ✓
Overall change 5.33 kB 5.33 kB ✓
Client Build Manifests
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_buildManifest.js gzip 61 B 61 B ✓
_buildManife..dule.js gzip 61 B 61 B ✓
Overall change 122 B 122 B ✓
Serverless bundles
zeit/next.js canary willianjusten/next.js chore/remove-react-redundant Change
_error.js 844 kB 844 kB ✓
404.html 4.18 kB 4.18 kB ✓
hooks.html 3.81 kB 3.81 kB ✓
index.js 844 kB 844 kB ✓
link.js 882 kB 882 kB ✓
routerDirect.js 874 kB 874 kB ✓
withRouter.js 874 kB 874 kB ✓
Overall change 4.33 MB 4.33 MB ✓

@timneutkens timneutkens merged commit 44d74e3 into vercel:canary May 22, 2020
@timneutkens
Copy link
Member

Thank you!

rokinsky pushed a commit to rokinsky/next.js that referenced this pull request Jul 11, 2020
@willianjusten @mvfsillva @rokinsky
chore: Remove react redundant imports on examples (vercel#13169)
2042cf2 
* Remove React redundant import on `analyze-bundles` example

 Co-authored-by: Marcus Silva <mvfsillva@gmail.com>

* Remove React redundant import on `api-routes-apollo-server-and-client-auth` example

Co-authored-by: Marcus Silva <mvfsillva@gmail.com>

* Remove React redundant import on `custom-server` example

    Co-authored-by: Marcus Silva <mvfsillva@gmail.com>

* Remove React redundant import on `custom-server-actionhero` example

Co-authored-by: Marcus Silva <mvfsillva@gmail.com>

Co-authored-by: Marcus Silva <mvfsillva@gmail.com>
@vercel vercel locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens

@lfades lfades

@Timer Timer

Assignees
No one assigned
Labels
examples Issue was opened via the examples template.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@willianjusten @ijjk @timneutkens @rafaelalmeidatk