From 9c2c8587be77c176216470a7789f9865e8c326b8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Donny/=EA=B0=95=EB=8F=99=EC=9C=A4?= Date: Tue, 15 Nov 2022 05:28:39 +0900 Subject: [PATCH] feat(next-swc/relay): Add `javascript` to language (#42894) Resolves https://github.com/vercel/next.js/discussions/35904#discussioncomment-3299461 --- packages/next-swc/crates/core/src/relay.rs | 4 ++++ packages/next-swc/crates/core/tests/telemetry.rs | 2 +- packages/next/server/config-shared.ts | 2 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/packages/next-swc/crates/core/src/relay.rs b/packages/next-swc/crates/core/src/relay.rs index dfae8c6ccf16d3c..0c4484270bafc62 100644 --- a/packages/next-swc/crates/core/src/relay.rs +++ b/packages/next-swc/crates/core/src/relay.rs @@ -15,6 +15,7 @@ use swc_core::{ #[serde(rename_all = "lowercase")] pub enum RelayLanguageConfig { TypeScript, + JavaScript, Flow, } @@ -99,6 +100,9 @@ impl<'a> Relay<'a> { RelayLanguageConfig::TypeScript => { format!("{}.graphql.ts", definition_name) } + RelayLanguageConfig::JavaScript => { + format!("{}.graphql.js", definition_name) + } }; if let Some(artifact_directory) = &self.config.artifact_directory { diff --git a/packages/next-swc/crates/core/tests/telemetry.rs b/packages/next-swc/crates/core/tests/telemetry.rs index 50bdb102ca4e7b6..c0f99b160d21949 100644 --- a/packages/next-swc/crates/core/tests/telemetry.rs +++ b/packages/next-swc/crates/core/tests/telemetry.rs @@ -48,7 +48,7 @@ export function getServerSideProps() { None, handler, &Default::default(), - comments.clone(), + comments, |_| next_ssg(eliminated_packages.clone()), |_| noop(), ) diff --git a/packages/next/server/config-shared.ts b/packages/next/server/config-shared.ts index f9b99a800ab8aad..b3b0878401da298 100644 --- a/packages/next/server/config-shared.ts +++ b/packages/next/server/config-shared.ts @@ -460,7 +460,7 @@ export interface NextConfig extends Record { relay?: { src: string artifactDirectory?: string - language?: 'typescript' | 'flow' + language?: 'typescript' | 'javascript' | 'flow' } removeConsole?: | boolean