From 720767d2891bfe2341d624205b1cb7539bc7a891 Mon Sep 17 00:00:00 2001 From: eps1lon Date: Mon, 29 Apr 2024 13:37:22 +0200 Subject: [PATCH] Fix image tests - fixed brittle onLoad test (see https://github.com/vercel/next.js/pull/37993) - src="" is now omitted --- .../next-image-new/default/test/index.test.ts | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/test/integration/next-image-new/default/test/index.test.ts b/test/integration/next-image-new/default/test/index.test.ts index 40fc3c76f6df1..0c2b59517d12b 100644 --- a/test/integration/next-image-new/default/test/index.test.ts +++ b/test/integration/next-image-new/default/test/index.test.ts @@ -373,7 +373,7 @@ function runTests(mode) { let browser = await webdriver(appPort, '/on-load') await browser.eval( - `document.getElementById("footer").scrollIntoView({behavior: "smooth"})` + `document.getElementById("msg1").scrollIntoView({behavior: "smooth"})` ) await check( @@ -1138,9 +1138,10 @@ function runTests(mode) { const warnings = (await browser.log()).filter( (log) => log.source === 'error' ) - expect(warnings.length).toBe(0) - expect(await browser.elementById('img').getAttribute('src')).toBe('') + expect(warnings).toEqual([]) + + expect(await browser.elementById('img').getAttribute('src')).toBe(null) expect(await browser.elementById('img').getAttribute('srcset')).toBe(null) expect(await browser.elementById('img').getAttribute('width')).toBe('200') expect(await browser.elementById('img').getAttribute('height')).toBe( @@ -1153,9 +1154,9 @@ function runTests(mode) { const warnings = (await browser.log()).filter( (log) => log.source === 'error' ) - expect(warnings.length).toBe(0) + expect(warnings).toEqual([]) - expect(await browser.elementById('img').getAttribute('src')).toBe('') + expect(await browser.elementById('img').getAttribute('src')).toBe(null) expect(await browser.elementById('img').getAttribute('srcset')).toBe(null) expect(await browser.elementById('img').getAttribute('width')).toBe('200') expect(await browser.elementById('img').getAttribute('height')).toBe( @@ -1571,7 +1572,6 @@ describe('Image Component Default Tests', () => { afterAll(async () => { await killApp(app) }) - runTests('server') } )