From 54bee4fb4d27d916fb40838d4b28cb2ccf4bfbf7 Mon Sep 17 00:00:00 2001 From: Joe Haddad Date: Fri, 15 Jan 2021 11:39:49 -0500 Subject: [PATCH] fix: resolve two peer dep install warnings (#21176) This removes the peer dep on `webpack` from `react-dev-overlay`, as it is for types only. This makes the peer dep on `webpack` optional for `react-refresh-utils`, as you can provide webpack via the constructor (how Next.js does). --- packages/react-dev-overlay/package.json | 3 +-- packages/react-dev-overlay/src/middleware.ts | 2 +- packages/react-refresh-utils/package.json | 5 +++++ 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/react-dev-overlay/package.json b/packages/react-dev-overlay/package.json index 62a141c5a648df5..e4a00330ed891e8 100644 --- a/packages/react-dev-overlay/package.json +++ b/packages/react-dev-overlay/package.json @@ -30,7 +30,6 @@ }, "peerDependencies": { "react": "^16.9.0 || ^17", - "react-dom": "^16.9.0 || ^17", - "webpack": "^4 || ^5" + "react-dom": "^16.9.0 || ^17" } } diff --git a/packages/react-dev-overlay/src/middleware.ts b/packages/react-dev-overlay/src/middleware.ts index baef529cb450dad..b27e6cb25da6ec6 100644 --- a/packages/react-dev-overlay/src/middleware.ts +++ b/packages/react-dev-overlay/src/middleware.ts @@ -9,8 +9,8 @@ import { } from 'source-map' import { StackFrame } from 'stacktrace-parser' import url from 'url' -// eslint-disable-next-line import/no-extraneous-dependencies // @ts-ignore +// eslint-disable-next-line import/no-extraneous-dependencies import webpack from 'webpack' import { getRawSourceMap } from './internal/helpers/getRawSourceMap' import { launchEditor } from './internal/helpers/launchEditor' diff --git a/packages/react-refresh-utils/package.json b/packages/react-refresh-utils/package.json index 850486aeea2a8e6..e7579d92ab3393b 100644 --- a/packages/react-refresh-utils/package.json +++ b/packages/react-refresh-utils/package.json @@ -22,6 +22,11 @@ "react-refresh": "0.8.3", "webpack": "^4 || ^5" }, + "peerDependenciesMeta": { + "webpack": { + "optional": true + } + }, "devDependencies": { "react-refresh": "0.8.3" }