From 29c5acd33b0754757e31cf724ed9b0ff83065234 Mon Sep 17 00:00:00 2001
From: Ishaq Ibrahim <74908398+ishaqibrahimbot@users.noreply.github.com>
Date: Mon, 31 Oct 2022 01:09:14 +0500
Subject: [PATCH] issue-41925 fix: skip duplicate props when transferring props
 from anchor to link (#42158)

Fixes issue #41925 by skipping duplicate props. I've tested the changes
locally - the duplicate prop is being skipped successfully. The
new-link.test.js suite is also passing.

<!--
Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change that you're making:
-->

## Bug

- [x] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm build && pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)

Co-authored-by: Ishaq Ibrahim <ishaq.ibrahim@convertdigital.com.au>
---
 .../new-link/handle-duplicate-props.input.js    |  9 +++++++++
 .../new-link/handle-duplicate-props.output.js   |  9 +++++++++
 .../transforms/__tests__/new-link.test.js       |  1 +
 packages/next-codemod/transforms/new-link.ts    | 17 ++++++++++++++---
 4 files changed, 33 insertions(+), 3 deletions(-)
 create mode 100644 packages/next-codemod/transforms/__testfixtures__/new-link/handle-duplicate-props.input.js
 create mode 100644 packages/next-codemod/transforms/__testfixtures__/new-link/handle-duplicate-props.output.js

diff --git a/packages/next-codemod/transforms/__testfixtures__/new-link/handle-duplicate-props.input.js b/packages/next-codemod/transforms/__testfixtures__/new-link/handle-duplicate-props.input.js
new file mode 100644
index 000000000000000..f45a3bcb4081822
--- /dev/null
+++ b/packages/next-codemod/transforms/__testfixtures__/new-link/handle-duplicate-props.input.js
@@ -0,0 +1,9 @@
+import Link from 'next/link'
+
+export default function Page() {
+  return (
+    <Link href="/about">
+      <a href="/about" className="some-class">Link</a>
+    </Link>
+  );
+}
diff --git a/packages/next-codemod/transforms/__testfixtures__/new-link/handle-duplicate-props.output.js b/packages/next-codemod/transforms/__testfixtures__/new-link/handle-duplicate-props.output.js
new file mode 100644
index 000000000000000..4d77892e2f23f8b
--- /dev/null
+++ b/packages/next-codemod/transforms/__testfixtures__/new-link/handle-duplicate-props.output.js
@@ -0,0 +1,9 @@
+import Link from 'next/link'
+
+export default function Page() {
+  return (
+    <Link href="/about" className="some-class">
+      Link
+    </Link>
+  );
+}
\ No newline at end of file
diff --git a/packages/next-codemod/transforms/__tests__/new-link.test.js b/packages/next-codemod/transforms/__tests__/new-link.test.js
index a9fac98fe3db7a2..60241c76d395884 100644
--- a/packages/next-codemod/transforms/__tests__/new-link.test.js
+++ b/packages/next-codemod/transforms/__tests__/new-link.test.js
@@ -11,6 +11,7 @@ const fixtures = [
   'spread-props',
   'link-string',
   'styled-jsx',
+  'handle-duplicate-props'
 ]
 
 for (const fixture of fixtures) {
diff --git a/packages/next-codemod/transforms/new-link.ts b/packages/next-codemod/transforms/new-link.ts
index ab84eaf918e9f5f..b0ca0de49c02cdb 100644
--- a/packages/next-codemod/transforms/new-link.ts
+++ b/packages/next-codemod/transforms/new-link.ts
@@ -86,13 +86,24 @@ export default function transformer(file: FileInfo, api: API) {
         const hasProps = props.length > 0
 
         if (hasProps) {
-          // Add props to <Link>
-          $link.get('attributes').value.push(...props)
+          // Add only unique props to <Link> (skip duplicate props)
+          const linkPropNames = $link
+            .get('attributes')
+            .value.map((linkProp) => linkProp?.name?.name)
+          const uniqueProps = []
+
+          props.forEach((anchorProp) => {
+            if (!linkPropNames.includes(anchorProp?.name?.name)) {
+              uniqueProps.push(anchorProp)
+            }
+          })
+
+          $link.get('attributes').value.push(...uniqueProps)
+
           // Remove props from <a>
           props.length = 0
         }
 
-        //
         const childrenProps = $childrenWithA.get('children')
         $childrenWithA.replaceWith(childrenProps.value)
       })