chore: add memory-fs to the devDependencies
#927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
styfle
changed the title
memory-fs to the devDependencies
styfle
reviewed
May 25, 2022
| @@ -71,6 +71,7 @@ | |||
| "mailgun": "^0.5.0", | |||
| "mariadb": "^2.0.1-beta", | |||
| "memcached": "^2.2.2", | |||
| "memory-fs": "^0.5.0", | |||
There was a problem hiding this comment.
You'll need to run yarn install so that it updates the yarn.lock file too
There was a problem hiding this comment.
I did.
However yarn.lock is not updated, because memory-fs already exists in yarn.lock.
Lines 10208 to 10214 in c9238cc
$ yarn why memory-fs
yarn why v1.22.18
[1/4] 🤔 Why do we have the module "memory-fs"...?
[2/4] 🚚 Initialising dependency graph...
warning Resolution field "grpc@1.24.11" is incompatible with requested version "grpc@1.23.3"
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "memory-fs@0.5.0"
info Has been hoisted to "memory-fs"
info Reasons this module exists
- Specified in "devDependencies"
- Hoisted from "ts-loader#enhanced-resolve#memory-fs"
info Disk size without dependencies: "52KB"
info Disk size with unique dependencies: "352KB"
info Disk size with transitive dependencies: "584KB"
info Number of shared dependencies: 9
✨ Done in 1.78s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks that
nccdepends tomemory-fsdirectly, but it is not in the dependencies.ncc/src/index.js
Line 6 in c9238cc
This pull request will fix a broken build in #921