Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring mainFields for nccing browser modules #832

Merged
merged 1 commit into from Dec 18, 2021
Merged

Allow configuring mainFields for nccing browser modules #832

merged 1 commit into from Dec 18, 2021

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Dec 18, 2021

Currently browser modules can not be ncc'd properly due to the mainFields preferring main over browser. This allows configuring this value so that browser modules can be ncc'd.

x-ref: vercel/next.js#32627

@ijjk ijjk mentioned this pull request Dec 18, 2021
Merged
@ijjk ijjk marked this pull request as ready for review December 18, 2021 07:17
@ijjk ijjk added the automerge Automatically merge PR once checks pass label Dec 18, 2021
@kodiakhq kodiakhq bot merged commit 9f80b95 into main Dec 18, 2021
@kodiakhq kodiakhq bot deleted the add/mainFields-config branch December 18, 2021 20:08
@github-actions github-actions bot mentioned this pull request May 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

@styfle styfle Awaiting requested review from styfle styfle is a code owner

@Timer Timer Awaiting requested review from Timer Timer is a code owner

Assignees
No one assigned
Labels
automerge Automatically merge PR once checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ijjk @guybedford